From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 41F2C1CEE4 for ; Fri, 6 Apr 2018 11:43:44 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CCCA88D6EC; Fri, 6 Apr 2018 09:43:43 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 721CEAFD5A; Fri, 6 Apr 2018 09:43:37 +0000 (UTC) Date: Fri, 6 Apr 2018 11:43:36 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com Message-ID: <20180406094336.xyibdb7hg5n3yoxx@dhcp-192-241.str.redhat.com> References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-18-jfreimann@redhat.com> <2f621b0a-9c96-d156-31b1-cd5270c8f2bb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2f621b0a-9c96-d156-31b1-cd5270c8f2bb@redhat.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 06 Apr 2018 09:43:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 06 Apr 2018 09:43:43 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 17/21] net/virtio: disable ctrl virtqueue for packed rings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 09:43:44 -0000 On Fri, Apr 06, 2018 at 11:38:50AM +0200, Maxime Coquelin wrote: > > >On 04/05/2018 12:10 PM, Jens Freimann wrote: >>Signed-off-by: Jens Freiman >>--- >> drivers/net/virtio/virtio_ethdev.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >>diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >>index dc220c743..7367d9c5d 100644 >>--- a/drivers/net/virtio/virtio_ethdev.c >>+++ b/drivers/net/virtio/virtio_ethdev.c >>@@ -1157,6 +1157,13 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features) >> req_features &= ~(1ull << VIRTIO_F_RING_PACKED); >> #endif >>+ if (req_features & (1ULL << VIRTIO_F_RING_PACKED)) { >>+ req_features &= ~(1ull << VIRTIO_NET_F_CTRL_MAC_ADDR); >>+ req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ); >>+ req_features &= ~(1ull << VIRTIO_NET_F_CTRL_RX); >>+ req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VLAN); >>+ } >>+ > >Does packed ring not support ctrl vqs, or is it just a workaround while >it is implemented? packed queues support virtqueues, but I had not implemented it yet. I have a patch for it though and will include it in v4. regards, Jens > >> /* >> * Negotiate features: Subset of device feature bits are written back >> * guest feature bits. >>