From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id BBF4A1D270
 for <dev@dpdk.org>; Fri,  6 Apr 2018 17:34:55 +0200 (CEST)
Received: from lfbn-lil-1-702-109.w81-254.abo.wanadoo.fr ([81.254.39.109]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1f4TOk-0005CK-QT; Fri, 06 Apr 2018 17:35:33 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Fri, 06 Apr 2018 17:34:50 +0200
Date: Fri, 6 Apr 2018 17:34:50 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Tomasz Duszynski <tdu@semihalf.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Ivan Malov <ivan.malov@oktetlabs.ru>
Message-ID: <20180406153450.lqmmg3e7zkjdsmo7@platinum>
References: <20180403124103.13124-1-olivier.matz@6wind.com>
 <20180406152148.23270-1-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180406152148.23270-1-olivier.matz@6wind.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC
 address
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 15:34:55 -0000


On Fri, Apr 06, 2018 at 05:21:48PM +0200, Olivier Matz wrote:
> Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> return code is added to notify the caller (librte_ether) if an error
> occurred in the PMD.
> 
> The new default MAC address is now copied in dev->data->mac_addrs[0]
> only if the operation is successful.
> 
> The patch also updates all the PMDs accordingly.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Sorry, "v3" is missing in the subject.
Please ignore, I'm sending it again with the proper title.