From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id D60C91CA87 for ; Sat, 7 Apr 2018 04:40:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2747; q=dns/txt; s=iport; t=1523068828; x=1524278428; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wnXh86q4WtSHdyU3nuiBB5V6FxIpRr/Mhz+/l16kWYg=; b=US9/InlE95b9k5n1k9q7pxZ7arTPLkMrpK8he0PWFGpqmQbLUHmnotQy rBZQhDiqWphvcO0wsZn+w1vbNXZmzQEMUu3Ethz4Jd1uQq2sHECLuENWa a+zeY46/fApVNb6n80UToXG6wK4FEuFCOE3vbEaSDR/xrc4di1lfeBwz3 o=; X-IronPort-AV: E=Sophos;i="5.48,417,1517875200"; d="scan'208";a="377601902" Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2018 02:40:27 +0000 Received: from HYONKIM-FTCPE.cisco.com ([10.24.132.13]) by rcdn-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id w372eOf4026941 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 7 Apr 2018 02:40:26 GMT Date: Sat, 7 Apr 2018 11:40:23 +0900 From: Hyong Youb Kim To: Ferruh Yigit Cc: John Daley , dev@dpdk.org, Thomas Monjalon Message-ID: <20180407024022.GA13524@HYONKIM-FTCPE.cisco.com> References: <20180404235455.17241-1-johndale@cisco.com> <20180404235455.17241-2-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH] net/enic: enable overlay offload for VXLAN and GENEVE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2018 02:40:29 -0000 On Fri, Apr 06, 2018 at 05:15:40PM +0100, Ferruh Yigit wrote: > On 4/5/2018 12:54 AM, John Daley wrote: > > From: Hyong Youb Kim > > > > Recent NIC models support overlay offload. The overlay offload > > feature enables the following on the NIC. > > - Rx/Tx checksum offloads for both inner and outer packets. > > - Rx inner packet type classification. > > - TSO. > > - Inner RSS. > > > > TX descriptors do not require any changes, except the header length > > for TSO. The NIC parses outer/inner packets and performs offloads on > > them as necessary. The header length for tunneled TSO includes both > > inner and outer headers. > > > > The NIC actually parses and performs the above for NVGRE as well. DPDK > > currently has no offload flags for NVGRE, and the hardware has no > > controls to individually enable tunnel types either. So do nothing for > > now. > > > > Add a config flag to enable overlay offload by default. To disable it, > > the user should set it to 'n'. > > > > CONFIG_RTE_LIBRTE_ENIC_ENABLE_OVERLAY_OFFLOAD=y > > > > Also update the enic guide doc. > > > > Signed-off-by: Hyong Youb Kim > > Reviewed-by: John Daley > > --- > > config/common_base | 1 + > > doc/guides/nics/enic.rst | 52 ++++++++++++++++++ > > drivers/net/enic/base/vnic_dev.c | 33 ++++++++++++ > > drivers/net/enic/base/vnic_dev.h | 5 +- > > drivers/net/enic/base/vnic_devcmd.h | 12 +++++ > > drivers/net/enic/base/vnic_wq.h | 1 + > > drivers/net/enic/enic.h | 6 +++ > > drivers/net/enic/enic_ethdev.c | 21 ++------ > > drivers/net/enic/enic_main.c | 25 +++++++++ > > drivers/net/enic/enic_res.c | 23 ++++++++ > > drivers/net/enic/enic_rxtx.c | 104 ++++++++++++++++++++++++++++-------- > > 11 files changed, 241 insertions(+), 42 deletions(-) > > > > diff --git a/config/common_base b/config/common_base > > index c09c7cf88..964e37b6e 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -205,6 +205,7 @@ CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=n > > # Compile burst-oriented Cisco ENIC PMD driver > > # > > CONFIG_RTE_LIBRTE_ENIC_PMD=y > > +CONFIG_RTE_LIBRTE_ENIC_ENABLE_OVERLAY_OFFLOAD=y > > Hi John, > > We are trying to reduce config options we have, is overlay offload enabling can > be done via runtime argument or dedicated offload flag? Hi, Would you accept a devarg? We would enable overlay offload by default, and disable it when the app specifies that devarg. This overlay offload is a bunch of things under one roof, and it does not play nicely with DPDK offload flags. Thanks. -Hyong