* [dpdk-dev] [PATCH] vmxnet3: fill in imissed stat with pktsRxOutOfBuf
@ 2018-04-07 17:29 Jon DeVree
2018-04-11 5:02 ` Yong Wang
0 siblings, 1 reply; 3+ messages in thread
From: Jon DeVree @ 2018-04-07 17:29 UTC (permalink / raw)
To: dev; +Cc: skhare, yongwang, Jon DeVree
This counter comes from a "hardware" register of the vmxnet3 device and
seems to behave like the MPC (Missed Packet Count) register of the Intel
NICs. So I think this data belongs in the imissed field rather than the
rx_nombuf field.
Signed-off-by: Jon DeVree <nuxi@vault24.org>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 426008722..4ef2d7d3b 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1015,7 +1015,7 @@ vmxnet3_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->q_errors[i] = rxStats.pktsRxError;
stats->ierrors += rxStats.pktsRxError;
- stats->rx_nombuf += rxStats.pktsRxOutOfBuf;
+ stats->imissed += rxStats.pktsRxOutOfBuf;
}
return 0;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: fill in imissed stat with pktsRxOutOfBuf
2018-04-07 17:29 [dpdk-dev] [PATCH] vmxnet3: fill in imissed stat with pktsRxOutOfBuf Jon DeVree
@ 2018-04-11 5:02 ` Yong Wang
2018-04-13 23:19 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wang @ 2018-04-11 5:02 UTC (permalink / raw)
To: Jon DeVree, dev
On 4/7/18, 10:30 AM, "Jon DeVree" <nuxi@vault24.org> wrote:
This counter comes from a "hardware" register of the vmxnet3 device and
seems to behave like the MPC (Missed Packet Count) register of the Intel
NICs. So I think this data belongs in the imissed field rather than the
rx_nombuf field.
Signed-off-by: Jon DeVree <nuxi@vault24.org>
---
Acked-by: Yong Wang <yongwang@vmware.com>
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 426008722..4ef2d7d3b 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1015,7 +1015,7 @@ vmxnet3_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->q_errors[i] = rxStats.pktsRxError;
stats->ierrors += rxStats.pktsRxError;
- stats->rx_nombuf += rxStats.pktsRxOutOfBuf;
+ stats->imissed += rxStats.pktsRxOutOfBuf;
}
return 0;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] vmxnet3: fill in imissed stat with pktsRxOutOfBuf
2018-04-11 5:02 ` Yong Wang
@ 2018-04-13 23:19 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-04-13 23:19 UTC (permalink / raw)
To: Yong Wang, Jon DeVree, dev
On 4/11/2018 6:02 AM, Yong Wang wrote:
> On 4/7/18, 10:30 AM, "Jon DeVree" <nuxi@vault24.org> wrote:
>
> This counter comes from a "hardware" register of the vmxnet3 device and
> seems to behave like the MPC (Missed Packet Count) register of the Intel
> NICs. So I think this data belongs in the imissed field rather than the
> rx_nombuf field.
>
> Signed-off-by: Jon DeVree <nuxi@vault24.org>
> ---
> Acked-by: Yong Wang <yongwang@vmware.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-13 23:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-07 17:29 [dpdk-dev] [PATCH] vmxnet3: fill in imissed stat with pktsRxOutOfBuf Jon DeVree
2018-04-11 5:02 ` Yong Wang
2018-04-13 23:19 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).