Re: [dpdk-dev] [PATCH v3 00/12] event/octeontx: add event timer adapter driver

[Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>]

Hi Jerin,

On Sun, Apr 08, 2018 at 08:25:35AM +0530, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Tue,  3 Apr 2018 20:35:02 +0530
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
> >  erik.g.carrillo@intel.com
> > Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v3 00/12] event/octeontx: add event timer
> >  adapter driver
> > X-Mailer: git-send-email 2.16.3
> >
> > The event timer adapter[1] provides APIs to configure an event timer device
> > that allows an application to arm timers which on expiry push events to an
> > event device such as OcteonTx SSO.
> > The OcteonTx TIM is a co-processor that can be configured as an event timer
> > adapter which can be used by an application to manage event timers.
> >
> > The TIM co-processor processes the event timers registered and pushes
> > expired event timers to SSO based on the event queue, schedule type, flow
> > id etc. provided as rte_event while arming the event timer. It maintains
> > event timers with high precision and time granularity of 1us (microsecond).
> >
> > [1] http://dpdk.org/dev/patchwork/patch/33525/
> >
> > This patch set depends on:
> > 1. http://dpdk.org/dev/patchwork/bundle/pbhagavatula/event_timerdev_v9
> > 2. http://dpdk.org/dev/patchwork/patch/35216/
> > 3. http://dpdk.org/dev/patchwork/patch/36089/
> >
> > v3 Changes:
> > - change datapath function return from int to uint16_t.
> > - Add missing state checks while arm/cancel.
> > - add stats.
> >
> > v2 Changes:
> > - Move common code changes to separate patches.
> > - Reduce ifdef clutter.
> > - fix improper return value (erik).
> > - remove redundent ops assignment (erik).
> > - update octeontx documentation.
>
> Please check the following :
>
> 1) It has build issue with 32bit build(gcc 7.3.1)
>
> 2) clang6 shows some crazy link errors, even though following symbol
> has been not used. Looks like we need -latomic
> undefined reference to `__atomic_fetch_add_8'
>
> 3) Fix check-git-log.sh issues
> $./devtools/check-git-log.sh
> Wrong headline lowercase:
> 	event/octeontx: add multiproducer timer arm and cancel
> 	event/octeontx: add single producer timer arm variant
> 	event/octeontx: add burst mode for timer arm

Thanks for the review, will send out v4 with the changes.

Pavan.

>