From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 2358B1B668 for ; Sun, 8 Apr 2018 23:27:56 +0200 (CEST) Received: by mail-qk0-f181.google.com with SMTP id w6so7195996qkb.4 for ; Sun, 08 Apr 2018 14:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=pxfXp3FiF/ACd2k97kBJ5TCEkm8O5amd9VHwdFtiv1A=; b=YsOuY3VOm1RhvhmWEW8H53uYp7X6Vw+9sHm0BeUXyyoSreOfkUo35dHI6AHMc/9hM8 /h2XX8FMWnekLj6SrhzhMoPkHzFVZG1p6iv5oNAgf0lKBqTKGpglfgBu08Kho0Rkxl1P hAuY3H7ifmsUd7rx4q/nlD5XsdlsNnGrCC8a6w5dcXnMqcSsXjwbZowhuRnQqtP3GAQM 0rJ9MIs4tV9wXG3gOp+zruPDqSB4PP7zU/Lk0mChqLxH/LBaakQtzB3Bo0ambwSF92jD P/IiCT2o6EuVxIOv+tsqnD2tDK3yV9e4K3UWK7it5Cbj32o13/1QH7/5eePGRDCEbIwH wSYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pxfXp3FiF/ACd2k97kBJ5TCEkm8O5amd9VHwdFtiv1A=; b=boysfHhujrAHFSuFei2TlQqUCVezHUiKUNj7qFr2H4OkhZjJiV6+zFD0NLDC4YReei ue868WPoNlWHi2N8ahQR5YWfP5MuRKwlVVPblCzQIIALVb+XnNVLKwp9Fu596SqVDZFO TYKcONVnb3B1Jihu4t10y88P9YCgL054Eq4mFmu3aun3M2CmzNSqWSR9JmWs5y2bIT7F HxEZOPuMC2/BcqVeE1zPvrjV5TnDc/9COx/tC0mh0qTPkB9G8iLDRyTGkEoJXLapzR/g lUqkyj+hqQcdGGDBubrPWrXGCGx1hcy/lAhn8cR8h3d0neYIp+Dyc4lHLLo5AhCwvL9d wsbA== X-Gm-Message-State: ALQs6tAH+x5YiGMaZjJ73IXv23uM46o/yE+VDdW5SkylSr78bvVpA420 OM61Lj+0mb/YOaHzMwTyxlE= X-Google-Smtp-Source: AIpwx49XdqLey5vNNP8+HDYcHYUU3In1MkFLeQrD2nWjB9kMLf9n9ZRmqErz2jvnYLG+R9rGsICWrQ== X-Received: by 10.55.54.212 with SMTP id d203mr47549714qka.200.1523222875415; Sun, 08 Apr 2018 14:27:55 -0700 (PDT) Received: from localhost.localdomain ([177.10.56.96]) by smtp.gmail.com with ESMTPSA id q100sm12290790qkh.43.2018.04.08.14.27.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Apr 2018 14:27:54 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id D59B4180930; Sun, 8 Apr 2018 18:27:50 -0300 (-03) Date: Sun, 8 Apr 2018 18:27:50 -0300 From: Marcelo Ricardo Leitner To: Adrien Mazarguil Cc: dev@dpdk.org, Timothy Redaelli Message-ID: <20180408212750.GA27045@localhost.localdomain> References: <20180403175938.GA23889@localhost.localdomain> <20180405092621.GI4957@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180405092621.GI4957@6wind.com> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [dpdk-dev] Question on documentation / Mellanox ConnectX-3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Apr 2018 21:27:56 -0000 On Thu, Apr 05, 2018 at 11:26:21AM +0200, Adrien Mazarguil wrote: > On Tue, Apr 03, 2018 at 02:59:38PM -0300, Marcelo Ricardo Leitner wrote: > > Hi, > > > > http://docs.openvswitch.org/en/latest/howto/dpdk/ says: > > > > Some NICs (i.e. Mellanox ConnectX-3) have only one PCI address > > associated with multiple ports. Using a PCI device like above won’t > > work. Instead, below usage is suggested: > > > > $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01" > > $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ > > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02" > > > > But these MACs are 7 bytes long. Seems the idea was to mention the two > > incremental MAC addresses that the ports have, and thus the ':55' > > should have been removed from there, right? > > > > Reading the code, it doesn't seem prepared to handle the extra byte in > > any (special) way. > > After a quick glance at the original patch [1], I confirm it looks like a > mistake in the OVS documentation. MAC addresses should be 6 bytes long, the > 7th byte is not a workaround to identify a physical port like I initially > thought. > > As you pointed out, since default MAC addresses on mlx4 ports are normally > incremental, documentation should read something like: > > $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55" > $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56" > > [1] https://github.com/openvswitch/ovs/commit/5e7588186839 Thanks Adrien. Question now is, who can fix the doc? Marcelo