From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 10BE21B73E for ; Mon, 9 Apr 2018 09:47:20 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id x82so14505177wmg.1 for ; Mon, 09 Apr 2018 00:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jGGB1dVpq2DMLkXacVrx48NiU5/2kQRfD6LyJanNXCQ=; b=xJxZ9C1Knmz0guvTMFP/QGJqE8B/czCDywggJmgrYTuUJyxFA07Byq2L28RDnjoLB/ Oh/oVOFN43dkU1RfbQ06zGG8/N/HRLV4os35WuGYh2V6i9S5cawFHRHsQXqAhbWdjb8V 4URYIKZCPdodKTqvqETQp2NySTHzmaTSh1vCVQdwedlz+4P7BLSWJHPtl5ZzHDlHKypc CvfishVhdK18R+bz5tbc+bGLpjpYKTgFOo3/e/9xrhP62k93lugvtcBtML+hfwhauSyp HJkNmM0f/DiDetEqeO8ZQNRjyZxti88m74S+jDcoYx1FNF2AhrOQlN+3D8onoTXWro+C v7SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jGGB1dVpq2DMLkXacVrx48NiU5/2kQRfD6LyJanNXCQ=; b=fHfvDgNj/ktdtH8+jYRnaf0fCYaslwodgSVHtaBuhRSIBRanVSSw6KFi+EcXYqStos 8nDYF4po7osUV7cUl0LvSB8jgdY0Ak5WXd7ZCdl9KmOvsydzAsjQHjKIlfHIAQo7F4hA zK/qcdMaX0WvxECEl782holU6Ija7oWv9/H/ocyflagR4EBo6opVfjb+FMcgpta71Q3r NR52bxfa3zWr2OJyKr0+/n88bNK2FDOSqvk9dK+GYYgB1kHLEVh7ESmdLUgudZNNbDGQ LCQ0cYmZ4NHXqXthhEYfBYbhmqZA02e4Zn8hmLavRn8t1ofINN2FlJ6wEkjSeTuVq+nv RqdQ== X-Gm-Message-State: ALQs6tAwTKcu/RSL9oDwxjZyb8MeS0ajyD3NckQQrzm0Pye2khW0Cbgd OOi3Rvj95q4liFdfy4sAJAFTLLSP X-Google-Smtp-Source: AIpwx4+vDkgSfFwX2jIMU2LKi5O0OCOVyAR4mn5ptXVeGusfUzxeqcs93J1/KBn4qji38BJecON/3Q== X-Received: by 10.28.238.2 with SMTP id m2mr17441578wmh.135.1523260039624; Mon, 09 Apr 2018 00:47:19 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z11sm1273355wre.15.2018.04.09.00.47.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Apr 2018 00:47:18 -0700 (PDT) Date: Mon, 9 Apr 2018 09:47:05 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: "dev@dpdk.org" Message-ID: <20180409074705.p4y56y43ef2fszso@bidouze.vm.6wind.com> References: <06ec9fd8f884c6d3cffb8a24c0d9ac71d589812d.1522358422.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 18/20] ethdev: register ether layer as a class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 07:47:20 -0000 Hi Matan, On Mon, Apr 09, 2018 at 07:41:58AM +0000, Matan Azrad wrote: > Hi Gaetan > > From: Gaetan Rivet, Friday, March 30, 2018 12:24 AM > > Signed-off-by: Gaetan Rivet > > --- > > lib/Makefile | 2 +- > > lib/librte_ether/Makefile | 3 +- > > lib/librte_ether/rte_class_eth.c | 73 > > ++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 76 insertions(+), 2 deletions(-) create mode 100644 > > lib/librte_ether/rte_class_eth.c > > > > diff --git a/lib/Makefile b/lib/Makefile index 4206485d3..47513f03f 100644 > > --- a/lib/Makefile > > +++ b/lib/Makefile > > @@ -23,7 +23,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += > > librte_cmdline DEPDIRS-librte_cmdline := librte_eal > > DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ether DEPDIRS-librte_ether > > := librte_net librte_eal librte_mempool librte_ring -DEPDIRS-librte_ether += > > librte_mbuf > > +DEPDIRS-librte_ether += librte_mbuf librte_kvargs > > DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev DEPDIRS- > > librte_bbdev := librte_eal librte_mempool librte_mbuf > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += librte_cryptodev diff --git > > a/lib/librte_ether/Makefile b/lib/librte_ether/Makefile index > > 3ca5782bb..a1a0393de 100644 > > --- a/lib/librte_ether/Makefile > > +++ b/lib/librte_ether/Makefile > > @@ -12,13 +12,14 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS > > += -O3 CFLAGS += $(WERROR_FLAGS) LDLIBS += -lrte_net -lrte_eal - > > lrte_mempool -lrte_ring -LDLIBS += -lrte_mbuf > > +LDLIBS += -lrte_mbuf -lrte_kvargs > > > > EXPORT_MAP := rte_ethdev_version.map > > > > LIBABIVER := 8 > > > > SRCS-y += rte_ethdev.c > > +SRCS-y += rte_class_eth.c > > SRCS-y += rte_flow.c > > SRCS-y += rte_tm.c > > SRCS-y += rte_mtr.c > > diff --git a/lib/librte_ether/rte_class_eth.c b/lib/librte_ether/rte_class_eth.c > > new file mode 100644 > > index 000000000..97d24781d > > --- /dev/null > > +++ b/lib/librte_ether/rte_class_eth.c > > @@ -0,0 +1,73 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2018 Gaëtan Rivet > > + */ > > + > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "rte_ethdev.h" > > +#include "rte_ethdev_core.h" > > + > > +enum eth_params { > > + RTE_ETH_PARAMS_MAX, > > +}; > > + > > +static const char *eth_params_keys[] = { > > + [RTE_ETH_PARAMS_MAX] = NULL, > > +}; > > + > > +static int > > +eth_dev_match(struct rte_eth_dev *edev, > > + struct rte_kvargs *kvlist) > > +{ > > + (void) kvlist; > > + (void) edev; > > + return 0; > > +} > > + > > +static void * > > +eth_dev_iterate(const void *_start, > > + const char *str, > > + const struct rte_dev_iterator *it) > > +{ > > + const struct rte_eth_dev *start = _start; > > + struct rte_device *dev = it->device; > > + struct rte_kvargs *kvargs = NULL; > > + struct rte_eth_dev *edev = NULL; > > + uint16_t p = 0; > > + > > + if (str != NULL) { > > + kvargs = rte_kvargs_parse(str, eth_params_keys); > > + if (kvargs == NULL) { > > + RTE_LOG(ERR, EAL, "cannot parse argument list\n"); > > + rte_errno = EINVAL; > > + return NULL; > > + } > > + } > > + if (start) > > + p = start->data->port_id + 1; > > + for (p = rte_eth_find_next(p); > > + p < RTE_MAX_ETHPORTS; > > + p = rte_eth_find_next(p + 1)) { > > What are about differed\owned\bonded devices? > What is actually the use cases of this iterator? > DPDK internal management or applications? > This API is public, so anyone can use it. It should be primarily used by internal systems however. I do not think Applications would be interested in calling the dev_iterate ops. The EAL would provide a way to list interfaces from each layers. Then DPDK libraries (such as librte_ether) would translate this following their internal rules. librte_ether would thus for example here translate an rte_eth_dev handle to a port_id, that an application could use. If there was a need to filter by owner_id, then it would be the job of librte_ether. The EAL cannot keep track of layers specifics, it can only provide generic APIs. > > + edev = &rte_eth_devices[p]; > > + if (dev != edev->device) > > + goto next_ethdev; > > + if (eth_dev_match(edev, kvargs) == 0) > > + break; > > +next_ethdev: > > + edev = NULL; > > + } > > + rte_kvargs_free(kvargs); > > + return edev; > > +} > > + > > +struct rte_class rte_class_eth = { > > + .dev_iterate = eth_dev_iterate, > > +}; > > + > > +RTE_REGISTER_CLASS(eth, rte_class_eth); > > -- > > 2.11.0 > -- Gaëtan Rivet 6WIND