From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <adrien.mazarguil@6wind.com> Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id D24387EBF for <dev@dpdk.org>; Mon, 9 Apr 2018 17:00:47 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id l49so9930356wrl.4 for <dev@dpdk.org>; Mon, 09 Apr 2018 08:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=212ZuiudTyDeecZFqX4Xp5+GXY0G6n1p2KR+MSVEUtA=; b=I1e+9TryPCTZ3PCSXeZw5OAwYYExY5tX9Etc4tnmTrsd2ELT+J2MAdZC/KmjpNXS1b 46TV69ohGCL9DHy3Ksz6sZmcJZf1i5nbgFBjNbIS+uem7nB48IXruH5b/uumnbutUYGP mGwudn3N8Z1Jm1/JCah4inYI8pNXsoxMKpFzESFi+N8X37cx8ZI2sKLifO5ikG3/ak0W ykGPQUu+ZgpX/v3OtAbVVCFzimgDr2SeYjg4NCofKPDEqyNsKi4kjGkqMdocJ5yN7pJH wkTmPumamMkCljkuL9OAHXaPKyuxtKRlt4OF/dJuKtFOhSGvUT06g16hATeS2lc/Jqtg YuvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=212ZuiudTyDeecZFqX4Xp5+GXY0G6n1p2KR+MSVEUtA=; b=cvSQnNJyS8ag2hFkGCDSV+2BWNLBNDQrjw+aq7Nr/HsmDJZslGVYQw9vz6hWGocaeA 60Dw3gimciHtdPWcdLdfKf4PL/oSPgVOnBq1lnalbfO8dzIwjS7ZQhlPc1lRyJ30I5ya 9flXfKu8aSFa9tyBNN5HtKxLFJkYfMHanT2vbBpiHR2/wdZQzlY2ACTfG+4Aqz3jrD5g STvlIv9Dv0GtL6BiUkE8hYUiMrlAxQCh9JJ9YE7rN/Aqn6Jr0jrhPDoZ+3wIf+8M1Lyj G4d5agVD2U/EUgBmqQz6JsgNal13bZmzMOqsYcAZt4lGYoCHLgaFuomkZk7h5GYrRzPx q6Dg== X-Gm-Message-State: AElRT7G2uoA1YTQEyhD4czBDuCqY68VFwKf0wTx/043XVKDF4O8cyqJz V9xvtcVF2cj0f9VvR26VC1oSOA== X-Google-Smtp-Source: AIpwx4+CJLmFwi+nwgUkIh6c3ipylYjf59dfhU7xnx9kKAMgbTqixw6wYxL7FZ++P41cxvTF7+f6dA== X-Received: by 10.223.176.253 with SMTP id j58mr26153300wra.269.1523286047530; Mon, 09 Apr 2018 08:00:47 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n21sm1185711wmi.37.2018.04.09.08.00.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Apr 2018 08:00:46 -0700 (PDT) Date: Mon, 9 Apr 2018 17:00:33 +0200 From: Adrien Mazarguil <adrien.mazarguil@6wind.com> To: Andrew Rybchenko <arybchenko@solarflare.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, "Zhang, Qi Z" <qi.z.zhang@intel.com> Message-ID: <20180409150033.GB4957@6wind.com> References: <20180404150312.12304-1-adrien.mazarguil@6wind.com> <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180406131736.19145-15-adrien.mazarguil@6wind.com> <07a42ecb-3a82-edc7-6763-1fd850ce580b@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07a42ecb-3a82-edc7-6763-1fd850ce580b@solarflare.com> Subject: Re: [dpdk-dev] [PATCH v2 14/15] ethdev: add physical port action to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 09 Apr 2018 15:00:48 -0000 On Sat, Apr 07, 2018 at 12:51:40PM +0300, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > > This patch adds the missing action counterpart to the PHY_PORT pattern > > item, that is, the ability to directly inject matching traffic into a > > physical port of the underlying device. > > Does it mean that if it is applied on ingress (incoming packet from network) > it will simply send packets back to network (specified physical port)? Precisely. > And if it is applied on egress (outgoing from device to network) it will > be directed to possibly different physical port and sent to network. Right, note it gives applications the ability to express that wish, the fact PMDs support it is another matter :) In any case, this action is added for API completeness but should be rarely necessary since we chose to go with port representors. Port representors will expose valid DPDK port IDs, therefore applications will simply have to create ingress/egress flow rules on the right DPDK port targeting different port IDs through the PORT_ID action. > > It breaks ABI compatibility for the following public functions: > > > > - rte_flow_copy() > > - rte_flow_create() > > - rte_flow_query() > > - rte_flow_validate() > > > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > > Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com> > > --- > > app/test-pmd/cmdline_flow.c | 35 ++++++++++++++++++++++++ > > app/test-pmd/config.c | 1 + > > doc/guides/prog_guide/rte_flow.rst | 20 ++++++++++++++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 ++++ > > lib/librte_ether/rte_flow.c | 1 + > > lib/librte_ether/rte_flow.h | 22 +++++++++++++++ > > 6 files changed, 84 insertions(+) > > <...> -- Adrien Mazarguil 6WIND