From: Fan Zhang <roy.fan.zhang@intel.com>
To: dev@dpdk.org
Cc: jianjay.zhou@huawei.com, roy.fan.zhang@intel.com,
maxime.coquelin@redhat.com, jianfeng.tan@intel.com,
pawelx.wodkowski@intel.com
Subject: [dpdk-dev] [PATCH] lib/librte_vhost: remove packet dump
Date: Mon, 9 Apr 2018 16:34:29 +0100 [thread overview]
Message-ID: <20180409153429.20123-2-roy.fan.zhang@intel.com> (raw)
In-Reply-To: <20180409153429.20123-1-roy.fan.zhang@intel.com>
This patch removes unnecessary packet dump for debugging.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
lib/librte_vhost/vhost_crypto.c | 36 ------------------------------------
1 file changed, 36 deletions(-)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index d84513e7f..d86af0532 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -578,21 +578,12 @@ write_back_data(struct rte_crypto_op *op, struct vhost_crypto_data_req *vc_req)
left -= to_write;
src_data += to_write;
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- printf("desc addr %llu len %u:", desc->addr, desc->len);
- rte_hexdump(stdout, "", dst, to_write);
-#endif
-
while ((desc->flags & VRING_DESC_F_NEXT) && left > 0) {
desc = &head[desc->next];
rte_prefetch0(&head[desc->next]);
to_write = RTE_MIN(desc->len, (uint32_t)left);
dst = GPA_TO_VVA(uint8_t *, mem, desc->addr);
rte_memcpy(dst, src_data, to_write);
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- printf("desc addr %llu len %u:", desc->addr, desc->len);
- rte_hexdump(stdout, "DST:", dst, to_write);
-#endif
left -= to_write;
src_data += to_write;
}
@@ -626,10 +617,6 @@ prepare_sym_cipher_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
goto error_exit;
}
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- rte_hexdump(stdout, "IV:", iv_data, cipher->para.iv_len);
-#endif
-
m_src->data_len = cipher->para.src_data_len;
switch (vcrypto->option) {
@@ -664,11 +651,6 @@ prepare_sym_cipher_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
goto error_exit;
}
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- rte_hexdump(stdout, "SRC:", rte_pktmbuf_mtod(m_src, void *),
- cipher->para.src_data_len);
-#endif
-
/* dst */
desc = find_write_desc(head, desc);
if (unlikely(!desc)) {
@@ -746,9 +728,6 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
goto error_exit;
}
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- rte_hexdump(stdout, "IV:", iv_data, chain->para.iv_len);
-#endif
m_src->data_len = chain->para.src_data_len;
m_dst->data_len = chain->para.dst_data_len;
@@ -782,11 +761,6 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
goto error_exit;
}
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- rte_hexdump(stdout, "SRC:", rte_pktmbuf_mtod(m_src, void *),
- chain->para.src_data_len);
-#endif
-
/* dst */
desc = find_write_desc(head, desc);
if (unlikely(!desc)) {
@@ -846,11 +820,6 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
goto error_exit;
}
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- rte_hexdump(stdout, "Digest:", op->sym->auth.digest.data,
- chain->para.hash_result_len);
-#endif
-
/* record inhdr */
vc_req->inhdr = get_data_ptr(head, mem, &desc, INHDR_LEN);
if (unlikely(vc_req->inhdr == NULL)) {
@@ -1016,11 +985,6 @@ vhost_crypto_finalize_one_request(struct rte_crypto_op *op,
}
}
-#ifdef RTE_LIBRTE_VHOST_DEBUG
- rte_hexdump(stdout, "DST:", rte_pktmbuf_mtod(op->sym->m_dst, uint8_t *),
- m_dst->data_len);
-#endif
-
vc_req->vq->used->ring[desc_idx].id = desc_idx;
vc_req->vq->used->ring[desc_idx].len = vc_req->len;
--
2.13.6
next prev parent reply other threads:[~2018-04-09 15:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 15:34 [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Fan Zhang
2018-04-09 15:34 ` Fan Zhang [this message]
2018-04-11 8:47 ` [dpdk-dev] [PATCH] lib/librte_vhost: remove packet dump Maxime Coquelin
2018-04-11 8:59 ` Maxime Coquelin
2018-04-11 14:36 ` Maxime Coquelin
2018-04-09 15:45 ` [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Maxime Coquelin
2018-04-09 15:53 ` Maxime Coquelin
2018-04-09 16:38 ` [dpdk-dev] [PATCH v2] vhost/crypto: " Fan Zhang
2018-04-09 17:57 ` [dpdk-dev] [PATCH] examples/vhost_crypto: fix parsing Fan Zhang
2018-04-10 9:40 ` Maxime Coquelin
2018-04-09 18:01 ` [dpdk-dev] [PATCH] vhost/crypto: fix makefile Fan Zhang
2018-04-10 9:41 ` Maxime Coquelin
2018-04-09 18:21 ` [dpdk-dev] [PATCH] vhost/crypto: fix session id printf Fan Zhang
2018-04-10 9:41 ` Maxime Coquelin
2018-04-11 9:22 ` [dpdk-dev] [PATCH] vhost/crypto: fix incorrect formatting Fan Zhang
2018-04-11 9:56 ` Maxime Coquelin
2018-04-10 7:32 ` [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Wodkowski, PawelX
2018-04-10 7:43 ` Maxime Coquelin
2018-04-10 7:47 ` Wodkowski, PawelX
2018-04-10 7:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409153429.20123-2-roy.fan.zhang@intel.com \
--to=roy.fan.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=maxime.coquelin@redhat.com \
--cc=pawelx.wodkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).