From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BF59C1B808 for ; Tue, 10 Apr 2018 14:39:33 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 05:39:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,432,1517904000"; d="scan'208";a="45705876" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga001.fm.intel.com with SMTP; 10 Apr 2018 05:39:30 -0700 Received: by (sSMTP sendmail emulation); Tue, 10 Apr 2018 13:39:28 +0100 Date: Tue, 10 Apr 2018 13:39:28 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: "Singh, Jasvinder" , dev@dpdk.org, "Dumitrescu, Cristian" Message-ID: <20180410123928.GA158356@bricha3-MOBL.ger.corp.intel.com> References: <20180409120632.38567-1-jasvinder.singh@intel.com> <50779258.T1JUn8BQf7@xps> <54CBAA185211B4429112C315DA58FF6D333361C4@IRSMSX101.ger.corp.intel.com> <4174344.PR9F3hB2no@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4174344.PR9F3hB2no@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 12:39:34 -0000 On Tue, Apr 10, 2018 at 02:19:38PM +0200, Thomas Monjalon wrote: > 10/04/2018 12:25, Singh, Jasvinder: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 10/04/2018 11:51, Jasvinder Singh: > > > > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > > > > skip it while building the sample apps on FreeBSD. > > > [...] > > > > --- a/examples/ip_pipeline/Makefile +++ > > > > b/examples/ip_pipeline/Makefile @@ -67,6 +67,13 @@ RTE_TARGET ?= > > > > x86_64-native-linuxapp-gcc > > > > > > > > include $(RTE_SDK)/mk/rte.vars.mk > > > > > > > > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") > > > > > > You can use CONFIG_RTE_EXEC_ENV_LINUXAPP > > > > > > > +$(info This application can only operate in a linuxapp > > > > environment, \ +please change the definition of the RTE_TARGET > > > > environment variable) +all: +clean: +else > > > > > > > > > Copy of my previous comment: " It is not skipping the example, just > > > throwing an error (which is needed). > > > > > > You should add a test in examples/Makefile to really skip it. " > > > > In V2, we follow the same pattern as followed in other examples such as > > l3fwd-power, ethtool, etc. > > A kind of counter example is: ifeq ($(CONFIG_RTE_ARCH_X86_64),y) DIRS-y > += performance-thread endif > > But I get your point that it is done this way in several examples. > > > If we put check in examples/Makefile, than how the situation is handled > > if someone tries to build ip_pipeline straight instead of building all > > examples. > > My thought is that if you try to build explicitly this example on > FreeBSD, you should get an error. > > > > In this v2, you replaced the error by an info message. Error was > > > better in my opinion. > > I will get this v2 and not bother you more about that. All examples > could be fixed at once. Not sure it is worth though, given this is the > legacy build system. > Well, we still need a make-based solution for the example apps, because if we using meson & ninja for the main DPDK build, we still need to provide a makefile for each sample app. That makefile should build each app standalone using the pkg-config info to find DPDK libs. It also needs to signal to the user when they are trying to compile the app on an unsupported platform. The alternative, I suppose, is not to have unsupported examples shipped for different platforms, but I think that is not as good a solution. /Bruce