From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 790181B8AB; Tue, 10 Apr 2018 16:16:53 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 07:16:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,432,1517904000"; d="scan'208";a="46681818" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga001.jf.intel.com with SMTP; 10 Apr 2018 07:16:49 -0700 Received: by (sSMTP sendmail emulation); Tue, 10 Apr 2018 15:16:48 +0100 Date: Tue, 10 Apr 2018 15:16:48 +0100 From: Bruce Richardson To: Jerin Jacob Cc: dev@dpdk.org, herbert.guan@arm.com, pbhagavatula@caviumnetworks.com, hemant.agrawal@nxp.com, stable@dpdk.org, jerin.jacob@caviumnetworks.com Message-ID: <20180410141648.GA164988@bricha3-MOBL.ger.corp.intel.com> References: <20180409143946.21607-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180409143946.21607-1-jerin.jacob@caviumnetworks.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction level support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 14:16:54 -0000 On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote: > The make based build system has crc+crypto instruction > support for the default arm64 build. > http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 > > This patch fixes the disparity with meson build flags for armv8. > As a bonus, This patch fixes the following errors with > ip_pipeline example application. > > Assembler messages: > Error: selected processor does not support `crc32cx w3,w3,x0' > > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for ARM") > > Cc: herbert.guan@arm.com > Cc: pbhagavatula@caviumnetworks.com > Cc: bruce.richardson@intel.com > Cc: hemant.agrawal@nxp.com > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- Hemant, Shreyansh, Herbert, any issues with this patch on your side? Can one of you please ack it. It allows use of "-Dexamples=all" when doing cross-builds for all the different arm targets in the config dir. Without it, ip_pipeline fails to build for many of the targets. /Bruce