From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 170CF1BABC for ; Tue, 10 Apr 2018 18:36:54 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id m13so13464394wrj.5 for ; Tue, 10 Apr 2018 09:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VEdwhSHpv9yAZY94FY7ax8i9VNLBmBihDo5EX3JjmCA=; b=RXI6bnVpFuy8gkx/0l78EAaxH21a6I11O2aZ6tq3KenwGr3IdZ2lkd9M7g9+aYMOVe 37LG5pmuIcvqNnPgU2glkyZbneoQiO/Ppefe82FAGLk+pavnFvavQKN6BG42BEbsvcYS KAi+qjE4Yy+zTmfJK7RVhmKTO+pobzTMwsHL0VG1DOqhclJFNM1lSlsCHobAPA+KPgHJ FsGh3nhoFP3+FR7crK4GelV1to0HhytYJmaIBeAvO5Llu5OZLg9A6+m9oxIMY1l1FHdq O0XDG7nfPPPiG4VsxqrUswyJ+JZDHMhFUlFlDydz0Q4YkGpnHiYIF7FK5OYfVQBdil+J 9EaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VEdwhSHpv9yAZY94FY7ax8i9VNLBmBihDo5EX3JjmCA=; b=W9pYMlbnfqNnCXH6zK9nlQiRpf6siFLpx0uIcM0PmKQgYiJEjS7xqtukdxlAWDWKoj 04RSHgvNNeKqtewmc5BEiox5BwL7W1MNEsOVQNsTOLOvjy/akqzZ2LAmrlQ+L0vELaRh 0vjSLiIYgdZegm1OSsDMdMuE118i8LBEAc0Qc+3DI97TD4jVmeR561uHRdcOYrdYp9cb +PcrS+mm+HAWT2WBFOsLMX/v/+9YtC/cNTlSVvKVRMbZGZXw7j1YZUFNMYYaXhISD3Fy 3DKZQz+etNCFK42JEI9QYJNMOIO34244d7SmHIVzOoJ4GU91Qu4AuDqnfaN3IqJimi9D jWEw== X-Gm-Message-State: ALQs6tCa0uc3GxwpHBiodNCG1cHfwTGNuuujCWj28rcov4YQs3RHrk1b ZaqMtu3porIAZXu94B4diBGplpYY X-Google-Smtp-Source: AIpwx48YsZKhztK1H0vT6stfH467aLis1uQearNk1VQ1C1GBZ8gubyKluZRc3qXjdFfcmdlhqCjw+w== X-Received: by 10.223.225.71 with SMTP id f7mr850319wri.172.1523378213841; Tue, 10 Apr 2018 09:36:53 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c18sm1488612wmd.13.2018.04.10.09.36.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Apr 2018 09:36:53 -0700 (PDT) Date: Tue, 10 Apr 2018 18:36:40 +0200 From: Adrien Mazarguil To: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org Message-ID: <20180410162022.9101-2-adrien.mazarguil@6wind.com> References: <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180410162022.9101-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410162022.9101-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v3 01/16] ethdev: add error types to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 16:36:54 -0000 These enable more precise reporting of objects responsible for errors. This breaks ABI compatibility for the following public functions: - rte_flow_create() - rte_flow_destroy() - rte_flow_error_set() - rte_flow_flush() - rte_flow_isolate() - rte_flow_query() - rte_flow_validate() Signed-off-by: Adrien Mazarguil Acked-by: Andrew Rybchenko --- app/test-pmd/config.c | 4 ++++ lib/librte_ether/rte_ethdev_version.map | 20 +++++++++++++------- lib/librte_ether/rte_flow.h | 4 ++++ 3 files changed, 21 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 2058e6ec8..7ae0295f6 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1228,8 +1228,12 @@ port_flow_complain(struct rte_flow_error *error) [RTE_FLOW_ERROR_TYPE_ATTR_EGRESS] = "egress field", [RTE_FLOW_ERROR_TYPE_ATTR] = "attributes structure", [RTE_FLOW_ERROR_TYPE_ITEM_NUM] = "pattern length", + [RTE_FLOW_ERROR_TYPE_ITEM_SPEC] = "item specification", + [RTE_FLOW_ERROR_TYPE_ITEM_LAST] = "item specification range", + [RTE_FLOW_ERROR_TYPE_ITEM_MASK] = "item specification mask", [RTE_FLOW_ERROR_TYPE_ITEM] = "specific pattern item", [RTE_FLOW_ERROR_TYPE_ACTION_NUM] = "number of actions", + [RTE_FLOW_ERROR_TYPE_ACTION_CONF] = "action configuration", [RTE_FLOW_ERROR_TYPE_ACTION] = "specific action", }; const char *errstr; diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map index 34df6c8b5..e915e7929 100644 --- a/lib/librte_ether/rte_ethdev_version.map +++ b/lib/librte_ether/rte_ethdev_version.map @@ -127,11 +127,6 @@ DPDK_17.02 { _rte_eth_dev_reset; rte_eth_dev_fw_version_get; - rte_flow_create; - rte_flow_destroy; - rte_flow_flush; - rte_flow_query; - rte_flow_validate; } DPDK_16.07; @@ -153,7 +148,6 @@ DPDK_17.08 { _rte_eth_dev_callback_process; rte_eth_dev_adjust_nb_rx_tx_desc; rte_flow_copy; - rte_flow_isolate; rte_tm_capabilities_get; rte_tm_hierarchy_commit; rte_tm_level_capabilities_get; @@ -192,7 +186,6 @@ DPDK_17.11 { rte_eth_dev_get_sec_ctx; rte_eth_dev_pool_ops_supported; rte_eth_dev_reset; - rte_flow_error_set; } DPDK_17.08; @@ -203,6 +196,19 @@ DPDK_18.02 { } DPDK_17.11; +DPDK_18.05 { + global: + + rte_flow_create; + rte_flow_destroy; + rte_flow_error_set; + rte_flow_flush; + rte_flow_isolate; + rte_flow_query; + rte_flow_validate; + +} DPDK_18.02; + EXPERIMENTAL { global: diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index cdaaa3a5b..95799fd9c 100644 --- a/lib/librte_ether/rte_flow.h +++ b/lib/librte_ether/rte_flow.h @@ -1186,8 +1186,12 @@ enum rte_flow_error_type { RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, /**< Egress field. */ RTE_FLOW_ERROR_TYPE_ATTR, /**< Attributes structure. */ RTE_FLOW_ERROR_TYPE_ITEM_NUM, /**< Pattern length. */ + RTE_FLOW_ERROR_TYPE_ITEM_SPEC, /**< Item specification. */ + RTE_FLOW_ERROR_TYPE_ITEM_LAST, /**< Item specification range. */ + RTE_FLOW_ERROR_TYPE_ITEM_MASK, /**< Item specification mask. */ RTE_FLOW_ERROR_TYPE_ITEM, /**< Specific pattern item. */ RTE_FLOW_ERROR_TYPE_ACTION_NUM, /**< Number of actions. */ + RTE_FLOW_ERROR_TYPE_ACTION_CONF, /**< Action configuration. */ RTE_FLOW_ERROR_TYPE_ACTION, /**< Specific action. */ }; -- 2.11.0