From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0080.outbound.protection.outlook.com [104.47.38.80]) by dpdk.org (Postfix) with ESMTP id B1E931B795; Wed, 11 Apr 2018 10:38:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hJfa2wQu5k9H6Vui3hMbbqzn/VhpEIFkDlk/vYrPm+U=; b=Lzt2u9I/MEuWxk+a3oBDcQcjB2qC9pbBsJR98CoJT/ZSngtutjwRr1ylZI0ez3L/CPxJCsUQQmSVQL5YhBNV6jr2k3ISB3aYygQNhDpcFTEJ8V5swZLCln8aPK/Wgke//6RRz3uWhrss3w+lqr2SOE5egL6KuZmvAkB5g0WnOlU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by DM5PR07MB3465.namprd07.prod.outlook.com (2603:10b6:4:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Wed, 11 Apr 2018 08:38:44 +0000 Date: Wed, 11 Apr 2018 14:08:20 +0530 From: Pavan Nikhilesh To: Thomas Monjalon , techboard@dpdk.org Cc: dev@dpdk.org Message-ID: <20180411083819.GA27100@ltp-pvn> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <20180406182516.GA13313@ltp-pvn> <8961764.He0omIczL0@xps> <3084545.g1xfDtWPys@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3084545.g1xfDtWPys@xps> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0079.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::19) To DM5PR07MB3465.namprd07.prod.outlook.com (2603:10b6:4:67::20) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:W07kQnL9Jjs7FAHR5z/kV0F+7pDKveyHefWQKMFiIwFAQgndrQJMbAWlzcuXKrtmDYjxNbixczdhnZHn1b6Ptx5QORSbRYAN9z+QaLSJXe9R2HjlAJ6vGxK+zALz1HFsGH/k9GBBash4RkVXxga4jOfaB+B1MHjWlRDg08KJk0wXYijHs+lTE5ntfWWBefh7GgOyANsSlNvMipR/eErwQ+p2HGNKyRULm0IGfnY/2Lq6wlayaFGdzoamZZ/SChjE; 25:TIGGYplFIbo+6713AyjISbDPfEPGUndGWBlwu9gavYz/ZGSrwVg0CcG7s+l4eD8tXNdVk6QBw1I8xokpJlGeh55gl970vMjewVKZc99CdUeWXMVNWJeSASrR77Ak+eTgAfPK1fLOergQKrMl5vXKQWbJHkZr8anYq/SGYO06AL7M3WPxj821k3HJMWkt+eAm/MRK7nQI4V6NKyVFRx6e9lFLZ0RyFMqmNA3KAwF/AhuwBZkk2lcGYpqeZbp0B02Ktclrx1UocLc4caai2DbkiqGVamI2XjJglUKgcP/4fPL6AeHm0Am/BW23u2iDlCkqaLxVfTCi8SVQXI9WphOJKg==; 31:40f90JttydKPxPNpidVo41haA5bamRHRYZb7PTmr3vD6nZAHr7i+ZmkD7IpPa3wiET+nPSCRPfsdidvnJ4/lQaiN/U7fSEXfX63glQq8pg7Hg/klGFS+k4uVTuB2l9R09KV6qAkqjoEoBMwZd96RSi6vpkFsAOYpgm5gVkCPs+443rLCWPqP+HXtQ6YL9oydyxvX8kgAiLqqCt9mnc+FmFuv8fbzMbdHjeJEzLRZR5o= X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 20:M7fNsLFlAPzlo7o0vzdo9XiRNVMvtJyx0v4CKhTKgkOAEkjfiRn2YOEIcyYRHL3BddjLknM7iVNozasmC4OUcHEXHfwU8Qz5ySjuT6+/pDvk08XHiM70s9Yi9ggV7dThU9+f27GbfCW7GznBXjNWDrO4uxjwnwJH2RyF5omP5FTN99rZNMudwtsocI3DfIZaMkCpDlxrXC8+duZXXGJVBDiHqohP4a7VtQ8eNOxM7R4lXtgIP+cvS1/ATAPTTdZbpP/EfD+WvDVTOeahKvbN6rQdYxxRqVx1wXCts7wLa6mVrb7CsF9gWybhraD2acNi3/HqaqXmEepHd8CchSxRKYaN0ygM48MoeFw7mDFjwZbz6MLnSYS+BzB8hi8RYldSmbutOYt29AH7HlE4HATXwLaZphGlqOxv62EsGoLSOf5wOUuT2SACpsPNBZYHxFtqeD2977gLzw9aD8Qs6Ees7BGQVok2avmFm6LvVVd5AVNVFzujm+aZ2pkXQ5hO2LA6DLUqgWuGcTX19mf0proxVGKcZ99A0T85oF05TGnWmseXAqYa30Qs7N0lbkJUPxWGfZ5TNvoQxjopv9Y/5FWNsjvu/Z/h/RWL6K1UzI9xPbo=; 4:YrgBiqEYHGTRSoS+GtnaPlcEDVivZocI1Cxr5braUDhY7df41icGWvcoL+tRb1duERMjpQzWrbJtmntmQdBpiHuoXVTOiF3E+WquaUDABMlYR3MBzOahFuOoKMonkKn+weHSedSxZxKoeeOp5dSl5QmhD0li7y8vm5xY2MjjSAziVXVM67c/CL42Q5ny6HBunQu8KbyxKQl5Vh86SEr5cnyyQ7M8qoKMI9/93eiYBWUnCkk72DeCjDSe2BuaypeQ/LRaMmyosXHlTbo57LrfuQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(93006095)(3002001)(10201501046)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3465; X-Forefront-PRVS: 0639027A9E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(376002)(366004)(396003)(346002)(39830400003)(189003)(199004)(5660300001)(6116002)(229853002)(6496006)(81156014)(76176011)(3846002)(53936002)(52116002)(25786009)(2906002)(8676002)(81166006)(105586002)(478600001)(23726003)(305945005)(446003)(26005)(486006)(47776003)(6666003)(93886005)(42882007)(50466002)(476003)(1076002)(59450400001)(6246003)(16526019)(33896004)(68736007)(16586007)(4326008)(5009440100003)(66066001)(58126008)(33716001)(7736002)(55016002)(106356001)(72206003)(33656002)(11346002)(386003)(186003)(97736004)(956004)(316002)(8936002)(9686003)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3465; 23:L4qU70Wv2lDGq3Gg0BkBeeFUpYnZYSJcUJVS0I+MY?= =?us-ascii?Q?a2eTCXr1+6DRHE05oj/Xh+poR46IESVKPxric3xpPCnI7d3gzCrnCgzG+EGm?= =?us-ascii?Q?hSv3DOY1jG05Svevm23hklE2KFsjMCyGdZjgEPfebSgYSf5o9r4WHwPbL4ly?= =?us-ascii?Q?SsnAD+p0GJUaydzhK4BJ3vbIs2tdvpfCa09P9/O4gzt54pmQRNZ4NoNhUkUq?= =?us-ascii?Q?uzG9fBdbrFBgVS3hIqv730tmUDrvV/iRDxIjcvK+j7I6+pBWkzXMqDRMyc8J?= =?us-ascii?Q?QiomrR7XK6S0T3LnS8AEhO+m5QL20deRYQk6Qv6hYWehQewALuWWY1Z4sy5H?= =?us-ascii?Q?oOBLF3msFvpTX2BOEPIXnRtn4heDvyWK7E8qK9yrIPeunGq+3ljc/KWkaHxX?= =?us-ascii?Q?PePLOnELgQ3oZs42RhyTMh0Vj3r6dL7y1VrxJtR2+692GwxgixIw8OTizHxp?= =?us-ascii?Q?oL9IQnBjDlyaFL/e5WLf+a6qhriio5Xc/RjHC/mOB7HUzjTantDHfsFFtrWb?= =?us-ascii?Q?PrbVymNCe++Sq2N8nKeMkahUmu86m8vw41XdQN5SDXI6p45W+rdBg0jQVf4m?= =?us-ascii?Q?bzMLlLyKxtVR4m1bZjL42AjDKzsGIf2eZbQXCVorNcyDSj/0ARXZpmvW9Azh?= =?us-ascii?Q?wki4WwcU/eSO06APES8P3qMposaksJPv8oQywar6Evvr8jKq2ci3e5cYIOhc?= =?us-ascii?Q?yEpF+yyH+6sCfdTvH/1GVKxgf5cvy1irAGqlmxKbe5Yc949GmIU9Fbf0ca7m?= =?us-ascii?Q?PDc8gJj/01uWPaO8efYnVTDLKHnc3FWOF2rAhMnFUBS27Slzg1++Lez0cfYW?= =?us-ascii?Q?6bMnpMgvlBXzTI/Ep8bbD3D2RZx1wnvU08P83YreinTooMariSnKxPQMfhuQ?= =?us-ascii?Q?1nu/OWni3PKGxSz7YdGLnT1Xbw0pJGYT9bAwE0oky4E22IB+xiYEA+0ajyQa?= =?us-ascii?Q?03PANLpigy1DDzswoWpdtsUgqtcYFeRFIRvkks7WbaWeETiNzva+PA5vRQ3w?= =?us-ascii?Q?x3I618z51qNBvporciNdeEp71oG2WoP0jV6KOb1LYHuvLbHotEp967JfseFz?= =?us-ascii?Q?qhElF30NmGql9yF5O3OAzp+2Wo8eO5KXU+Kgaz2Rsyzl0ynjyRQlX+Op6oeI?= =?us-ascii?Q?B+o/YclhUltHykq4JC2woxESi0L2tDLfgFXVHtunZLo9zUP7Fz3PADy+qCpM?= =?us-ascii?Q?ed3sFhmckVlX9YcZh/w0mVlVZ1qJ5kKTTm3O2LhuBnm4H2jmjHEv1wIHtOlo?= =?us-ascii?Q?r+dFWf6SMXYyIa+Z3XvvdgYqd1pCfGnxsNPyABGCg9Q7mYPhdgbDRQE2jFYy?= =?us-ascii?Q?N/l0jnRK6sW94HinLP2PW+9EBMJZrt20it5QNjQsDBgdUr2Sx95VWU588rvp?= =?us-ascii?Q?Jnd148TSevCTKpfh7XkS/o2Ul+9J3F8klHL+qHxIZxEE0ZT?= X-Microsoft-Antispam-Message-Info: ZFREZ7H/8+VYSGczFWfUYKYD+wxn0rxpg2T/nV3W2RnsJNuz1/jFv3L6q7u337q3H0c9e+P+EQuuXa7IyMLbe3xV4laMntrWEwjTntckwtfKj70Fm0sHI36OL72rF0Rdg1H+kRAZO07URH6+h3DUsg5DJfPIEAmQtzcz8fkpCiW7+3pDtkCHDGcUOMl09xnP X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:lbbqwTHJz+qzbWAZn68bsf2K3oLOlNywUSfra0VoxDJ2wO+8/TwzF1kin2psl7sTXusjh8IMsZw2K4jEJZbmW9SEx2AxhmqIse9JWLY23PDPjEypV8E4iy/i7V13DxPunogbRi9ns323HnhkfCjyCy2tBCBKgysFRDPuTe+zuCHqeMFVCDYLssElBmu+TI1aHKCVVEJ//YJtwioeeDvhN1/0QYJXF66B/IGQ1qG+5ptgufherme0Aa0awrKRn36v3eZEJ27IgDdVCSmM122N2cZ52YaCnF5jn9BHpEGa6iAaV/hxM6/Z5M1NsrokPKF0xNEv5lSJSXpafg6Y5zqArOdtAEFQW6dxWehgLLr72Rf3RTQZx1nVkROoTcu/seYvv2I5NgC71HJZYa3zbrfyiURlJpm+clnT//pXI1JSjW9cwr13IN78QQ5JPqFpf5oyScDF12dvKLjuRVSnD72OuA==; 5:uXFeOkQTIAJisfyoNny0xB1x5qL9JltdkNqGVBtPMQ7zv5S1zsh3r+zq4TVkhyovRdWkbdZp3HaG6w6EsWIZNp2iI24S8bj+xwBxf4veJBkeXuReHvyAjUYDISt7utYw0kpSf3HtW9b9C1jQg1XyU04MBJ2bjPGQN3ZgcDP2rr0=; 24:Pv5QLxl37u3QyDCl58fZaZqzkZmC8SFzBKyAjxVmmY3jxvc22HRncc4HjwJ7i86WQp04jAPuHauhuqtDmiqk1RltBLkT4iXz1z1q8AkxPvc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 7:qGIoVBAl8V+naEzz7Do8ZkJ9gYOlED3FHC/K5v0rLiUO0Bl0dZ941sxyqwWK/GvFGZ0caAPyZSu5JwKqRjcK2MG5YmVYiMJUROoXtOynQZACjDz65VYUMVaDvLpwHu5qUZRladVRRBx3ItIv0aYqbQcdNHOFXcQSPyPTOwu1qb1nHdGnUfFTpUWYtbN3t1RYSbmYykUFFlqah968UVHQBpjLuwyemgmPevZ9UVzl9OYXvSXRdXyPhod/7Xf7D6lO X-MS-Office365-Filtering-Correlation-Id: 791aa0e2-cd93-4cee-0f45-08d59f87a3ef X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2018 08:38:44.8641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 791aa0e2-cd93-4cee-0f45-08d59f87a3ef X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 Subject: Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 08:38:48 -0000 On Tue, Apr 10, 2018 at 11:35:15PM +0200, Thomas Monjalon wrote: > Hi, big issue here. > This patch does not compile on Linux with ICC or GCC < 4.9 > because of a missing C11 header: > #include > > GCC 4.9 is recommended in doc/guides/linux_gsg/sys_reqs.rst. > But GCC 4.8 is used by SLES 12, RHEL 7, etc... > > Note: Intel compilation tests are running with a backlog of one week, > so cannot catch such fail. > > Exceptionnaly, I have decided to remove this patch pushed few hours ago > (not reverting), in order to avoid a serious "git bisect" breakage > in the middle of the git history. > > We'll need to find a better way of fixing the compilation error > seen on ARM with clang. > To make it clear: I believe it is more important to preserve GCC 4.8 > than clang compilation. > By the way, what is the version of clang which was causing the error? I have tried with clang 4/5/6 and all have the same issue. > > The error was: > include/generic/rte_atomic.h:215:9: error: > implicit declaration of function '__atomic_exchange_2' > is invalid in C99 > include/generic/rte_atomic.h:494:9: error: > implicit declaration of function '__atomic_exchange_4' > is invalid in C99 > include/generic/rte_atomic.h:772:9: error: > implicit declaration of function '__atomic_exchange_8' > is invalid in C99 > > The proposed solution was: > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8), > and include stdatomic.h. > > > > 10/04/2018 17:07, Thomas Monjalon: > > 06/04/2018 20:25, Pavan Nikhilesh: > > > On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > > > > 06/04/2018 13:01, Pavan Nikhilesh: > > > > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > > > > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > [...] > > Applied (with error log), thanks > > >