From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id D3B0F1B6F7 for ; Wed, 11 Apr 2018 11:08:30 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E8F2406E897; Wed, 11 Apr 2018 09:08:30 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24E6B2026609; Wed, 11 Apr 2018 09:08:29 +0000 (UTC) Date: Wed, 11 Apr 2018 11:08:28 +0200 From: Jens Freimann To: Junjie Chen Cc: jianfeng.tan@intel.com, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, dev@dpdk.org Message-ID: <20180411090828.eryglz3jjj6xzexa@dhcp-192-241.str.redhat.com> References: <1523369889-73457-1-git-send-email-junjie.j.chen@intel.com> <1523443993-176139-1-git-send-email-junjie.j.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1523443993-176139-1-git-send-email-junjie.j.chen@intel.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 11 Apr 2018 09:08:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 11 Apr 2018 09:08:30 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 09:08:31 -0000 On Wed, Apr 11, 2018 at 06:53:13AM -0400, Junjie Chen wrote: >dev_start sets *dev_attached* after setup queues, this sets device to >invalid state since no frontend is attached. Also destroy_device set >*started* to zero which makes *allow_queuing* always zero until dev_start >get called again. Actually, we should not determine queues existence by >*dev_attached* but by queues pointers or other separated variable(s). > >Fixes: 30a701a53737 ("net/vhost: fix crash when creating vdev >dynamically") > >Signed-off-by: Junjie Chen >--- >Changes in v2: >- use started to determine vhost queues readiness >- revert setting started to zero in destroy_device This one works for me. Thanks! Tested-by: Jens Freimann regards, Jens