From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 687091B73F for ; Wed, 11 Apr 2018 23:48:27 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id y69so1790160pfb.5 for ; Wed, 11 Apr 2018 14:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Cwqn4ecECAJ5IJfvrtZJvQRsNYIU19MROSYUWUNhLQs=; b=dzYBuqOC41u8mgq0n5si8ouWoDtU902eBK3nPoWbdjjgTyB1aNkjyHATP6Y8Y6C0uA 2lfsF+43nT16lT+7VcMiofdtTIYlTieANSEF2RyVGePQVMlvyDM6KCwnV7mpx6nKE0P3 KR3zg0XB4YXfJMnSFYcvr09RIuiAw/bBOFMM0jBLQtT0Ycsqsv8NuAvGB/jMV6Z+bqtd VHnUqBgswWtPARJGZU/xMGso32vtltfJ4/gy9qiDNOgh6ExcxcxGhuh0/qq8g8C7nCrT aNQxB1CGA2t2EepkiqJ49bdDAYHwQWHPGX6vUuVQy78e1I7OVMqyrISQfdvonPPVE9lS yj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Cwqn4ecECAJ5IJfvrtZJvQRsNYIU19MROSYUWUNhLQs=; b=eurapkDUNIZl8w2lDuTTmzlqzgEJB9S5xyysjACqz7VYQgiGLD6dsOiO/qtNQr7vD5 cJvouzYgwo70nnupwIhhKidxW1NDVD0I8pBftzcAf6IpAYuPRqCzYAsT540Z23lRvU+G J/TiEkrBv9muhZVqy+rOlz+7E0TXu7pNPb5izNgGkg8CVvu0BMQ/3P36NLXm9dW38afb mudk4piuuCHcH2zXMpKz8YPUa+ttgQEg8R24jchhdgn1580l3znNFDgx43XT4N8Saz78 EK1jgdN+qXGP0mMCDpFIsd2oaMPMIn6XtuLrxYPTfnLmWkBmGjSZ3pboA6qCuN+8ixaP aKnQ== X-Gm-Message-State: ALQs6tCIZphoEzswF0qYXk5DiCzHaz3Tto9lMIYlVE1ATcuSYqx3O+rS GFpR10ESLnHKYeEmG2ci3mfXvuPHr/o= X-Google-Smtp-Source: AIpwx48eYXKwmY4CxSrBQWuYym8M5YtLIcGb2C17Rw5GzR7LkD5kiAFwGt64IYdBX3ES5G9IAyT8TA== X-Received: by 10.98.32.80 with SMTP id g77mr5446238pfg.216.1523483306584; Wed, 11 Apr 2018 14:48:26 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id r70sm4880735pfe.22.2018.04.11.14.48.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Apr 2018 14:48:26 -0700 (PDT) Date: Wed, 11 Apr 2018 14:48:24 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Pavan Nikhilesh , dev@dpdk.org, jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com Message-ID: <20180411144824.062e1432@xeon-e3> In-Reply-To: <2796123.plAjDWPncV@xps> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <20180411170150.11985-1-pbhagavatula@caviumnetworks.com> <2796123.plAjDWPncV@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: fix clang compilation error on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 21:48:27 -0000 On Wed, 11 Apr 2018 22:42:55 +0200 Thomas Monjalon wrote: > 11/04/2018 19:01, Pavan Nikhilesh: > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > The error was: > > include/generic/rte_atomic.h:215:9: error: > > implicit declaration of function '__atomic_exchange_2' > > is invalid in C99 > > include/generic/rte_atomic.h:494:9: error: > > implicit declaration of function '__atomic_exchange_4' > > is invalid in C99 > > include/generic/rte_atomic.h:772:9: error: > > implicit declaration of function '__atomic_exchange_8' > > is invalid in C99 > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > > > Signed-off-by: Pavan Nikhilesh > > We did not understand why this error is seen only on ARM > (hopefully we won't discover it somewhere else), > but it is a pragmatic fix. > > Applied, thanks Maybe Gcc always defines its own builtin functions.