From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0043.outbound.protection.outlook.com [104.47.34.43]) by dpdk.org (Postfix) with ESMTP id 7D58E1B701 for ; Thu, 12 Apr 2018 07:42:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0+fvIOz9RfdrHmD5QcLANHhT7yYONp/7nyTZlCF1rDI=; b=n93hmfiFSeINjpZ70klO/RvGdNQPF52iJXOyf/eqPhT6Fs/LKo9KvwbZ2iCOna3x9KgW6yMeU5/VXzGxvaB+4uPlFfVX/hoRjhMDB5q99eFlH6ISx8Zqz7lhbUz2CrMY/iTQGQQ/lGWtr0FcG0vAr55MWuD2tFsI1o1CFZx3T6c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (116.68.105.212) by BN3PR07MB2515.namprd07.prod.outlook.com (2a01:111:e400:7bbf::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.675.10; Thu, 12 Apr 2018 05:41:55 +0000 Date: Thu, 12 Apr 2018 11:11:40 +0530 From: Jerin Jacob To: Thomas Monjalon Cc: dev@dpdk.org, Ajit Khaparde , Shijith Thotton , Santosh Shukla , Rahul Lakkireddy , John Daley , Wenzhuo Lu , Konstantin Ananyev , Beilei Xing , Qi Zhang , Jingjing Wu , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Shahaf Shuler , Tomasz Duszynski , Jianbo Liu , Alejandro Lucero , Hemant Agrawal , Shreyansh Jain , Harish Patil , Rasesh Mody , Andrew Rybchenko , Shrikrishna Khare , Maxime Coquelin , Allain Legacy , Bruce Richardson , Gaetan Rivet , Olivier Matz Message-ID: <20180412054138.GA11392@jerin> References: <2759953.P7QpFFSjiU@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2759953.P7QpFFSjiU@xps> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [116.68.105.212] X-ClientProxiedBy: PN1PR0101CA0036.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::22) To BN3PR07MB2515.namprd07.prod.outlook.com (2a01:111:e400:7bbf::12) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN3PR07MB2515; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 3:k4jHre0s9Do2xj6dO4m1XQkJOFPjByuZPdnFC+njQkpbm0M4mIM2k8L2PiQYoe7idgTSjm1csa1s/c3TiMne29JI+0ToYkqaI0FR13ReunLB1U8RCXNDt0nd0hSLFyeB8RJ+rf4YD/tu7yKK1a3yy60yb2FkXqukaN47XScDaoD2HJ6SBDbpbUSDJVzE0NvbcwuEjHokXfGqf86m93hak7RfQ8YJPkm8H3CwsNj1S+1UCJfSCtTi1hJJoCLVYYBR; 25:kFYizWyuugjnPk8lnjECFur+6rsepyQqRTc4wfU40Ridn1Y6nkzPE7I/ZxdqTA+mi05YarCKp/TPU936H7X6procBuEApwY6aa9/W9NAYyG4cB68U+3M7dO8EyqD0Uf8FRFQ6fR21Bt6bdlbIZuCRF8B+Lxy7gsJK3f1cCzfbkTzGi9uesSJnEvHiMV5CqRNCKS0yBVuUCIzRR5TNw21aHjGutKGoAPPTJX39KFIc8f9zvXOfg0oDaZDShZUfx00v4u2H/QOSSenbrC/11OUq08ri0k4oM0SKseStKAYHl2UfS/J/TIbKU4OgoEhNWAHchPD7v+dOfz5vuo6+UXo6Q==; 31:JZkesRpLm2CcOZYGb0MmFJ9vvEk3GKgcEN78YCltsPz8ABIl5mhzQzGWxqzdPBtfC4LrdqneZx8WL/wj17TvZ6IfV7LrZl2jJAyvUZfDLXdg+pZbdyzNOU0Sk6goTnGtVk8iVs+ae+PHdjk7Tnb5TzFvN4BoNy6tXleIhKZCPoH4izr5p5XzTspVNthsrpnyIp32MdmpZTdG7j26mCmCm6fDzLS+X5hGMd6J01kv1ww= X-MS-TrafficTypeDiagnostic: BN3PR07MB2515: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 20:QELltaFRW5zGI6FBme+gtwzSKa9JrZF0Aq20tL4chk6qB60yTVhfa3TeQXSWM6mPJnWEF760xUsNP2+jfVWub3Dx6V+LRR/iuih2cK1kEayXBxk0Hxw+OgrgiYFrkK015P33uahUQFt4r7QyyPX6u+TCRI9IqES3KotUPERKixR67Xg9252SyRVGMaH5oWx2mDps674ByaHkDXoS09IomT14oSvHdi/sX2mNgF1NCr38X2sDyU2T6rJHCz57n9yPfYjXnJHcz7SStutvfTbpL/zbVeQY5GaOPsRT9SvAHbrmR26/DtuIQG85jQoJLa/vZVrkVOukmnIpcIum47m2vcJn/aKizH0A2rLtVoTWkbfJZrd0+oZgPXRqhq7/unno/XGhI4j3HCbdw0zBxK0KJ7mhDyUrh2xjtuAs45yDrCBwEvgIhPQxLWC8eDY+dmIWZMlgLhY/iOmTJet2znalq9pJpbDzFeUyhu/t35qiktV0Oc5rT20ZCBsYzQQGx76G7Qvkse9gdxF+pZDkP35U4YxoEUEADKtgTF5gl31qnZmucjXxOzMYr4+jJx4i/zmKM97sbnV4iyBP4PTDBT6noX/qWoQkqySpHaep+8C1QTM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(180628864354917)(278428928389397)(185117386973197)(95692535739014)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3231221)(944501327)(52105095)(3002001)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:BN3PR07MB2515; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2515; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 4:Qj6Q9y77bgxKLUOMB4PRuvaLtFMo7qWma2EgUsSo3HWEh1yRT7tb7ivfvc3NaF03Yveyly3PfLE1r2xfQ9oYHXjEGQe+v1lwTCBCUSI/xvN6FBiEGrf9iQZhSCOKsh0XiKoC2/t0c3oZyn5oceL3ObFQAGELsRJesJvMxHMnOOmG/wRsWVh7drxQE2ya9hvyssQude/fPenwP8bgtHN7IRLJTanuACYNBopH+QvV+3diCDqw3T8otgPhktreJUT/VH+pCHFgGSIlT2ltGy3Y3Rogx/t4TR932l3/DBRwLEoMDgdZkwyC1LwhGwMp6wjGoSkJUCtY1zg2BanaqYATOHQMdz83PNSClj1O90mCxOEgCApcNtLzjq9MapDeG0HmXG2JfVXa/QrW5GrLUyhITFgQfAOl1BQOvrEYZ1FANokHJJ6HZKxf5ISod4EwT41HUzgw7j8ONpU4OVjOI/GdhWnR8idWh+DqzYx3UJa6MOA= X-Forefront-PRVS: 06400060E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(39850400004)(39380400002)(346002)(396003)(13464003)(199004)(189003)(8936002)(26005)(6496006)(52116002)(25786009)(59450400001)(16526019)(186003)(76176011)(42882007)(6306002)(9686003)(53936002)(53376002)(6246003)(39060400002)(386003)(4326008)(7736002)(55016002)(305945005)(50466002)(6116002)(8676002)(1076002)(55236004)(478600001)(3846002)(97736004)(81156014)(33896004)(476003)(956004)(8656006)(11346002)(446003)(486006)(81166006)(23726003)(316002)(33656002)(54906003)(58126008)(47776003)(66066001)(2906002)(561944003)(68736007)(106356001)(7416002)(33716001)(5660300001)(6666003)(229853002)(16586007)(72206003)(966005)(6916009)(105586002)(44832011)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2515; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2515; 23:bCkOuI34af0wGQc/uCtnI1iP7dstidpnbFkN6K4bo?= =?us-ascii?Q?1OaXrXBxQ3snwNB7ivQ2jSm+hYytoxe4DrUUGueVkrIyzmtp4Bk/T3p2+8gT?= =?us-ascii?Q?vQ6A30UIbRnfFJoROY8X2rOWCSJi039/grlbOodjym3TArkDWkjPo41PLWdJ?= =?us-ascii?Q?R6bxCiepbperPjHEJPv1lMqUO+6K01Ga+V0cxAAnDxyUto8q2mT/ZgeSsuef?= =?us-ascii?Q?DhutrA+D9Bq9p6tiqsj47NTIKpNYbpH+SrX+ZS9uQt8X0gu3nomPDFdvtPFY?= =?us-ascii?Q?4RDLLDKgHULOPTj5Jx2qxHSFXxo2Yh00boYDLivjlkS/e7E3+HNxROHDRzre?= =?us-ascii?Q?nIZxUyK6qkpTM4VKRXiuTMNfgCnu4LaIv41VL8gbFV0eOUCPZEIYVCOh+5Ge?= =?us-ascii?Q?bfBbUxuuctDTawc4wD3AVutWPPXOL4uyikBaZ0nM+kguTsBoqNQMbJEbeUl6?= =?us-ascii?Q?YrfKWIDXzYABIWBho74RbNdnsyNuA0krJ3KJRmaFRz89sP260/OWTLz/ocRB?= =?us-ascii?Q?DcoRwirNPjZczAqGhQrVdwfczfAAbjTRnZldyVd8YhzcImnr1w2w24c8rDAz?= =?us-ascii?Q?9I3f5T/RNZkiZc62zUf3xFJg7lQOB64roSnta5JmbB3f2mjZDe8GEd8K2Y/r?= =?us-ascii?Q?22EbGxHDx3EwN5VE0dlx/qwVf8GXlpMSK7COtXTZXPUA1ulzmLImD24mTNh6?= =?us-ascii?Q?UBPPWBtICBwQ5qHMACpCeREbI0vZHWteZkZ8Mjkb3G1+uqGHav0MW5EmS4hV?= =?us-ascii?Q?Y+lAM2Tt+m4JpKz9DYET0maUOfwGc/nLRAMxXJzH0BsqYNEz0B/AcpA0NJUJ?= =?us-ascii?Q?yX/eUV9uueZshDieZjx6vki+9anRcXUHPMK+zl4rWCLRASstPKUJ46G/J5qm?= =?us-ascii?Q?B5h05c8ssJT0SrrVzHHtjRNst8isbG9Yxd2WLTzTdV0kQWDjuz0Fnu0avSmE?= =?us-ascii?Q?C/twJkNKETY6+sxHGYT5MQO/vjCijfkTorU6qccRtZ01uKgupnOEzyIbwj8d?= =?us-ascii?Q?VfYiwtz3agmQgHmv4YNbl7ztVT5R5lQd1BDR1ZqLwJGPj+XMeQZ7EfKo+cWy?= =?us-ascii?Q?Qb4WzOl21ZKc1w3qPuy4vhWiwP8R6B+lDY9G5AzuYCGsl6xDthVuPa7Qd9C8?= =?us-ascii?Q?f51dMsHvjv4eyyUs2bazRVujdbvf88XnO3rDWGXf5IRRhTlUa3ffK5qww2dz?= =?us-ascii?Q?15O0+lZ4555bfGWz+CzY2zUwswiyDMQ5HGVAW6JPmM3H/k3e0pUny6O5MG1D?= =?us-ascii?Q?ZP9eDb+6vjjyd0uWDo9x19DElkQvLsGEVitSWddrSjlCUTeVotvTiHrvPaMv?= =?us-ascii?Q?EMt0gpqBoNp6U42fh2toey+l59U4KXCjmaTR4FNxVYMOq3H6ywACRBuSGLFS?= =?us-ascii?Q?crFb8p+DzT3q7syuyGWMjtOfu/+SUOIpXGV6jbI+v/No4Se7di8xznM+FOZE?= =?us-ascii?Q?DQVTkt7tvlSWarVkgk573gKRkb9vD8YT99iMKBwqfDsSdDXsbIDPp1tr4FtM?= =?us-ascii?Q?q8IUqvbozmniHwAPxYUEeBoLcR8zjEMTmtgZdBiNW0+6o7zvwhLRrfRJ0pr6?= =?us-ascii?Q?VFoufEZLeyRWCSnyg=3D=3D?= X-Microsoft-Antispam-Message-Info: ki1qajcqA+asMFQ5SJta6UaqN8laFlLZGHDReoQVEO6yZ105VsAde/ZMqi29qMxSiS8t1BhhzrrtAIXPcHM+32fIh2ZxfC9m4iDVTAOPsnPeZXrdinnkUmNwA0csrNN6QWiAIJNaFb28y4QN/c8mJZp5kOqRjBCAU2R4SCqHT3mC0R122iPmdbJ2exEfwemA X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 6:7Be2zdZ8mQ/DWxA2dTU0ZY1qEvfhqO5cwn6gXV6JDUS9r7WsTDje0JnvHfDcb8hpWyDXIvV2QAz+LbEToN1MJBp6I8Z0Qyv8TjtZ01qcwoPw92G90Rv18VQpAwHddK1hRi6f3M3C9iSfsZEPMhcRPmu4ZZDz+ITyVEKkUWGu2AQpS4heaIgcAHGNf/pfe9Qzov3s9hdb3u4Wh+OjxDC6+c7ayn0mHKn5GaKL+lPntWZXYE3zbJ7dELZNbYsL5zo1NtTIp+Yk9KrRTFlygRh4VpaPeaZHtxSpPj2ZoGINLNh+3gOdcXWWfQji7ei0KE4OaGGiULCG5xC9H94V/MeVYCRzuD65yr//SRYHrUze0nR3h41hRbidei8AgnJqkHp0Iv33p5//htC1TS5PK81QZN4ly9uFkmlTL77PMlNQgDurlA/qoQZGsFZjIFfRnCzmieLmXBq5NJzpAZNFO+oh7A==; 5:VtekKmLsIuyVHxmwfZUgDBYJ9hZeVr4Nj+Bg5gV1jkCn4wJR60hPW2ua3N6cfudZzUK5Mu+FaGzk+2QVYfOUWoaE9t9Bu2fpBH46A0PCpGuEGgUCsDx5wc7LiP2u2Gl0Ji2MPB1yF70PAjjqziJZx0htSC585KTNl/15OswcvXA=; 24:otmb8PXbonX6bD2I0Wx6hEDSNxqxbLUNGZDCiF90sexusrrqml5pxeXiYHCaj3Utx9RdkiOyN5blrByndMllAj/o4eOgkVjm6xvy9kHstXg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 7:1O0fp0YPDefQxrwzhaOySh0zIoVyWgOgJUTghoXFdCsucvBdki4zMj+elB2Xrgwm1/2vskGY5PO/mDQvzHOCTs4ulTD5BG1zT5ZdRuXxhQcWP8tTSgRtaoCjQCBttjOGw/7DUM8kzpVi3wLCAhAzc4yv/NdrkP1q2avswH/i8piJICD7GeK3wQJPjDejYsBLjrt3iSa5wrOIqlV+uSbVHECwp5nn2KHpoVPEaa2AxyatgHzmcmRx3Jmv+C5qWUGs X-MS-Office365-Filtering-Correlation-Id: c5b7991d-c3a5-4311-e00a-08d5a0381f1a X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2018 05:41:55.7480 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5b7991d-c3a5-4311-e00a-08d5a0381f1a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2515 Subject: Re: [dpdk-dev] Survey for final decision about per-port offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 05:42:07 -0000 -----Original Message----- > Date: Fri, 30 Mar 2018 15:47:55 +0200 > From: Thomas Monjalon > To: dev@dpdk.org > Cc: Ajit Khaparde , Jerin Jacob > , Shijith Thotton > , Santosh Shukla > , Rahul Lakkireddy > , John Daley , Wenzhuo > Lu , Konstantin Ananyev > , Beilei Xing , Qi > Zhang , Jingjing Wu , Adrien > Mazarguil , Nelio Laranjeiro > , Yongseok Koh , Shahaf > Shuler , Tomasz Duszynski , Jianbo > Liu , Alejandro Lucero > , Hemant Agrawal , > Shreyansh Jain , Harish Patil > , Rasesh Mody , Andrew > Rybchenko , Shrikrishna Khare > , Maxime Coquelin , Allain > Legacy , Bruce Richardson > , Gaetan Rivet , > Olivier Matz > Subject: Survey for final decision about per-port offload API > > There are some discussions about a specific part of the offload API: > "To enable per-port offload, the offload should be set on both > device configuration and queue setup." > > It means the application must repeat the port offload flags > in rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]xconf.offloads, > when calling respectively rte_eth_dev_configure() and > rte_eth_[rt]x_queue_setup for each queue. > > The PMD must check if there is mismatch, i.e. a port offload not > repeated in queue setup. > There is a proposal to do this check at ethdev level: > http://dpdk.org/ml/archives/dev/2018-March/094023.html > > It was also proposed to relax the API and allow "forgetting" port > offloads in queue offloads: > http://dpdk.org/ml/archives/dev/2018-March/092978.html > > It would mean the offloads applied to a queue result of OR operation: > rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads > > 1/ Do you agree with above API change? Yes. > > > If we agree with this change, we need to update the documentation > and remove the checks in PMDs. > Note: no matter what is decided here, 18.05-rc1 should have all PMDs > switched to the API which was defined in 17.11. > Given that API is new and not yet adopted by the applications, > the sonner it is fixed, the better. > > 2/ Should we do this change in 18.05-rc2? Yes. > > > At the same time, we want to make clear that an offload enabled at > port level, cannot be disabled at queue level. > > 3/ Do you agree with above statement (to be added in the doc)? Yes. > > > There is the same kind of confusion in the offload capabilities: > rte_eth_dev_info.[rt]x_offload_capa > rte_eth_dev_info.[rt]x_queue_offload_capa > The queue capabilities must be a subset of port capabilities, > i.e. every queue capabilities must be reported as port capabilities. > But the port capabilities should be reported at queue level > only if it can be applied to a specific queue. > > 4/ Do you agree with above statement (to be added in the doc)? Yes > > > Please give your opinion on questions 1, 2, 3 and 4. > Answering by yes/no may be sufficient in most cases :) > Thank you > >