From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0089.outbound.protection.outlook.com [104.47.0.89]) by dpdk.org (Postfix) with ESMTP id 33C691C072 for ; Thu, 12 Apr 2018 15:34:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OxbYQPdVoh6mgsPNMUOU0G3NZySvo7kt37npMG1dE5E=; b=senIhgnP+NMj2aC5ld11B1dKnVetG3XyBsL9WRE86NsI+3cdIz2pLv64VWz+ZKniXjQpvrmKdUt1YWGc8rr6d4COoekhhq1B9lRPZP+VV3l1pRIEhu78LfBGww1teRaa8s/5f2N0teMZhrbP0/2IhjIHnpGjvB057ylMjRqAAHw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB7PR05MB4425.eurprd05.prod.outlook.com (2603:10a6:5:1b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Thu, 12 Apr 2018 13:34:30 +0000 From: Shahaf Shuler To: thomas@monjalon.net Cc: dev@dpdk.org, anatoly.burakov@intel.com Date: Thu, 12 Apr 2018 16:34:22 +0300 Message-Id: <20180412133422.104155-1-shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: AM5P190CA0018.EURP190.PROD.OUTLOOK.COM (2603:10a6:206:14::31) To DB7PR05MB4425.eurprd05.prod.outlook.com (2603:10a6:5:1b::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4425; X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4425; 3:gOthPmkjVrEBtNYWEgw8j559VU8/Kxz6uZkLWSNmWWAShMku2gpilW8RtPtH/Cvm7r/4WOVphrQrygmTYN1E7TjMc4kGnl5/SYj0nEHp26f9iikvq4Tg6L1qDgWdr+eP3QGsdfbeVO+wg7jOYzLXOz/bUnmHWqc+NqNKCOHBEkf98Wm487O9oMWA2aq6cBBY4RC3TUWc+af0vpXH0QPpVY26ENhh13oYNmEBoHs/cVKyBcrrxvXAImEWQxv7OrQ4; 25:DHbHF3OQK1P4iziOobLmxHLlDuwwGZorJbaQkoFVOkT3IWs+sl/rFk8tgU9JnOW1BuWQDAZBCC4fVx6FB48ifjpD5pfn/Tnmo6ED24OCYqHNrfistZrcYVj5rcl8LpiQ5okYIWlY22tnVJVEBi7mw3k3w2eQquXweZKogiM3FgV9yJ6cZF5Wmn0miXWn7AdRDaFBqsCOucWo0h4MU5swDjHw/B93x7Lf3fzFJ8efoqxKck0NwFv7Vwx4j8en7HGLRZlzIcliQG3UQkZgUL9gvdiJF6BqcrHolWBLIfBcrYQbPi2mwCNv7X8Jq2I+u17Zc2RNNPGXlv7/3wvoDOpr4g==; 31:2Gqrate3h3yKTvXwT7dLOMJVJMR8p0UVvUdgvZiBKwnE4A1SNeAJXymUTMOrL75eO9nOf9ORxMr5wa0la4O9cVdhO+1gccUuIi0DLEFoYyCXBdDzpVfBujN2wl33WzCBDxcrFnsV/tuYTxuxi1W/0SbIRJhIKGMKzZgR+oKSW0mivEV/4XEwzo712Yi+VXFF2i71mobu4bch6YY21TzsoqmEmdiDmYKUkAmDkqWpnVE= X-MS-TrafficTypeDiagnostic: DB7PR05MB4425: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4425; 20:CNPL0H1iVZYnE4s4nkbe3OcZK1bAEvoons1cqzD8FFw3ADEdE+p4VwlBcQSJcYrhKnZr7QOiOx8KopAVRC04JRnKPARVOMlJMr4w9kbOXtSc3yfAQgemrZ5W9t+o5IBqD/0SIPKjD0kA/EL5ecyjJsQLDChc1oNPAcBl2auUwhp46r3JifMZW/hVY6S7crBMTWBv+jmw8/RKazB9QWxEhIa62XqU5Mlr8lJPl3DUgiI1I43qWM+JsaRwrV72IT0JD+Uou7pRdprSRiVao2YTIcwj0bjyuAWOuS7aqY4Y1HfSqQWo0CU6Hq/jYDE9uZLnryJ4j/GEdYbZ4odrHDsSKuKXQ29o9Oe+J5xyGZX8R5QLgYn2Q6fgXTQ/bQOsOBnWmaIYFe19QmCOT2LyZeICAnaEceFZVgTMlpkSxR8FIEVRdz/7/3caHlDHm1/D8ySENzMAYB8vegHt2Z7qCvkiQzy3EcPriwyzEPv8mgOn4RtIk2WFbSiPvuYck8CUmaLi; 4:0W1MXm7aI1vN+COu712ziPbsM81rEOZl2lscsmW1L20cA+6zvAShT1rpkfF/CnDFQ8hJMSbKrdaNjD2/CDlmPPf0FxmAfrxwnkIKU6a32Ahr19V8/3kw2T0fCtJjCMSdx0dpdzpxeToT0KRKo9Wz3+LgbQMYINmNaYzW4PiqztsliaoedjmabSHhkrEu4TvFM2rObCr8pGT1tZaMPn81RAeo1IgfiZwYK2M7OOB8gnpmRqOW+a3h4mLw1KeEtX7NxVtRkd0y2gF6n+2XyvG2SdZWrdeflwojwQYC77liVM5zv5Z3VLcDePhpLtqLpgpO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4425; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4425; X-Forefront-PRVS: 06400060E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(376002)(366004)(39860400002)(346002)(199004)(189003)(2351001)(6916009)(26005)(8936002)(478600001)(2361001)(8676002)(68736007)(5660300001)(69596002)(1076002)(81156014)(305945005)(3846002)(36756003)(50226002)(86362001)(7736002)(25786009)(16586007)(81166006)(186003)(476003)(4326008)(6116002)(1857600001)(486006)(7696005)(97736004)(2616005)(316002)(16526019)(956004)(21086003)(51416003)(55016002)(53936002)(105586002)(6666003)(2906002)(106356001)(47776003)(50466002)(66066001)(52116002)(48376002)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4425; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR05MB4425; 23:rDzC0aZyNAAKdWKPtuN9QDlnDPDq2Zvz5ycVDOOFJ?= =?us-ascii?Q?6qS32t/sJA7s1Xl2rUdtHlvCnyDTZFh0tK+XfeR8xXDoVOFmrJLtcOJTLT0k?= =?us-ascii?Q?cfywaS3PC0ETysYe4pjmJ+ejev5ElPDpFUh5Gsr0lfwXK6W8dEKYNqmT3uki?= =?us-ascii?Q?BNllg4GTiuNKwU6NHAnlz9lzZlmAI5YBnJDpeCUjNmZxAqf6m9NHmlM4fN0L?= =?us-ascii?Q?KjkOXIWuvXv6gGR60LcAZDrfqDHyHnL0vzPE0nLjHCC1DBZKkcAQmE4gk1ig?= =?us-ascii?Q?zlPJBEvAZcswcUaesdmIYKiw+uenx7mJ3qnbLbMRF3ruxrXo9CUt2Hq5JLbi?= =?us-ascii?Q?kCZ2P4iV3iZb3UEF4F8oiaoKwYTl2inRUtxOQfLt+mycsIoTx0DpT8a/eQ3V?= =?us-ascii?Q?4fot057bK0jMH26Oro8FqGv4kFV89263w88KT34cF3Sb/LdemmA6eq9O6Kei?= =?us-ascii?Q?XHtLN3tUGIv7kPFAEgf21n50oXB+EtKgDnW7xb4MzfXuf0QvTtInn48wBb8g?= =?us-ascii?Q?puDD09NDw3yKXcZ2W9UwNzj99e/loIZflcljSM4X9xP6AKNWVApc8mAqqqpp?= =?us-ascii?Q?EqxNcq+AUUWi8Viffxwg6SvED/0KjcqpzW6tE6b3iKrPcfGYCuT9mdwkgmkR?= =?us-ascii?Q?Men+OYMsVtUmgxh/AWssYfoCnFHTLb+V0Gp8QvWcyrlDgKkI/A8ZReG/iaVI?= =?us-ascii?Q?lVeLmQPrF+8O7aievTVS5/0IGOnZLwzxKVQK/3RwZWiu2hUE+8Yk6PYx7zvf?= =?us-ascii?Q?MTh/FteLvyQ0Nirs+47t7llohsjhvzS0Gb1OLIJK1ZsumBTnYVUnly9jDbSf?= =?us-ascii?Q?C0pYpWJ6iXC1UBgJJBEYyMzxgEB5joiX/8X6SctrmGur/9h74baZNE3MwPma?= =?us-ascii?Q?g3lK+xzGI5DFjZ9cFuWv1qluVpyvsFC4d8Bg0X0wBgID3+PTm88k4EZjYaUG?= =?us-ascii?Q?MHL1UppUXY8ehtVszFzvSxYQ8cSBTM7fSNJh7sC491cJvZyfxdj6Cxw/HJsY?= =?us-ascii?Q?O6j/SBDOcDr5fBJPBx8rC/6s19w6pz1oIi3pgFrgkJCR+7fgqfoz5C9Udf52?= =?us-ascii?Q?TJrS2N/Zj/aIigSHZqit1g9pYlkyOn1PC6KSSEW+PM2BMf5vfyHbi2xMZF1h?= =?us-ascii?Q?/OkIjtB9brJiUAShxss4jgGZb1SYbnq5DBN4ivqXuzR6bfnp6/E+GQdr+GcU?= =?us-ascii?Q?m0l6S9Y3uWV68IDo6/LMtUidLa8wqkUfGcS8cCTrcxq+3sNSv0dQFnWqQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Antispam-Message-Info: SYQXsq7GbqoTgMnXxAioSjiCXg9SR3qDA4uYD8rsuFkmNvUXaSPZIqdKFGyBo/kWkn7vR5H/f5/20J7nVB1REgy17IGWyNcLsqL4ZpRfrrD3WHZM2U3LHAw1Qpwr01fbo213aWYlBbo0EFvaYEcT+SdaBZYGJx949ZHKipUHCMw2OQFi3iYP9gY2sVacXMYj X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4425; 6:wR7UGTgaxG47uq5K54nYlepHbepxgi4qhuYZ0amXM6sNDodzVkKu2UfPvZSFCxDYymV7DcG/GY0o8794p9VUuVr5aZJFaBF6eywZYhOG3cWaliaTo+HoMD0Lc5GjoWMvXE1hjN5ebD43+EyqPoN9MnyUg5m1y3N/I73eF/7gKsxBEPnAID989nXD0XDPKsPfkc+ha9olSCECBswbJsOKdBA8pSsGgyO5frKAoGai9m4Qe0821kRoyH9TPqpWXG0uACr9J+5J4PF4acsBgm9U1rITzRZtlMdBjAB+Xia/v7Y4YdNBIflyp0lW5tjqhT+O49I8dFTtw/32nN2m/Y0HqiU4Nt/rMlKAOueSZ+A+haL6xKxbxLCjkxP7iKar3QInK6yTki4XnNX9ttVUtFRWxeSqluwvZH9XSWNHEcJT6w50KO5WVw079r+0DmGvm2VVdnzWenZhMUVD5/ZrY45YIQ==; 5:4PrfTJju5qWg3cnG29r3kBYGANezLoaZ222TCyjYGn+PfGCdO6zzeBaVJRHsNWyjc6/eX2nwPm1w80tMlXDuEfzKwgEdtQp0F0TxQjr1cJrCyjFvooRCkySCxKyeygepRly+BqDZQEgwXLfRPAbL7gciSVSGlM6YWVvtYcCNjEY=; 24:00vKEyn9xMVq+AjaI718vG6nBqw3Z7ugLuh1nNp6/yLATn8WHVXpjbZxGrxh27mjrZGiEZrEy/aN5WAcG+81MN2douxpI6m4hoC+oP3XdOA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4425; 7:dutE3ctzVMu05mor4Ttl/xK30SSrhWdoQ3QPylranh9ZsnLH5RA8Dp1pg60QdAaDBJ1AWCfDiEVl1OADu/mfC3OLJy2uoGig0h4c69rjGBWXxZkffFc05aB7QxBWqVaD4qEEaBCk4BAV9v9AAd7PHWklbAcpQAjj0sy/o1Xi5NxTGVoXhsCbVdzmUiOUBttzfufXa02pMx4HjdtCZlttUtdbHcD/vwj6eQJzYV98kyF/SuUv5k8cuKv4gCVVN2MB X-MS-Office365-Filtering-Correlation-Id: f4532fdf-2817-47a9-98a4-08d5a07a1edd X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2018 13:34:30.2867 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4532fdf-2817-47a9-98a4-08d5a07a1edd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4425 Subject: [dpdk-dev] [PATCH] eal: fix compilation without VFIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 13:34:33 -0000 a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n == Build lib/librte_eal/linuxapp/eal CC eal_vfio.o /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes] rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t iova, ^ /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1542:1: error: no previous prototype for 'rte_vfio_dma_unmap' [-Werror=missing-prototypes] rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused iova, ^ As there is no use for those dummy functions without VFIO removing them completely. Fixes: 73a639085938 ("vfio: allow to map other memory regions") Cc: anatoly.burakov@intel.com Signed-off-by: Shahaf Shuler --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c index 589d7d4787..4163bd4e08 100644 --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c @@ -1529,20 +1529,4 @@ rte_vfio_noiommu_is_enabled(void) return c == 'Y'; } -#else - -int __rte_experimental -rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t iova, - __rte_unused uint64_t len) -{ - return -1; -} - -int __rte_experimental -rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused iova, - __rte_unused uint64_t len) -{ - return -1; -} - #endif -- 2.12.0