From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id BA6C0AACA for ; Fri, 13 Apr 2018 08:54:16 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DC88EB6F6; Fri, 13 Apr 2018 06:54:16 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E0882024CA9; Fri, 13 Apr 2018 06:54:15 +0000 (UTC) Date: Fri, 13 Apr 2018 08:54:14 +0200 From: Jens Freimann To: Ferruh Yigit Cc: "Ananyev, Konstantin" , "dev@dpdk.org" , "ailan@redhat.com" , "jan.scheurich@ericsson.com" , "vkaplans@redhat.com" , "Richardson, Bruce" , "thomas@monjalon.net" , "maxime.coquelin@redhat.com" Message-ID: <20180413065414.xox6ubdvsqh6ibu6@localhost.localdomain> References: <20180412143422.31739-1-jfreimann@redhat.com> <20180412143422.31739-2-jfreimann@redhat.com> <2601191342CEEE43887BDE71AB977258AE914601@IRSMSX102.ger.corp.intel.com> <22853253-69d9-b064-ef29-66ca19fb7846@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <22853253-69d9-b064-ef29-66ca19fb7846@intel.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 13 Apr 2018 06:54:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 13 Apr 2018 06:54:16 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 1/2] testpmd: add parameters buffersize-before-send and flush-timeout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 06:54:17 -0000 On Thu, Apr 12, 2018 at 05:30:54PM +0100, Ferruh Yigit wrote: >On 4/12/2018 3:57 PM, Ananyev, Konstantin wrote: >> Hi, >> >>> >>> Create a fifo to buffer received packets. Once it flows over put >>> those packets into the actual tx queue. The fifo is created per tx >>> queue and its size can be set with the --buffersize-before-sending >>> commandline parameter. >>> >>> A second commandline parameter is used to set a timeout in >>> milliseconds after which the fifo is flushed. >>> >>> --buffersize-before-sending [packet numbers] >>> Keep the mbuf in a FIFO and forward the over flooding packets from the >>> FIFO. This queue is per TX-queue (after all other packet processing). >>> >>> --flush-timer [delay] >>> Flush the packet queue if no packets have been seen during >>> [delay]. As long as packets are seen, the timer is reset. >>> >> >> I understand your desire to have some realistic fwd scenario, >> but why it all have to be put in iowfd mode? >> iowfd is the simplest one, mainly used to test raw PMD pefomance >> in nearly ideal conditions. >> Why not to create your own forwarding mode (as most people do)? >> That way you'll have your 'real world app' test scenario, >> while keeping iofwd code small and simple. > >+1 to having own forwarding mode for noisy neighbor, and leaving iofwd simple. I'm okay with a new forwarding mode. I'll send a v2. Thanks for the review Konstantin and Ferruh! regards, Jens