From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id DCA811BBC2 for ; Fri, 13 Apr 2018 14:13:15 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id r82so3843439wme.0 for ; Fri, 13 Apr 2018 05:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7G0p1ofrEJsoS5OVQ+I1bNFcwhkvKL5jzOwr2a+7rWw=; b=Towiow8TUJY0s/sGG9TzTCFoT9CjuA+Dq7OqxfiO8BhKX3HCz0JyqADSUEdm9taYDu k09+bllbYH2j4NDHuCAcyMaO8hzybXmQRYfgmewrdd6QsVo0PCFYrMpmgmXGwDCsSKI3 c+s4qSA2CUoe9eAyR/49AhcMnHd2J5x0qLGkoFwdkyFUJ9VoB+9JEE/PTXRMMDPOpNQ9 n5ji+v84EJc7hhlG0M6KbLIUBKWyF3RJC98CeGTm8rlGTcIWlYhf7o2qTEDJZyOP0q1v wZqOiiivkMaFbsw2HvDG0COouab3ETdvuFBjPQ8/f6FUt9DDmXu/cvsw6y1a8MwR1YiS FB4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7G0p1ofrEJsoS5OVQ+I1bNFcwhkvKL5jzOwr2a+7rWw=; b=VIwdCtu9+AcruZdFXg1YIF+KEmc9rRoMGl+jWq8atGW4KOQJIx3OInwEhrV0zqfmsB bdPUNkUCzDmVGAb4c2ARdNgoldoGHNCoA9VP/c9VEUs63v9yJKVPGmLrn2y5p9zyd5uC YnJn9uhSNunyKqD/RU79JC+gVT3jsXYVjeaZkPDOTVOBkPYwAgbATnvlLjJFsFNFKIjI fzgMbs2W4OUQ0jNRP6PmIqGSDZb3vsrut338HTONjGEr5mOpvnxdHyiq1QwlDYbFJXK5 k2PsvPn1Qr0OAwqOcm6wvktzXcsk0MuecabeKaJo2SzMVdb/679ydlpYgYAFKyE8vLqn OE+g== X-Gm-Message-State: ALQs6tBxThnPy2xmMOkFaraCmOQKQAWYmaKBEFDEiaFrGarYr9VrKiLu t3prVH18M8cN6aXKwxjOwnae X-Google-Smtp-Source: AIpwx492jQ0bT3hd1jnau9Lt4z24ZOrq2bxqsBxd4khDoVJbDNkQMR2LG0BbjiYFAZKFXwGrV78QTg== X-Received: by 10.28.197.205 with SMTP id v196mr3756376wmf.39.1523621595668; Fri, 13 Apr 2018 05:13:15 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h197sm2110607wmd.3.2018.04.13.05.13.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Apr 2018 05:13:15 -0700 (PDT) Date: Fri, 13 Apr 2018 14:13:39 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Xueming Li Cc: Shahaf Shuler , dev@dpdk.org Message-ID: <20180413121339.6hzso326hp4udc5f@laranjeiro-vm.dev.6wind.com> References: <20180410133415.189905-1-xuemingl%40mellanox.com> <20180413112023.106420-4-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180413112023.106420-4-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 03/14] net/mlx5: support L3 VXLAN flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 12:13:16 -0000 On Fri, Apr 13, 2018 at 07:20:12PM +0800, Xueming Li wrote: > This patch support L3 VXLAN, no inner L2 header comparing to standard > VXLAN protocol. L3 VXLAN using specific overlay UDP destination port to > discriminate against standard VXLAN, FW has to be configured to support > it: > sudo mlxconfig -d -y s IP_OVER_VXLAN_EN=1 > sudo mlxconfig -d -y s IP_OVER_VXLAN_PORT= This fully deserves to update MLX5 guide with such information, users are already not reading it, don't expect them to read commit logs. > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5_flow.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 2aae988f2..644f26a95 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -413,7 +413,9 @@ static const struct mlx5_flow_items mlx5_flow_items[] = { > .dst_sz = sizeof(struct ibv_flow_spec_tunnel), > }, > [RTE_FLOW_ITEM_TYPE_VXLAN] = { > - .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH), > + .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH, > + RTE_FLOW_ITEM_TYPE_IPV4, /* L3 VXLAN. */ > + RTE_FLOW_ITEM_TYPE_IPV6), /* L3 VXLAN. */ s/L3/For L3/ > .actions = valid_actions, > .mask = &(const struct rte_flow_item_vxlan){ > .vni = "\xff\xff\xff", > -- > 2.13.3 There is an important question about this support as the firmware needs to be configured for it. 1. Is such rule accepted by the kernel modules if the support is not enabled in the firmware? 2. Is it possible from the PMD to query such information? If both answers are no, such features should be enabled through a device parameter to let the PMD refuse such un-supported flow request. Thanks, -- Nélio Laranjeiro 6WIND