From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id DD3051C333 for ; Fri, 13 Apr 2018 15:40:10 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id x82so4276936wmg.1 for ; Fri, 13 Apr 2018 06:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=+9CMWXgN2ojGtd3JS5LxD1e3f3hUauS/1cHFkveVWBM=; b=cEcrJ2MFcx5DubylFDc8VXBQ7zFHJxaR2Lo6j6rxWqKQ7h4RpOltJXTLnaBo8PhFeQ LwN9Fzy2f8z0Nj9fJaCDZAL/rRbyO1/Y6uoXy1tY8f3kqtmU8ga1EmfqMjS5wXAXo3bb YOyT4yxNfztlkwZuAuqCf7MxqKW6IfhJLadLmkPRNa6XUU588tMqDazaYMDvT75Rwi/G n/ZEqsZeIwFZRwqWVJRidCfh8PLlFNdtPUtfTy0Dc4ppQ9XACtwa2YALdYQSp+ZcL7fu H+WVJhboR1sWsidHarHWwPb4KST3D5+ISuFf23SqwIzbvPz0t4D7tYsn2YcnUwNP8D2C fMlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=+9CMWXgN2ojGtd3JS5LxD1e3f3hUauS/1cHFkveVWBM=; b=bCisq/csleTaHiQ0Q/vC5C7IDh7BWNJ7IbTh0oU8wp+gJ662d5khOnx75aLlIuNNZc RCT3CKD7wJi3jUocGeYvAtWGqLyEU4WW8pVn7XfXycqxBhEC5NYEVs11rtqxBKZbbW2L fdrwYd3vGKbnnMG4mW5ZJ50DrpXNy46sa1EFCq8+raksDJ/PgYqouUiskh3XclzidGn7 1L058h3KaBKofP6Nb/TQKEeKCdikmMorjGrT4W8STQV8ZPg9/+IAwUdblguslOFbZ3e6 Hx5gRhy7rIxUFqru/ib3HJfcvbk4bBGcofbBlfBUIwvHXvB3PsR8TnDvouJ/pvz9g+wI ywAA== X-Gm-Message-State: ALQs6tBwBRNVOMILG1NlSOB3F13oHspMSLuZqdYLeYO611WmpuQiyO7W FvuNRCttRtJ5El985sez1K+6 X-Google-Smtp-Source: AIpwx4/rN7mFmhEkG2ZMDU0vEyVvnGZpcS3iStio/7kRT+hYLcWwTGImVCfVDainmJ/HlB6wQotoKg== X-Received: by 10.28.249.8 with SMTP id x8mr3544996wmh.12.1523626810723; Fri, 13 Apr 2018 06:40:10 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s15sm5881207wrg.28.2018.04.13.06.40.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Apr 2018 06:40:10 -0700 (PDT) Date: Fri, 13 Apr 2018 15:40:34 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Xueming Li Cc: Shahaf Shuler , dev@dpdk.org Message-ID: <20180413134034.6rzdajk4gef73x2h@laranjeiro-vm.dev.6wind.com> References: <20180410133415.189905-1-xuemingl%40mellanox.com> <20180413112023.106420-14-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180413112023.106420-14-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 13/14] net/mlx5: fix invalid flow item check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 13:40:11 -0000 On Fri, Apr 13, 2018 at 07:20:22PM +0800, Xueming Li wrote: > This patch fixed invalid flow item check. > > Fixes: 4f1a88e3f9b0 ("net/mlx5: standardize on negative errno values") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 98edf1882..d36b6ed8a 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -935,8 +935,10 @@ mlx5_flow_convert_items_validate(struct rte_eth_dev *dev, > break; > } > } > - if (!token) > + if (!token) { > + ret = -ENOTSUP; > goto exit_item_not_supported; > + } > cur_item = token; > ret = mlx5_flow_item_validate(items, > (const uint8_t *)cur_item->mask, > -- > 2.13.3 Should be proposed outside of this series. Thanks, -- Nélio Laranjeiro 6WIND