From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 79B39AAA2 for ; Sat, 14 Apr 2018 12:57:56 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2018 03:57:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,448,1517904000"; d="scan'208";a="33629105" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.164]) by orsmga008.jf.intel.com with ESMTP; 14 Apr 2018 03:57:49 -0700 Date: Sat, 14 Apr 2018 18:55:46 +0800 From: Tiwei Bie To: Ferruh Yigit Cc: Qi Zhang , Xiao Wang , John McNamara , Marko Kovacevic , Beilei Xing , Wenzhuo Lu , Rasesh Mody , Harish Patil , Shahed Shaikh , Tetsuya Mukawa , Yuanhan Liu , Maxime Coquelin , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , dev@dpdk.org Message-ID: <20180414105546.25vqtpcfkexwlkhp@debian> References: <20180313180534.232296-1-ferruh.yigit@intel.com> <20180410154102.uv7og3ff4y5ylc3m@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] drivers/net: update link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2018 10:57:57 -0000 On Fri, Apr 13, 2018 at 10:53:55PM +0100, Ferruh Yigit wrote: > On 4/10/2018 4:41 PM, Tiwei Bie wrote: > > On Tue, Mar 13, 2018 at 06:05:34PM +0000, Ferruh Yigit wrote: > >> Update link status related feature document items and minor updates in > >> some link status related functions. > >> > >> Signed-off-by: Ferruh Yigit > >> --- > >> doc/guides/nics/features/fm10k.ini | 2 ++ > >> doc/guides/nics/features/fm10k_vf.ini | 2 ++ > >> doc/guides/nics/features/i40e_vf.ini | 1 + > >> doc/guides/nics/features/igb_vf.ini | 1 + > >> doc/guides/nics/features/qede.ini | 1 - > >> doc/guides/nics/features/qede_vf.ini | 1 - > >> doc/guides/nics/features/vhost.ini | 2 -- > >> doc/guides/nics/features/virtio_vec.ini | 1 + > >> drivers/net/e1000/em_ethdev.c | 2 +- > >> drivers/net/ena/ena_ethdev.c | 2 +- > >> drivers/net/fm10k/fm10k_ethdev.c | 6 ++---- > >> drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > >> drivers/net/mlx4/mlx4_ethdev.c | 2 +- > >> drivers/net/mlx5/mlx5_ethdev.c | 2 +- > >> 15 files changed, 15 insertions(+), 14 deletions(-) > > [...] > >> diff --git a/doc/guides/nics/features/vhost.ini b/doc/guides/nics/features/vhost.ini > >> index dffd1f493..31302745a 100644 > >> --- a/doc/guides/nics/features/vhost.ini > >> +++ b/doc/guides/nics/features/vhost.ini > >> @@ -4,8 +4,6 @@ > >> ; Refer to default.ini for the full list of available PMD features. > >> ; > >> [Features] > >> -Link status = Y > >> -Link status event = Y > > > > I think vhost PMD supports above features. > > I am not able to find where it is supported. > > Some virtual PMDs report fixed link, with empty link_update() dev_ops, and they > are not reported as supporting Link status, as far as I can see vhost also one > of them. > > And for Link status event, PMD needs to support LSC interrupts and should > register interrupt handler for it, which I can't find for vhost. > > I will send next version without updating above one, please point me where these > support added if I missed them. In drivers/net/vhost/rte_eth_vhost.c you could find below functions: static int new_device(int vid) { ...... eth_dev->data->dev_link.link_status = ETH_LINK_UP; ...... _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); ...... } static void destroy_device(int vid) { ...... eth_dev->data->dev_link.link_status = ETH_LINK_DOWN; ...... _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC, NULL); ...... } They are the callbacks for vhost library. When a frontend (e.g. QEMU) is connected to this vhost backend and the frontend virtio device becomes ready, new_device() will be called by the vhost library, and the link status will be updated to UP. And when e.g. the connection is closed, destroy_device() will be called by the vhost library, and the link status will be updated to DOWN. So vhost PMD reports meaningful link status and also generates link status events. Thanks