From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 9BFCB1B020 for ; Mon, 16 Apr 2018 10:12:40 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id d1so23281184wrj.13 for ; Mon, 16 Apr 2018 01:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r83VG0MJX0aZggCxLi9PR56LmBDUkFlAj7yDi6KeNOM=; b=LYhkr/xxghV6yVQ8A2ifJ24kNzJZs3xInnvwqmoQiBj3kW//McfgyaG7NKpICUUyfB M49YYxSaxUsW7BFtN6PJJlL2SWd0xqVaasRNy5fzk+fhgRYYHvGE8+Kj8488G4ijgIyv LA/YzxGoSzez9rLrqKujWqbDyrTjDsUoKPfvFQdcL/0HySP94RajnuPVLqdBTcY95lMO h/uhp/R1bFpvnyb4XfcYgpbBrEN8lNOTHgqa0LQYTx4PLspCS2L95WMZ2pthZhz7ev5V DE1bDGVE8pPGhQh8cgIVa/ZqNgQtT53roU4xxcvmD7eHwdh3H4kM0Seqb9liqgVLTVZ5 SF7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r83VG0MJX0aZggCxLi9PR56LmBDUkFlAj7yDi6KeNOM=; b=miCd8DX0LhvYO/O5yfW5f54HW2qbylPKbC9dz6pCt5Qt5xerw45QYchSthHVfK7+Ef hyk7lRxL5t3GDNsLziA17Ix5k57S1IrEDi2tDA24OI2EwO3gNikJanCYtKJOHw2mKvYH OXSJNFs6gbF6e0rYGIW+j+iM/S/FGRe0NWddRPlP4vOTJtS9Tl0cdcJBg1wM/LxEWXhM SwnFHRx+BExYb2mnucuzcZiDp42XUx+3PpvHEi8+fwNoqD5j7sLtaM5lvgY2s/rKYndP hc7roU86kfYwxMUs/Xk2BiEzRkLVgIyGl1n2VlD1qabQBeamMMQNF+dro3Ks0c7NuiO4 FD/g== X-Gm-Message-State: ALQs6tAxvO8QiKk6jeS4kLnk0b/NKRbetpvlkG4uDwObwW++A7Fyk8Tg rCOg9/YYcLoW/Vcuo9PDHMEpeA== X-Google-Smtp-Source: AIpwx4+wnXar2my0nkI+cbtE6fQLp1Y0cNZ4k0B3C6DkPEqwfHGihdRV2N9gkTpvz0eyWmXMqTB+Ew== X-Received: by 10.223.197.209 with SMTP id v17mr10021968wrg.45.1523866360382; Mon, 16 Apr 2018 01:12:40 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d9sm11012953wmh.38.2018.04.16.01.12.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 01:12:39 -0700 (PDT) Date: Mon, 16 Apr 2018 10:12:26 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: Qi Zhang , "dev@dpdk.org" , "declan.doherty@intel.com" , "sugesh.chandran@intel.com" , "michael.j.glynn@intel.com" , "yu.y.liu@intel.com" , "konstantin.ananyev@intel.com" , "bruce.richardson@intel.com" , Thomas Monjalon Message-ID: <20180416081226.GU4957@6wind.com> References: <1522279780-34842-1-git-send-email-qi.z.zhang@intel.com> <20180416051639.188034-1-qi.z.zhang@intel.com> <20180416051639.188034-4-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v3 3/4] ethdev: add TTL change actions in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 08:12:40 -0000 Hi Shahaf, On Mon, Apr 16, 2018 at 05:48:19AM +0000, Shahaf Shuler wrote: > Hi Qi, > > Am wondering if we can make the below more generic and not tailored for specific use cases. Regarding this, please see my previous answer [1] where I asked Qi to make his changes more focused on the use case at hand when it became clear all this work was targeting OpenFlow. The OF specification [2] defines the behavior associated with each action, for instance when a TTL is 0 or decrementing it would yield 0, the packet must be dropped. Translating this to a generic decrement action for any packet field is not so easy and not convenient. Therefore my opinion is that if OF actions as defined by this specification are supported as hardware capabilities, it makes sense to define dedicated rte_flow actions for each of them (although "OF" should be part of their name for clarity). I'll comment the patch proper in a separate message. [1] http://dpdk.org/ml/archives/dev/2018-April/096857.html [2] https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.0.pdf -- Adrien Mazarguil 6WIND