From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
 [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 250FCAA90
 for <dev@dpdk.org>; Mon, 16 Apr 2018 17:34:14 +0200 (CEST)
Received: by mail-pf0-f193.google.com with SMTP id p15so10702669pff.11
 for <dev@dpdk.org>; Mon, 16 Apr 2018 08:34:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=JUKRujTSajBpWwKx8fTGi8A2613ffhFIGAb6jvwl+m0=;
 b=oo1+k0y5lOxPzJreeQkqL6kEgyDWIVv4MlL/Alepd//VWG8X6PYgqZvgcmGkqDhZbD
 mm4Q08yGC1mWP4xDVQzORoubV8qXkymzVyY9Hs4+CUYAjZmCWP4XHe33PgPfow8nymZn
 zSOJJNUxSFweGSaP2/8cnpfsIYblAtG6hImHdsqyCulNzJjzeK6OABQy3H3zYShVpdLa
 I6Ljs7QgEoko+cx1detkjp/5Md5hpYVFW6tVAH1xLYkosIEOYod88hdhEk0AZSopy5O6
 MvvkcVT7+6PjxeVDFmFvKR5DmmuBOcejeot+/pzNzS4I4n6lwQGtve7SWXAQsiVClwPt
 jXxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=JUKRujTSajBpWwKx8fTGi8A2613ffhFIGAb6jvwl+m0=;
 b=nIIGXWhdz/dZUPcIud44GaiVRmXk4hLpfhlF90zQ11BQggiGxcxPmggl8LOLxbDjAm
 8MvoJbwIQTNg2wIamvtRZ+o7zHCCfTMpdoNBgRR6iU5FateQ4g4yMuKhYuBMLd1UK6Vg
 HQluzBpX+/aj/RnrDf0qldqtudGjfk0ynKZdBI8AgeliYOi1Hj1jKFOa76z2FM5QO3UY
 IvF1vTvNY6A/v3Yxpllir0Uymt01XmKFupOUq9Y7w1ncobsAbpnD16WjVSgjUmi62E62
 cfnYs0i89Af3ZKlSolFJ+1BQAId2VtJwC2r7QrvUSNIP8JFm9EM6pqpoME5JE8YXbL6z
 ZVJg==
X-Gm-Message-State: ALQs6tBI6wWeQKRURu3NL8ZsrV9+nioc3R08sfjjCGpcr674UOv3rVyT
 pdqwejCvdckDWy0rWiglFbNruRkV2KY=
X-Google-Smtp-Source: AIpwx4/Xrl5Hgt08rinpehSoDX60X7mvgEPda++8OpW9FP7LrXetWKTE3kDqS01NiASk77CY9OucDw==
X-Received: by 10.98.30.4 with SMTP id e4mr7278310pfe.212.1523892852278;
 Mon, 16 Apr 2018 08:34:12 -0700 (PDT)
Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95])
 by smtp.gmail.com with ESMTPSA id v63sm30344614pfk.8.2018.04.16.08.34.11
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 16 Apr 2018 08:34:11 -0700 (PDT)
Date: Mon, 16 Apr 2018 08:34:09 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com,
 declan.doherty@intel.com, jerin.jacob@caviumnetworks.com,
 bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org
Message-ID: <20180416083409.6d4cb085@xeon-e3>
In-Reply-To: <1523644244-17511-4-git-send-email-arnon@qwilt.com>
References: <1523644244-17511-1-git-send-email-arnon@qwilt.com>
 <1523644244-17511-4-git-send-email-arnon@qwilt.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 03/13] e1000: replace rte_panic instances
 in e1000 driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2018 15:34:14 -0000

On Fri, 13 Apr 2018 21:30:34 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:

> +	if (*vfinfo == NULL) {
> +		RTE_LOG(CRIT, PMD, "%s(): Cannot allocate memory for private "
> +				"VF data\n", __func__);
> +		return -1;
> +	}
>  
Don't split strings across lines. Checkpatch should complain about that.
It makes searching for error messages in source harder.

Instead do:
	if (!*vfinfo) {
		RTE_LOG(CRIT, PMD,
			"%s(): Cannot allocate memory for private VF data\n",
			__func__);
		return -1;
	}

Also why not use PMD_DRV_LOG() macro.