From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options
Date: Mon, 16 Apr 2018 15:59:47 +0530 [thread overview]
Message-ID: <20180416102946.GA18152@ltp-pvn> (raw)
In-Reply-To: <20180416100353.28271-1-thomas@monjalon.net>
On Mon, Apr 16, 2018 at 12:03:53PM +0200, Thomas Monjalon wrote:
> The options names in code and doc are not the same.
>
> Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter")
> Cc: pbhagavatula@caviumnetworks.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-eventdev/evt_options.c | 2 +-
> doc/guides/tools/testeventdev.rst | 12 ++++++------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
> index 5f311a570..701cd4e96 100644
> --- a/app/test-eventdev/evt_options.c
> +++ b/app/test-eventdev/evt_options.c
> @@ -248,7 +248,7 @@ usage(char *program)
> "\t burst mode.\n"
> "\t--nb_timers : number of timers to arm.\n"
> "\t--nb_timer_adptrs : number of timer adapters to use.\n"
> - "\t--timer_tick_nsec : timer tick interval in ns.\n"
> + "\t--timer_tick_ns : timer tick interval in ns.\n"
> "\t--max_tmo_nsec : max timeout interval in ns.\n"
> "\t--expiry_ns : event timer expiry ns.\n"
> );
I think it would be better to maintain consistency across options, I will send
a patch to fix it.
Thanks,
Pavan
next prev parent reply other threads:[~2018-04-16 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 10:03 Thomas Monjalon
2018-04-16 10:07 ` Pavan Nikhilesh
2018-04-16 10:29 ` Pavan Nikhilesh [this message]
2018-04-16 10:46 Pavan Nikhilesh
2018-04-16 16:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416102946.GA18152@ltp-pvn \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).