* [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options
@ 2018-04-16 10:46 Pavan Nikhilesh
2018-04-16 16:07 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Pavan Nikhilesh @ 2018-04-16 10:46 UTC (permalink / raw)
To: thomas, jerin.jacob; +Cc: dev, Pavan Nikhilesh
The options names in code and doc are not the same.
Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter")
Suggested-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
app/test-eventdev/evt_options.c | 2 +-
app/test-eventdev/evt_options.h | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
index 5f311a570..cfa43a165 100644
--- a/app/test-eventdev/evt_options.c
+++ b/app/test-eventdev/evt_options.c
@@ -250,7 +250,7 @@ usage(char *program)
"\t--nb_timer_adptrs : number of timer adapters to use.\n"
"\t--timer_tick_nsec : timer tick interval in ns.\n"
"\t--max_tmo_nsec : max timeout interval in ns.\n"
- "\t--expiry_ns : event timer expiry ns.\n"
+ "\t--expiry_nsec : event timer expiry ns.\n"
);
printf("available tests:\n");
evt_test_dump_names();
diff --git a/app/test-eventdev/evt_options.h b/app/test-eventdev/evt_options.h
index c059f7084..1bc7ea0f6 100644
--- a/app/test-eventdev/evt_options.h
+++ b/app/test-eventdev/evt_options.h
@@ -36,9 +36,9 @@
#define EVT_PROD_TIMERDEV_BURST ("prod_type_timerdev_burst")
#define EVT_NB_TIMERS ("nb_timers")
#define EVT_NB_TIMER_ADPTRS ("nb_timer_adptrs")
-#define EVT_TIMER_TICK_NSEC ("timer_tick_ns")
+#define EVT_TIMER_TICK_NSEC ("timer_tick_nsec")
#define EVT_MAX_TMO_NSEC ("max_tmo_nsec")
-#define EVT_EXPIRY_NSEC ("expiry_ns")
+#define EVT_EXPIRY_NSEC ("expiry_nsec")
#define EVT_HELP ("help")
enum evt_prod_type {
@@ -292,10 +292,10 @@ evt_dump_producer_type(struct evt_options *opt)
evt_dump("max_tmo_nsec", "%"PRIu64"", opt->max_tmo_nsec);
evt_dump("expiry_nsec", "%"PRIu64"", opt->expiry_nsec);
if (opt->optm_timer_tick_nsec)
- evt_dump("optm_timer_tick_ns", "%"PRIu64"",
+ evt_dump("optm_timer_tick_nsec", "%"PRIu64"",
opt->optm_timer_tick_nsec);
else
- evt_dump("timer_tick_ns", "%"PRIu64"",
+ evt_dump("timer_tick_nsec", "%"PRIu64"",
opt->timer_tick_nsec);
break;
}
--
2.17.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options
2018-04-16 10:46 [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options Pavan Nikhilesh
@ 2018-04-16 16:07 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-04-16 16:07 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev, jerin.jacob
16/04/2018 12:46, Pavan Nikhilesh:
> The options names in code and doc are not the same.
>
> Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter")
>
> Suggested-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options
2018-04-16 10:03 Thomas Monjalon
2018-04-16 10:07 ` Pavan Nikhilesh
@ 2018-04-16 10:29 ` Pavan Nikhilesh
1 sibling, 0 replies; 5+ messages in thread
From: Pavan Nikhilesh @ 2018-04-16 10:29 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, jerin.jacob
On Mon, Apr 16, 2018 at 12:03:53PM +0200, Thomas Monjalon wrote:
> The options names in code and doc are not the same.
>
> Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter")
> Cc: pbhagavatula@caviumnetworks.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-eventdev/evt_options.c | 2 +-
> doc/guides/tools/testeventdev.rst | 12 ++++++------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
> index 5f311a570..701cd4e96 100644
> --- a/app/test-eventdev/evt_options.c
> +++ b/app/test-eventdev/evt_options.c
> @@ -248,7 +248,7 @@ usage(char *program)
> "\t burst mode.\n"
> "\t--nb_timers : number of timers to arm.\n"
> "\t--nb_timer_adptrs : number of timer adapters to use.\n"
> - "\t--timer_tick_nsec : timer tick interval in ns.\n"
> + "\t--timer_tick_ns : timer tick interval in ns.\n"
> "\t--max_tmo_nsec : max timeout interval in ns.\n"
> "\t--expiry_ns : event timer expiry ns.\n"
> );
I think it would be better to maintain consistency across options, I will send
a patch to fix it.
Thanks,
Pavan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options
2018-04-16 10:03 Thomas Monjalon
@ 2018-04-16 10:07 ` Pavan Nikhilesh
2018-04-16 10:29 ` Pavan Nikhilesh
1 sibling, 0 replies; 5+ messages in thread
From: Pavan Nikhilesh @ 2018-04-16 10:07 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Mon, Apr 16, 2018 at 12:03:53PM +0200, Thomas Monjalon wrote:
> The options names in code and doc are not the same.
>
> Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter")
> Cc: pbhagavatula@caviumnetworks.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-eventdev/evt_options.c | 2 +-
> doc/guides/tools/testeventdev.rst | 12 ++++++------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options
@ 2018-04-16 10:03 Thomas Monjalon
2018-04-16 10:07 ` Pavan Nikhilesh
2018-04-16 10:29 ` Pavan Nikhilesh
0 siblings, 2 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-04-16 10:03 UTC (permalink / raw)
To: dev; +Cc: pbhagavatula
The options names in code and doc are not the same.
Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter")
Cc: pbhagavatula@caviumnetworks.com
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
app/test-eventdev/evt_options.c | 2 +-
doc/guides/tools/testeventdev.rst | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c
index 5f311a570..701cd4e96 100644
--- a/app/test-eventdev/evt_options.c
+++ b/app/test-eventdev/evt_options.c
@@ -248,7 +248,7 @@ usage(char *program)
"\t burst mode.\n"
"\t--nb_timers : number of timers to arm.\n"
"\t--nb_timer_adptrs : number of timer adapters to use.\n"
- "\t--timer_tick_nsec : timer tick interval in ns.\n"
+ "\t--timer_tick_ns : timer tick interval in ns.\n"
"\t--max_tmo_nsec : max timeout interval in ns.\n"
"\t--expiry_ns : event timer expiry ns.\n"
);
diff --git a/doc/guides/tools/testeventdev.rst b/doc/guides/tools/testeventdev.rst
index 46effd871..b03c4a17b 100644
--- a/doc/guides/tools/testeventdev.rst
+++ b/doc/guides/tools/testeventdev.rst
@@ -131,7 +131,7 @@ The following are the application command-line options:
Use burst mode event timer adapter as producer.
- * ``--timer_tick_nsec``
+ * ``--timer_tick_ns``
Used to dictate number of nano seconds between bucket traversal of the
event timer adapter. Refer `rte_event_timer_adapter_conf`.
@@ -140,7 +140,7 @@ The following are the application command-line options:
Used to configure event timer adapter max arm timeout in nano seconds.
- * ``--expiry_nsec``
+ * ``--expiry_ns``
Dictate the number of nano seconds after which the event timer expires.
@@ -379,9 +379,9 @@ Supported application command line options are following::
--prod_type_ethdev
--prod_type_timerdev_burst
--prod_type_timerdev
- --timer_tick_nsec
+ --timer_tick_ns
--max_tmo_nsec
- --expiry_nsec
+ --expiry_ns
--nb_timers
--nb_timer_adptrs
@@ -478,9 +478,9 @@ Supported application command line options are following::
--prod_type_ethdev
--prod_type_timerdev_burst
--prod_type_timerdev
- --timer_tick_nsec
+ --timer_tick_ns
--max_tmo_nsec
- --expiry_nsec
+ --expiry_ns
--nb_timers
--nb_timer_adptrs
--
2.16.2
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-16 16:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 10:46 [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options Pavan Nikhilesh
2018-04-16 16:07 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2018-04-16 10:03 Thomas Monjalon
2018-04-16 10:07 ` Pavan Nikhilesh
2018-04-16 10:29 ` Pavan Nikhilesh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).