From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by dpdk.org (Postfix) with ESMTP id 00EC51B024 for ; Mon, 16 Apr 2018 14:24:51 +0200 (CEST) Received: by mail-wr0-f176.google.com with SMTP id l49so25435061wrl.4 for ; Mon, 16 Apr 2018 05:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=gYwPLFkwHwgR38MriimfmL9D7BB1hcYBNPQstFWXrcQ=; b=o7Ws1tdGV9Gm0zgi+DWjqlaqCyaNmgXaDUjSsYWNd3lPsuSmjO7FMqjfFe2wc4vpVd KI99HaOvGxhnSVzfv8LGxWGB83qywnqYL//kjA/fLNYhHfnf+5WtNDbrD///olLQA3d3 g9wSHYpJoTrDh5VPwJBcgnwAS9AQI1Ud0MCFvb/8wI2PAMNa2kNJpwOWRsxr30bhxwXu y+EXT2Y4s+keCm1EOODwlPXfdO9SdiDMdT11s252WC9SHnFKufmD8ABvAcYBG089oHT/ ke71/FZPZ+Vwh3k12np8ygAccVAiN/F8AhOjqJZ3/+e/mMecoAKaW/MS7koXECw3BzwU eYmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=gYwPLFkwHwgR38MriimfmL9D7BB1hcYBNPQstFWXrcQ=; b=mlUJ01L4A8NwoLtzu9Y1haeQzAwfDAyo4nzPLQhkOB/RR6SGmb7bYnIs05UWmLdXCk SVp0qo3RnQ6nsxMzGCMrLXbjj/eufd7AcyKyWJmsHFD68Uco2rONra1p3vuzJGKB7tmw A4/uEJZ+vyodGmCkBv3wA69ixq18+VQ9KlIaUj8LGFL6YDBxL1yKKKSBpDHJMhaC/J3K h1BpW/LMY2h2ioUHD9x366yb7cPLEW9wM3Agp6oWdfMRNJQTcoy1Kk1kcXZCEoVpqM9E zfBmn04xsH18q7TUlgn8qDXHx4e18dCJv/PfYOWrKfkMAuQNmo/qPIhuESCR7PY5st4h jR6w== X-Gm-Message-State: ALQs6tAEmqbncZRtji55beeJeuSPBF0izv8jeOMvWspm+qsYs6bR20Il CSreQyD1IRmtM6Y7op76VXTy3Ti8Ww== X-Google-Smtp-Source: AIpwx4/qhQyNHg7Mc3TE1loYO7XLJOSzCjoEbS1yPcnCIxpf93OpQUphrvFgEAr/jKxhtOGHnKhROw== X-Received: by 10.28.142.1 with SMTP id q1mr11040570wmd.0.1523881491744; Mon, 16 Apr 2018 05:24:51 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m7sm11801317wrh.11.2018.04.16.05.24.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 05:24:51 -0700 (PDT) Date: Mon, 16 Apr 2018 14:25:22 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Xueming(Steven) Li" Cc: Shahaf Shuler , "dev@dpdk.org" Message-ID: <20180416122522.i4gwziqq3pxd2o32@laranjeiro-vm.dev.6wind.com> References: <20180410133415.189905-1-xuemingl%40mellanox.com> <20180413112023.106420-8-xuemingl@mellanox.com> <20180413132701.auavvxjj6sn5tzfq@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 07/14] net/mlx5: support tunnel RSS level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 12:24:52 -0000 On Sat, Apr 14, 2018 at 10:12:58AM +0000, Xueming(Steven) Li wrote: > Hi Nelio, >[...] > > > + if (!found) > > > + DRV_LOG(WARNING, > > > + "port %u rss hash function doesn't match " > > > + "pattern", dev->data->port_id); > > > > The hash function is toeplitz, xor, it is not applied on the pattern but > > used to compute an hash result using some information from the packet. > > This comment is totally wrong. > > Thanks, I'll replace "hash function" to "hash fields". > > > > > Another point, such log will trigger on an application using MLX5 PMD but > > not on MLX4 PMD and this specifically because on how the NIC using the > > MLX5 PMD are made internally (MLX4 can use a single Hash RX queue whereas > > MLX5 needs an Hash Rx queue per kind of protocol). > > The fact being it will have the exact same behavior I'll *strongly* > > suggest to remove such annoying warning. > > After some test on mlx5 current code, the behavior in previous code doesn't > seem to be consistent, not sure whether it same in mlx4 PMD: > - Pattern: eth/ipv4/tcp, RSS: UDP, creation success. > - Pattern: eth/ipv4,RSS: IPv6, creation failed. Seems there is a bug. > This patch support the 2nd case w/o hash, and warn upon the first case. > Take example of first case, a packet that matches the pattern must be TCP, > no reason to hash it as TCP, same to the 2nd case. They are totally > wrong configuration, but to be robust, warning is used here, and users > have to learn that NO hash result because HF configuration mismatch through > this warning message. > > Please note that below cases are valid and no warning: > - Pattern: eth/ipv4, RSS: UDP > - Pattern: eth/ipv4/udp, RSS: IPv4 This log will not raise for non IP protocols defined by the user, or it will raise when the user already expects it to not make RSS. It will more annoying than helping. Example: flow create 0 ingress eth ethertype is 0x0806 / end actions rss .... won't raise such log, whereas ARP is not an IP protocol and thus can be RSS'ed. flow create 0 ingress eth / ipv4 / end actions rss type ipv6... will raise the log, but it is obvious the user won't have RSS. Regards, -- Nélio Laranjeiro 6WIND