From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 664F2EE2D for ; Mon, 16 Apr 2018 14:27:00 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id v60so21563320wrc.7 for ; Mon, 16 Apr 2018 05:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZkuShtz8tRDhZaFIhgIrDKfX9UHSpM7gFovkTQL9lek=; b=ZW2zrEx3iBbraBv5MKNV2499RlZ9sl8UqwojawoBPfAPNdgZOHb3Y98gtj8DPrezgt qelGtJi0W1CEdn1Vzp8zqds9Q9Gqq5vtEoLFFXLYk5BZO2H3lMqi4JLS2n4Zzytr4CdB QQR1l+bvRPtIop4BFSKzO+xXdJT8KV3bDQ5hr34py7UU7i5lMXKRsMOT3galeucs7PFE wMhgsgtF3YURAiFOJFrWhxpO24874iqFpWansmz8476UNCBpHJmwSsEO3KUdVYr3lOrR T68KrSxwa8i1y/EcRvWVAEQ48Qndpgs1+znbJkwfwLZeGSebRMJ5t3Kr2bVsXLKstYfj 4/TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZkuShtz8tRDhZaFIhgIrDKfX9UHSpM7gFovkTQL9lek=; b=q4qeMxfXoqjlSOTaLE/ixoMYEpkAowPGrQkOOC6xk28SJ7td7P1j+99szrAP4PZAmb gVoE8dCoTsrEVWWhJ/NLh3uIK9hdZfLFACxhlmxw80R1sn3AvY9r2baiV5j3eZFWs3Zg /e87az4kzG3rZMP59AYvohosJ1jThXrwxveX2YQBNMd5PUobbmZwIqymqhaP2/A/N+4L 2giMdSs9+Nt8u4FJdngm7jeTPLde8RoS7CF/7UmxZdahF/b6Z+6odhnNW6eWYWXLtADG 2zMym9L0d1OYHCnCVbWftRZcMr7FEJZuq0N3iDIBwLCYjjo60P1v9jRmSevlckYBEwk/ rZxQ== X-Gm-Message-State: ALQs6tAQ7n4lf8Gq2niJY99WI1ddjHTWliYhp91PVurRn3qifmC+CKHg NVvoZxovrRwzVP8edlywWpa/ X-Google-Smtp-Source: AIpwx492FRflmyYLKIT+iJqQFwKvBEHxIF8wtA9FpnHfnBObikQ2sq9dnadApnJKGzPjHnW/Y5O+og== X-Received: by 10.28.184.86 with SMTP id i83mr9686830wmf.30.1523881620137; Mon, 16 Apr 2018 05:27:00 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z72sm504443wmc.28.2018.04.16.05.26.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 05:26:59 -0700 (PDT) Date: Mon, 16 Apr 2018 14:27:30 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Xueming(Steven) Li" Cc: Shahaf Shuler , "dev@dpdk.org" Message-ID: <20180416122730.ahg7kj5ixp6kb3vk@laranjeiro-vm.dev.6wind.com> References: <20180410133415.189905-1-xuemingl@mellanox.com> <20180410133415.189905-8-xuemingl@mellanox.com> <20180411085529.ecxuku77hg3mkybl@laranjeiro-vm.dev.6wind.com> <20180416071409.oee2ttblbrg46yc6@laranjeiro-vm.dev.6wind.com> <20180416080922.g7os2gjwod7h2ecp@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 12:27:00 -0000 On Mon, Apr 16, 2018 at 10:06:06AM +0000, Xueming(Steven) Li wrote: > > > > -----Original Message----- > > From: Nélio Laranjeiro > > Sent: Monday, April 16, 2018 4:09 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 07/15] net/mlx5: support tunnel RSS level > > > > On Mon, Apr 16, 2018 at 07:46:08AM +0000, Xueming(Steven) Li wrote: > > >[...] > > > > > > > @@ -1386,6 +1386,8 @@ mlx5_ind_table_ibv_verify(struct > > > > > > > rte_eth_dev > > > > *dev) > > > > > > > * Number of queues. > > > > > > > * @param tunnel > > > > > > > * Tunnel type. > > > > > > > + * @param rss_level > > > > > > > + * RSS hash on tunnel level. > > > > > > > * > > > > > > > * @return > > > > > > > * The Verbs object initialised, NULL otherwise and rte_errno > > is > > > > set. > > > > > > > @@ -1394,13 +1396,17 @@ struct mlx5_hrxq * > > > > > > > mlx5_hrxq_new(struct rte_eth_dev *dev, > > > > > > > const uint8_t *rss_key, uint32_t rss_key_len, > > > > > > > uint64_t hash_fields, > > > > > > > - const uint16_t *queues, uint32_t queues_n, uint32_t > > > > tunnel) > > > > > > > + const uint16_t *queues, uint32_t queues_n, > > > > > > > + uint32_t tunnel, uint32_t rss_level) > > > > > > > > > > > > tunnel and rss_level seems to be redundant here. > > > > > > > > > > > > rss_level > 1 is equivalent to tunnel, there is no need to have > > both. > > > > > > > > > > There is a case of tunnel and outer rss(1). > > > > > > > > Why cannot it be handled by a regular Hash Rx queue, i.e. what is > > > > the benefit of creating a tunnel hash Rx queue to make the same job > > > > as a legacy one? > > > > > > Tunnel checksum, ptype and rss offloading demand a QP to be created by > > > DV api with tunnel offload flags. > > > > I was expecting such answer, such information should be present in the > > function documentation, can you add it? > > You mean https://dpdk.org/doc/guides/nics/overview.html? > "Inner L3 checksum" and "Inner L4 checksum" defined. > I added "Inner RSS" per your suggestion, The only thing missing is > "Innner packet type", make sense? No I mean adding in this function doxygen documentation the fact than tunnel is to have the checksum offload whereas the rss_level will be to enable the RSS in the inner. Thanks, -- Nélio Laranjeiro 6WIND