From: Bruce Richardson <bruce.richardson@intel.com>
To: Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, jasvinder.singh@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated
Date: Mon, 16 Apr 2018 14:17:42 +0100 [thread overview]
Message-ID: <20180416131741.GA61692@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20180416110233.66450-1-roy.fan.zhang@intel.com>
On Mon, Apr 16, 2018 at 12:02:33PM +0100, Fan Zhang wrote:
> Coverity issue: 272572
> Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> examples/ip_pipeline/action.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
> index 77a04fe19..91011ebe8 100644
> --- a/examples/ip_pipeline/action.c
> +++ b/examples/ip_pipeline/action.c
> @@ -133,7 +133,7 @@ port_in_action_profile_create(const char *name,
> }
>
> /* Node fill in */
> - strncpy(profile->name, name, sizeof(profile->name));
> + strncpy(profile->name, name, sizeof(profile->name) - 1);
> memcpy(&profile->params, params, sizeof(*params));
> profile->ap = ap;
No, this still doesn't null terminate, and is a perfect example of why we
should never use strncpy! Use strlcpy instead.
next prev parent reply other threads:[~2018-04-16 13:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 11:02 Fan Zhang
2018-04-16 13:17 ` Bruce Richardson [this message]
2018-04-17 9:52 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2018-04-17 11:18 ` Bruce Richardson
2018-05-08 14:28 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian
2018-05-08 19:51 ` Bruce Richardson
2018-05-09 9:26 ` Dumitrescu, Cristian
-- strict thread matches above, loose matches on Subject: below --
2018-04-19 11:03 Kevin Laatz
2018-04-19 15:33 ` Singh, Jasvinder
2018-04-19 11:01 Kevin Laatz
2018-04-19 15:34 ` Singh, Jasvinder
2018-04-18 16:58 [dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable Reshma Pattan
2018-04-18 16:58 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Reshma Pattan
2018-04-19 8:36 ` Singh, Jasvinder
2018-04-18 16:58 ` Reshma Pattan
2018-04-19 8:35 ` Singh, Jasvinder
2018-04-17 13:28 Jasvinder Singh
2018-04-17 15:01 ` Bruce Richardson
2018-04-17 16:33 ` Singh, Jasvinder
2018-04-17 13:17 Jasvinder Singh
2018-04-17 14:59 ` Bruce Richardson
2018-04-16 16:57 Jasvinder Singh
2018-04-16 10:26 Fan Zhang
2018-05-08 14:27 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416131741.GA61692@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).