[dpdk-dev] [PATCH] net/ixgbe: fix compilation when vector driver disabled

[dpdk-dev] [PATCH] net/ixgbe: fix compilation when vector driver disabled

[Bruce Richardson]

The new functions for Rx and Tx offloads should not be inside the
conditional block for the vector driver, otherwise compile errors occur
when vector driver is disabled. For example:

  ixgbe_ethdev.c:3636:36: error: implicit declaration of function ‘ixgbe_get_rx_queue_offloads’;

This shows up as an error when doing ARM builds using meson as the vector
driver is not (yet) enabled for those builds.

Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
Fixes: ec3b1124d14d ("net/ixgbe: convert to new Rx offloads API")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h
index 642cf4d82..7dbbbe5b3 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.h
+++ b/drivers/net/ixgbe/ixgbe_rxtx.h
@@ -307,11 +307,11 @@ extern const uint32_t ptype_table_tn[IXGBE_PACKET_TYPE_TN_MAX];
 uint16_t ixgbe_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,
 				    uint16_t nb_pkts);
 int ixgbe_txq_vec_setup(struct ixgbe_tx_queue *txq);
+#endif /* RTE_IXGBE_INC_VECTOR */
 
 uint64_t ixgbe_get_tx_port_offloads(struct rte_eth_dev *dev);
 uint64_t ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev);
 uint64_t ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev);
 uint64_t ixgbe_get_tx_queue_offloads(struct rte_eth_dev *dev);
 
-#endif /* RTE_IXGBE_INC_VECTOR */
 #endif /* _IXGBE_RXTX_H_ */
-- 
2.14.3

Re: [dpdk-dev] [PATCH] net/ixgbe: fix compilation when vector driver disabled

[Thomas Monjalon]

16/04/2018 15:39, Bruce Richardson:
> The new functions for Rx and Tx offloads should not be inside the
> conditional block for the vector driver, otherwise compile errors occur
> when vector driver is disabled. For example:
> 
>   ixgbe_ethdev.c:3636:36: error: implicit declaration of function ‘ixgbe_get_rx_queue_offloads’;
> 
> This shows up as an error when doing ARM builds using meson as the vector
> driver is not (yet) enabled for those builds.
> 
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Fixes: ec3b1124d14d ("net/ixgbe: convert to new Rx offloads API")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

Re: [dpdk-dev] [PATCH] net/ixgbe: fix compilation when vector driver disabled

[Thomas Monjalon]

16/04/2018 15:39, Bruce Richardson:
> The new functions for Rx and Tx offloads should not be inside the
> conditional block for the vector driver, otherwise compile errors occur
> when vector driver is disabled. For example:
> 
>   ixgbe_ethdev.c:3636:36: error: implicit declaration of function ‘ixgbe_get_rx_queue_offloads’;
> 
> This shows up as an error when doing ARM builds using meson as the vector
> driver is not (yet) enabled for those builds.
> 
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Fixes: ec3b1124d14d ("net/ixgbe: convert to new Rx offloads API")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks