From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 039B9CF7A for ; Mon, 16 Apr 2018 18:22:06 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id d19so27713184wre.1 for ; Mon, 16 Apr 2018 09:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Jei4q+Jo5Y2Lg7jHtKyKuT3CMUFIZM81mA4jbn1jzcM=; b=fUj0go6jnO5LyW+yGET0vhH1ZKYM4QCatcP2WWVawmO1tCpQ2K27SKe+XygNfllcjp 690T3EOdUPZPDzLDAwGHLembdgJrgZIv1Uo2wb/Zy6A47D+Ip51qddCImgARmAaLXp3X mC7Jq7nkXn6qvmw7ntmlxTCMOqG0rJO9EIMFpqy//0ag9Z16Hd3WCpeP5quzyXiLkmln ciZ5XJZpxRFwrKbZwoe8Nray7rbRi6G0P1zSQ+2ntb/CZZ6EbqJ906INYbGbPynRAON1 cJ+LTIBsNsR7QWY9pQHB5MGxljPfX21I9J3vtRr9MEyvS7CljDaV04Q1sFINQ/bAw3JB Tiyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Jei4q+Jo5Y2Lg7jHtKyKuT3CMUFIZM81mA4jbn1jzcM=; b=P3cvQInSnNOlDm7EHztqRKAm2WP1mPYdtBSw3qbDVe6Zst0xVT3qPI+6XnjfVKJpYt DPnDetzGrZR/i4/9c/uZXNV4aAeY6wbOMcpksV0czY7qYlFGaUFqq3nUdcRq2rUPf18q wmp4OpbaWGxXkC0jPhdODTEkDLGP6XVNH/exUaY8Gt+ckVD10auftf5xd78x79ZbdjVI 7qejLKhwn4xzg3gzFVL4AkqMMztDJIMl5a6WJ6zoxpA/1ef61/+aUrIJUG66AI23hYIL VVHr4RnRrjToGx+zF1ECqDwzc5KT7RMODgD3bAh1aKTBdqr4ZNIO8vp40QwT8I6ZPThJ CfAQ== X-Gm-Message-State: ALQs6tAfPK9UksqwAryhHbhPfdAjm+4ZW2blmPXTUkEAxSPiA++whL4t ZBcL34xomwS6hEF0Qv6XsTF2SBgK X-Google-Smtp-Source: AIpwx48JO13QaG85uer/rY0VoKnACJ89OrEygZOxwUO1JDFd8ilMXnxyEQjbPuhYN8eP9cB8og5S4Q== X-Received: by 10.28.212.84 with SMTP id l81mr11109503wmg.151.1523895726449; Mon, 16 Apr 2018 09:22:06 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k184sm9392017wmk.21.2018.04.16.09.22.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 09:22:05 -0700 (PDT) Date: Mon, 16 Apr 2018 18:21:52 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Nelio Laranjeiro Message-ID: <20180416150058.2620-4-adrien.mazarguil@6wind.com> References: <20180410161132.8776-1-adrien.mazarguil@6wind.com> <20180416150058.2620-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180416150058.2620-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v5 03/11] net/mlx5: fix RSS flow action bounds check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 16:22:07 -0000 The number of queues provided by the application is not checked against parser's supported maximum. Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") Cc: stable@dpdk.org Cc: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 7ef68de49..1ca413e32 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -16,6 +16,7 @@ #pragma GCC diagnostic error "-Wpedantic" #endif +#include #include #include #include @@ -713,6 +714,14 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } } + if (rss->num > RTE_DIM(parser->queues)) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "too many queues for RSS" + " context"); + return -rte_errno; + } for (n = 0; n < rss->num; ++n) { if (rss->queue[n] >= priv->rxqs_n) { rte_flow_error_set(error, EINVAL, -- 2.11.0