From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 20A491AFE8 for ; Mon, 16 Apr 2018 18:22:43 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id v60so23816500wrc.7 for ; Mon, 16 Apr 2018 09:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6A0DEah9RFkPGNkjR+0O8wsOKty4WIciuqIP2BTT+Y0=; b=N8O0CWmdoY1boE1ToYNlpwxWXOR1WOftdr5vXq+TRlvptZYSBkqgOGD9pQ4hvskZ8r qC4A2BBYTt7vPQniHo7LIFB45MnevhnrrzxENZMnCFY5lXpMMVD4i28jBME00Tq3Q3nP lKPAIMxSk90P6NlTD2eYEFHMAYnx9kvuJLrYHzEirw0ybhfJi+0tMj1J7hQ78/y9dQ+V qY3b8QvmpMek6Tr6vxVKd/wdXAKC6iAVLY+wdhV0yDzQ3KSieXROQ3K0xD9vD0Ep3g54 ZZa/Hk6CxZWnhnqO+HPDatvAGS83dNyRrWJ57fNYVqSaHtf9uDeKtIUYfJWr8ffj9FX1 gnWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6A0DEah9RFkPGNkjR+0O8wsOKty4WIciuqIP2BTT+Y0=; b=bAvMsjom8LbaezmyVNsHcvPWBuOQjgN/TO/GGFBasAPV9NeIuEFhwWLz2iowAFplkq M1SgqaxllLHkE9GNNe12EnTZ7s32BTNDphRM0JfwGtoHCvvTD4fao8qc+FsFvBNE0fWc w9Y6aPwPLAVKqkjlv2SUd5MiiG3gGsrbUm9lgh0wztrhpRDefwdQ0IkKKYNGR/Ato+ev qDyqZNKYwFXIFJ2wB+6jDyYQRoimNnuU15GauYkS+JDf3uW2IUhYrcvOXQHxVoHbWBYW 2X/zEm2I5a5pnWYaE2h0o710O/cVln0cM8vv5NQ/k7dvtVX1vd/McvG37LaI8Zl+EmLl SQtA== X-Gm-Message-State: ALQs6tAV93TXaWcW22pq8/n+nzj5XOqWbigw0mfjkXUdbKE26wRPNEYu yBC/0syt0R7ntz+OuU/5QGeJTA== X-Google-Smtp-Source: AIpwx4+7c20+e1hL9Nr9tIAOWDct+oqlYZgSgTXhvK8KHCjglkO6a4H8HVlMbak7AHXWBuJbv81Bcg== X-Received: by 10.28.18.2 with SMTP id 2mr10963114wms.143.1523895762751; Mon, 16 Apr 2018 09:22:42 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id j3sm24765322wmf.23.2018.04.16.09.22.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 09:22:42 -0700 (PDT) Date: Mon, 16 Apr 2018 18:22:28 +0200 From: Adrien Mazarguil To: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org Message-ID: <20180416150525.2817-1-adrien.mazarguil@6wind.com> References: <20180410162022.9101-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410162022.9101-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v4 00/16] Flow API overhaul for switch offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 16:22:43 -0000 As summarized in a prior RFC [1], the flow API (rte_flow) was chosen as a means to manage switch offloads supported by many devices (usually going by names such as E-Switch or vSwitch) through user-specified flow rules. Combined with the need to support encap/decap actions, this requires a change in the way flow actions are processed (in order and possibly repeated) which modifies the behavior of some of the existing actions, thus warranting a major ABI breakage. Given this ABI breakage is also required by other work submitted for the current release [2][3], this series addresses various longstanding issues with the flow API and makes minor improvements in preparation for upcoming features. Changes summary: - Additional error types. - Clearer documentation. - Improved C++ compatibility. - Exhaustive RSS action. - Consistent behavior of VLAN pattern item. - New "transfer" attribute bringing consistency to VF/PF pattern items. - Confusing "PORT" pattern item renamed "PHY_PORT", with new action counterpart. - New "PORT_ID" pattern item and action to be used with port representors. This series piggybacks on the major ABI update introduced by a prior commit [4] for DPDK 18.05 and depends on several fixes [5] which must be applied first. [1] "[RFC] Switch device offload with DPDK" http://dpdk.org/ml/archives/dev/2018-March/092513.html [2] commit 676b605182a5 ("doc: announce ethdev API change for RSS configuration") [3] "[PATCH v1 00/21] MLX5 tunnel Rx offloading" http://dpdk.org/ml/archives/dev/2018-March/092264.html [4] commit 653e038efc9b ("ethdev: remove versioning of filter control function") [5] "[PATCH v4 00/11] Bunch of flow API-related fixes" http://dpdk.org/ml/archives/dev/2018-April/096509.html v5 changes: - No change besides new acked-by lines, rebased series to address conflicts. v3 changes: - Rebased series, fixed latest conflicts. - Addressed Andrew's comments, see affected patches for details: - Empty RSS types in flow rule means PMD-specific RSS instead of no RSS. - RSS hash function now explicitly compared against RTE_ETH_HASH_FUNCTION_DEFAULT instead of 0 in all PMDs. - sfc PMD updated to also accept Toeplitz. - Implicit VLAN TPID matching now removed from all PMDs. - Default mask upate for VLAN TCI now split as separate patch #11. - Ingress/egress definition clarified in patch #12. v2 changes: - Squashed "ethdev: update ABI for flow API functions" in subsequent patches. - Emphasized ABI impact in relevant commit logs. - Modified documentation in "ethdev: alter behavior of flow API actions" to describe how terminating flow rules without any action of the fate kind result in undefined behavior instead of dropping traffic. - Fixed other minor documentation formatting issues. - Modified "ethdev: refine TPID handling in flow API" as follows: - Using standard macro definitions for VLAN, QinQ and E-Tag EtherTypes. - Fixed endian conversion in sfc. - Replaced a condition in VLAN pattern item processing with an assertion check for i40e. Adrien Mazarguil (16): ethdev: add error types to flow API ethdev: clarify flow API pattern items and actions doc: remove flow API migration section ethdev: remove DUP action from flow API ethdev: alter behavior of flow API actions ethdev: remove C99 flexible arrays from flow API ethdev: flatten RSS configuration in flow API ethdev: add hash function to RSS flow API action ethdev: add encap level to RSS flow API action ethdev: refine TPID handling in flow API ethdev: limit default VLAN TCI mask in flow API ethdev: add transfer attribute to flow API ethdev: update behavior of VF/PF in flow API ethdev: rename physical port item in flow API ethdev: add physical port action to flow API ethdev: add port ID item and action to flow API app/test-pmd/cmdline_flow.c | 394 +++++++++++---- app/test-pmd/config.c | 78 +-- doc/guides/nics/tap.rst | 2 +- doc/guides/prog_guide/rte_flow.rst | 618 ++++++++--------------- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 60 ++- drivers/net/bnxt/bnxt_filter.c | 49 +- drivers/net/e1000/e1000_ethdev.h | 13 +- drivers/net/e1000/igb_ethdev.c | 4 +- drivers/net/e1000/igb_flow.c | 83 ++- drivers/net/e1000/igb_rxtx.c | 55 +- drivers/net/enic/enic_flow.c | 50 +- drivers/net/i40e/i40e_ethdev.c | 57 ++- drivers/net/i40e/i40e_ethdev.h | 15 +- drivers/net/i40e/i40e_flow.c | 130 +++-- drivers/net/ixgbe/ixgbe_ethdev.c | 7 +- drivers/net/ixgbe/ixgbe_ethdev.h | 13 +- drivers/net/ixgbe/ixgbe_flow.c | 91 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 55 +- drivers/net/mlx4/mlx4.c | 2 +- drivers/net/mlx4/mlx4_flow.c | 117 +++-- drivers/net/mlx4/mlx4_flow.h | 2 +- drivers/net/mlx4/mlx4_rxq.c | 2 +- drivers/net/mlx4/mlx4_rxtx.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 316 ++++++------ drivers/net/mlx5/mlx5_rxq.c | 22 +- drivers/net/mlx5/mlx5_rxtx.h | 26 +- drivers/net/mvpp2/mrvl_flow.c | 32 +- drivers/net/sfc/sfc_flow.c | 78 ++- drivers/net/tap/tap_flow.c | 49 +- examples/ipsec-secgw/ipsec.c | 21 +- lib/librte_ether/rte_ethdev_version.map | 22 +- lib/librte_ether/rte_flow.c | 68 +-- lib/librte_ether/rte_flow.h | 339 ++++++++----- lib/librte_net/rte_ether.h | 1 + 34 files changed, 1750 insertions(+), 1123 deletions(-) -- 2.11.0