From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id E29691AFFE for ; Mon, 16 Apr 2018 18:22:44 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id y7so27688037wrh.10 for ; Mon, 16 Apr 2018 09:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZhmDHQz3Kr1mT/Q6rkgItPgL6Ix/GtnrDKvGRm7c5O8=; b=2Q3i9NWsseSx4tpIEuBrISsO7YoK4FmIUY+Zh8EOkpCMrK9UZFnZm43VkBItBmx8Y8 67bmoUTPlXeBAuYttKM3PLIBzGi2m90zw/C7+ar9WgKsuMnRlq5NwzMLLrL3IbtL+Ddx TuyM/BA7VEUr3Luh2GSU9bElmNuZFTvdh9B6X3bBn328rNO1HFLLpHps5sCnEIde3KTL 9X254QoD366dNnTcKey9eHeK9ndGs0GWDWr9hrX4tfH5MiTUlOaimQC7R9xNlEE7+c/A G/CZUej/GMl/BaNBE2r4hN+IRd+QCoZpZImL+T4OYg8uKRD9nWyjXWi5XjDWQbgBfR66 mWXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZhmDHQz3Kr1mT/Q6rkgItPgL6Ix/GtnrDKvGRm7c5O8=; b=PXa1NfKgAle+vR30cqA8jA7gJSRvJPMoXH9/z8h/N92Nwtr2tCZK+MBeAfbMQQwcfB kdFxRYORWZSlpl8Y+QpJdUft1iLxAeUkj1PvPVA7yrvBWxMfEmcL1SpDs5ga7/+uSzBd EXd++kg5AhuQh3lfXk/P0PyH/MSxkcSeA3G6n/ZbXaGKWR5mSsKd+VoG5/YJ2id/oywn wuMVl7y0PDnN9ai3WyvI5HobdQUMP+MOXnxJVgpwGSyKc5pPJEiuAso/sw2LkRgX4jCX IxwLqP3mUCc3pBe75pNqmxJIc4S5OPFHoFZou1NS8IVXjubrZwNIFTJUEu+8+nIgWUeG 0Stg== X-Gm-Message-State: ALQs6tCnEJVldJ0JjMtSnWbnb23JBRhaV8NJa/TDPC6OAKYL0Ou2C2zp tIpL2ivfJRkxmCO5hGrupn1cwDpz X-Google-Smtp-Source: AIpwx481XW3MGTJ0GOMSDab1t0W9TLTcmrbrht0KjGkT60A75YHl3YKP6y6lrSyJ0WW3OBwqnr2E5Q== X-Received: by 10.28.164.2 with SMTP id n2mr2376354wme.127.1523895764679; Mon, 16 Apr 2018 09:22:44 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x70sm12794579wma.9.2018.04.16.09.22.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 09:22:44 -0700 (PDT) Date: Mon, 16 Apr 2018 18:22:30 +0200 From: Adrien Mazarguil To: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org Message-ID: <20180416150525.2817-2-adrien.mazarguil@6wind.com> References: <20180410162022.9101-1-adrien.mazarguil@6wind.com> <20180416150525.2817-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180416150525.2817-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v4 01/16] ethdev: add error types to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 16:22:45 -0000 These enable more precise reporting of objects responsible for errors. This breaks ABI compatibility for the following public functions: - rte_flow_create() - rte_flow_destroy() - rte_flow_error_set() - rte_flow_flush() - rte_flow_isolate() - rte_flow_query() - rte_flow_validate() Signed-off-by: Adrien Mazarguil Acked-by: Andrew Rybchenko --- app/test-pmd/config.c | 4 ++++ lib/librte_ether/rte_ethdev_version.map | 20 +++++++++++++------- lib/librte_ether/rte_flow.h | 4 ++++ 3 files changed, 21 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 5daa93bb3..a7645adb8 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1244,8 +1244,12 @@ port_flow_complain(struct rte_flow_error *error) [RTE_FLOW_ERROR_TYPE_ATTR_EGRESS] = "egress field", [RTE_FLOW_ERROR_TYPE_ATTR] = "attributes structure", [RTE_FLOW_ERROR_TYPE_ITEM_NUM] = "pattern length", + [RTE_FLOW_ERROR_TYPE_ITEM_SPEC] = "item specification", + [RTE_FLOW_ERROR_TYPE_ITEM_LAST] = "item specification range", + [RTE_FLOW_ERROR_TYPE_ITEM_MASK] = "item specification mask", [RTE_FLOW_ERROR_TYPE_ITEM] = "specific pattern item", [RTE_FLOW_ERROR_TYPE_ACTION_NUM] = "number of actions", + [RTE_FLOW_ERROR_TYPE_ACTION_CONF] = "action configuration", [RTE_FLOW_ERROR_TYPE_ACTION] = "specific action", }; const char *errstr; diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map index 34df6c8b5..e915e7929 100644 --- a/lib/librte_ether/rte_ethdev_version.map +++ b/lib/librte_ether/rte_ethdev_version.map @@ -127,11 +127,6 @@ DPDK_17.02 { _rte_eth_dev_reset; rte_eth_dev_fw_version_get; - rte_flow_create; - rte_flow_destroy; - rte_flow_flush; - rte_flow_query; - rte_flow_validate; } DPDK_16.07; @@ -153,7 +148,6 @@ DPDK_17.08 { _rte_eth_dev_callback_process; rte_eth_dev_adjust_nb_rx_tx_desc; rte_flow_copy; - rte_flow_isolate; rte_tm_capabilities_get; rte_tm_hierarchy_commit; rte_tm_level_capabilities_get; @@ -192,7 +186,6 @@ DPDK_17.11 { rte_eth_dev_get_sec_ctx; rte_eth_dev_pool_ops_supported; rte_eth_dev_reset; - rte_flow_error_set; } DPDK_17.08; @@ -203,6 +196,19 @@ DPDK_18.02 { } DPDK_17.11; +DPDK_18.05 { + global: + + rte_flow_create; + rte_flow_destroy; + rte_flow_error_set; + rte_flow_flush; + rte_flow_isolate; + rte_flow_query; + rte_flow_validate; + +} DPDK_18.02; + EXPERIMENTAL { global: diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index 44ae19d3b..26b95c772 100644 --- a/lib/librte_ether/rte_flow.h +++ b/lib/librte_ether/rte_flow.h @@ -1186,8 +1186,12 @@ enum rte_flow_error_type { RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, /**< Egress field. */ RTE_FLOW_ERROR_TYPE_ATTR, /**< Attributes structure. */ RTE_FLOW_ERROR_TYPE_ITEM_NUM, /**< Pattern length. */ + RTE_FLOW_ERROR_TYPE_ITEM_SPEC, /**< Item specification. */ + RTE_FLOW_ERROR_TYPE_ITEM_LAST, /**< Item specification range. */ + RTE_FLOW_ERROR_TYPE_ITEM_MASK, /**< Item specification mask. */ RTE_FLOW_ERROR_TYPE_ITEM, /**< Specific pattern item. */ RTE_FLOW_ERROR_TYPE_ACTION_NUM, /**< Number of actions. */ + RTE_FLOW_ERROR_TYPE_ACTION_CONF, /**< Action configuration. */ RTE_FLOW_ERROR_TYPE_ACTION, /**< Specific action. */ }; -- 2.11.0