From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 1CD71AAB7 for ; Mon, 16 Apr 2018 22:17:19 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8BCFF81A88A2; Mon, 16 Apr 2018 20:17:17 +0000 (UTC) Received: from localhost (ovpn-116-76.ams2.redhat.com [10.36.116.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 670812026DFD; Mon, 16 Apr 2018 20:17:16 +0000 (UTC) Date: Mon, 16 Apr 2018 22:17:15 +0200 From: Jens Freimann To: Ferruh Yigit Cc: dev@dpdk.org, ailan@redhat.com, jan.scheurich@ericsson.com, vkaplans@redhat.com, bruce.richardson@intel.com, thomas@monjalon.net, maxime.coquelin@redhat.com, konstantin.ananyev@intel.com Message-ID: <20180416201715.j7ucv4yc7ekrumv5@localhost.localdomain> References: <20180413113716.27968-1-jfreimann@redhat.com> <20180413113716.27968-3-jfreimann@redhat.com> <40abbbc6-911f-163c-a18f-2433e4cee48c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <40abbbc6-911f-163c-a18f-2433e4cee48c@intel.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 16 Apr 2018 20:17:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 16 Apr 2018 20:17:17 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 2/2] testpmd: update testpmd documentation to include noisy forwarding mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 20:17:19 -0000 On Fri, Apr 13, 2018 at 02:19:28PM +0100, Ferruh Yigit wrote: >On 4/13/2018 12:37 PM, Jens Freimann wrote: >> Signed-off-by: Jens Freimann >> --- >> doc/guides/testpmd_app_ug/run_app.rst | 27 +++++++++++++++++++++++++++ >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++++-- >> 2 files changed, 32 insertions(+), 2 deletions(-) >> >> diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst >> index 1fd53958a..0b7046bb0 100644 >> --- a/doc/guides/testpmd_app_ug/run_app.rst >> +++ b/doc/guides/testpmd_app_ug/run_app.rst >> @@ -340,6 +340,7 @@ The commandline options are: >> icmpecho >> ieee1588 >> tm >> + noisy >> >> * ``--rss-ip`` >> >> @@ -479,3 +480,29 @@ The commandline options are: >> >> Set the hexadecimal bitmask of TX queue offloads. >> The default value is 0. >> + >> +* ``--buffersize-before-sending=N`` >> + >> + Set the number of maximum elements of the FIFO queue to be created >> + for buffering packets. Only available with the noisy forwarding mode. >> + The default value is 0. >> + >> +* ``--flush-timeout=N`` >> + >> + Set the size of the FIFO queue to be created for buffering packets. >> + Only available with the noisy forwarding mode. The default value is 0. > >Some of the there parameter names are so generic when you think them in the >scope of the whole testpmd it can be confusing and hard to understand what they >are for. > >What do you think adding a prefix to all noisy neighbor related commands? Yes, I think it is a good point. Thanks for the review! regards, Jens > >> + >> +* ``--nb-rnd-read=N`` >> + >> + Set the number of reads to be done in noisy neighbour simulation memory buffer. >> + Only available with the noisy forwarding mode. The default value is 0. >> + >> +* ``--nb-rnd-write=N`` >> + >> + Set the number of writes to be done in noisy neighbour simulation memory buffer. >> + Only available with the noisy forwarding mode. The default value is 0. >> + >> +* ``--nb-rnd-write=N`` >> + >> + Set the number of r/w access to be done in noisy neighbour simulation memory buffer. >> + Only available with the noisy forwarding mode. The default value is 0. > ><...>