From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 90FE08E78 for ; Tue, 17 Apr 2018 10:57:51 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 01:57:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="38006164" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga002.fm.intel.com with SMTP; 17 Apr 2018 01:57:48 -0700 Received: by (sSMTP sendmail emulation); Tue, 17 Apr 2018 09:57:44 +0100 Date: Tue, 17 Apr 2018 09:57:44 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Fan Zhang , dev@dpdk.org, maxime.coquelin@redhat.com, shahafs@mellanox.com Message-ID: <20180417085743.GA77936@bricha3-MOBL.ger.corp.intel.com> References: <20180416140858.79994-1-roy.fan.zhang@intel.com> <8063790.J3il9MjH7d@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8063790.J3il9MjH7d@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 08:57:52 -0000 On Mon, Apr 16, 2018 at 11:42:57PM +0200, Thomas Monjalon wrote: > 16/04/2018 16:08, Fan Zhang: > > Fixes: d090c7f86a76 ("vhost/crypto: update makefile") > > > > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled. > > This patch fix this by adding checking to Makefile. > > > > Signed-off-by: Fan Zhang > > --- > > lib/librte_vhost/Makefile | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > What about meson.build? > It's not needed. Meson build does not allow you to go arbitrarily disabling libraries - exactly for this reason, to save us littering other build files with all sorts of checks for various libraries. Only those libraries which are unsupported on a particular platform need to be checked for - all core libraries are always available. I'm sure if you looked at it, we should have an awful lot more checks in our Makefiles for library disabling, not to mention the fact that EAL, mbuf, mempool libraries are possible to disable, even though doing so will result in an unbuildable mess. /Bruce