From: Fan Zhang <roy.fan.zhang@intel.com>
To: dev@dpdk.org
Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com
Subject: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.
Date: Tue, 17 Apr 2018 10:45:46 +0100 [thread overview]
Message-ID: <20180417094546.80472-1-roy.fan.zhang@intel.com> (raw)
Coverity issue: 272563
Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v2:
- using more generic strlcpy approach
examples/ip_pipeline/swq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/swq.c b/examples/ip_pipeline/swq.c
index c11bbf27e..7e54a1dbf 100644
--- a/examples/ip_pipeline/swq.c
+++ b/examples/ip_pipeline/swq.c
@@ -5,6 +5,8 @@
#include <stdlib.h>
#include <string.h>
+#include <rte_string_fns.h>
+
#include "swq.h"
static struct swq_list swq_list;
@@ -64,7 +66,7 @@ swq_create(const char *name, struct swq_params *params)
}
/* Node fill in */
- strncpy(swq->name, name, sizeof(swq->name));
+ strlcpy(swq->name, name, sizeof(swq->name));
swq->r = r;
/* Node add to list */
--
2.13.6
next reply other threads:[~2018-04-17 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 9:45 Fan Zhang [this message]
2018-04-17 11:23 ` Bruce Richardson
2018-05-08 14:29 ` Dumitrescu, Cristian
-- strict thread matches above, loose matches on Subject: below --
2018-04-17 13:28 [dpdk-dev] [PATCH] " Jasvinder Singh
2018-04-17 16:39 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
2018-05-08 14:29 ` Dumitrescu, Cristian
2018-04-16 11:02 [dpdk-dev] [PATCH] " Fan Zhang
2018-04-17 9:52 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2018-04-17 11:18 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417094546.80472-1-roy.fan.zhang@intel.com \
--to=roy.fan.zhang@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).