From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: jerin.jacob@caviumnetworks.com, erik.g.carrillo@intel.com
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH] eventdev: fix icc build
Date: Tue, 17 Apr 2018 14:13:42 +0100 [thread overview]
Message-ID: <20180417131342.32027-1-pablo.de.lara.guarch@intel.com> (raw)
ICC complains about variable being used before its value is set.
Since the variable is only assigned in the for loop,
its declaration is moved inside and is initialized.
lib/librte_eventdev/rte_event_timer_adapter.c(708): error #592:
variable "ret" is used before its value is set
RTE_SET_USED(ret);
Fixes: 6750b21bd6af ("eventdev: add default software timer adapter")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_eventdev/rte_event_timer_adapter.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
index 6eba6b44d..9a863f5cb 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter.c
+++ b/lib/librte_eventdev/rte_event_timer_adapter.c
@@ -695,7 +695,7 @@ check_destination_event_queue(struct rte_event_timer *evtim,
static int
sw_event_timer_adapter_service_func(void *arg)
{
- int ret, i, num_msgs;
+ int i, num_msgs;
uint64_t cycles, opaque;
uint16_t nb_evs_flushed = 0;
uint16_t nb_evs_invalid = 0;
@@ -705,8 +705,6 @@ sw_event_timer_adapter_service_func(void *arg)
struct rte_timer *tim = NULL;
struct msg *msg, *msgs[NB_OBJS];
- RTE_SET_USED(ret);
-
adapter = arg;
sw_data = adapter->data->adapter_priv;
@@ -720,6 +718,10 @@ sw_event_timer_adapter_service_func(void *arg)
(void **)msgs, NB_OBJS, NULL);
for (i = 0; i < num_msgs; i++) {
+ int ret = 0;
+
+ RTE_SET_USED(ret);
+
msg = msgs[i];
evtim = msg->evtim;
--
2.14.3
next reply other threads:[~2018-04-17 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 13:13 Pablo de Lara [this message]
2018-04-17 13:28 ` Ferruh Yigit
2018-04-17 14:13 ` Carrillo, Erik G
2018-04-19 11:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417131342.32027-1-pablo.de.lara.guarch@intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).