From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EAA6AAAB3 for ; Tue, 17 Apr 2018 16:57:39 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 07:57:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="46865765" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga004.fm.intel.com with SMTP; 17 Apr 2018 07:57:36 -0700 Received: by (sSMTP sendmail emulation); Tue, 17 Apr 2018 15:57:35 +0100 Date: Tue, 17 Apr 2018 15:57:34 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Junjie Chen , konstantin.ananyev@intel.com, dev@dpdk.org Message-ID: <20180417145734.GA89464@bricha3-MOBL.ger.corp.intel.com> References: <20180412051636.240746-1-junjie.j.chen@intel.com> <1852475.4XxgDvW1hG@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1852475.4XxgDvW1hG@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 14:57:40 -0000 On Tue, Apr 17, 2018 at 03:22:06PM +0200, Thomas Monjalon wrote: > 12/04/2018 07:16, Junjie Chen: > > From: "Chen, Junjie" > > > > Sometimes gcc does not inline the function despite keyword *inline*, > > we obeserve rte_movX is not inline when doing performance profiling, > > so use *always_inline* keyword to force gcc to inline the function. > > > > Signed-off-by: Chen, Junjie > > --- > > .../common/include/arch/x86/rte_memcpy.h | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > The title should start with "eal/x86:" > Something like that: > eal/x86: force inlining of memcpy sub-functions > > Bruce, Konstantin, any review of the content/optimization? > No objection here. Acked-by: Bruce Richardson