From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 612EFAAB3 for ; Tue, 17 Apr 2018 16:59:25 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 07:59:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="46866426" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga004.fm.intel.com with SMTP; 17 Apr 2018 07:59:21 -0700 Received: by (sSMTP sendmail emulation); Tue, 17 Apr 2018 15:59:20 +0100 Date: Tue, 17 Apr 2018 15:59:20 +0100 From: Bruce Richardson To: Jasvinder Singh Cc: dev@dpdk.org, cristian.dumitrescu@intel.com Message-ID: <20180417145920.GB89464@bricha3-MOBL.ger.corp.intel.com> References: <20180417131719.146374-1-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417131719.146374-1-jasvinder.singh@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 14:59:25 -0000 On Tue, Apr 17, 2018 at 02:17:19PM +0100, Jasvinder Singh wrote: > The destination string may not have a null termination if > the source string's length is equal to the sizeof(tap->name). > > Fix by replacing strncpy with strlcpy that guarantees NULL-termination. > > Coverty issue: 272603 > Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object") > > Signed-off-by: Jasvinder Singh > --- Acked-by: Bruce Richardson