From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id B3D7F7EC8 for ; Wed, 18 Apr 2018 10:12:21 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id h3-v6so2234389wrh.5 for ; Wed, 18 Apr 2018 01:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g/AAViExgXMyWs6/ceN9gG5UrTsjbe7+CkfZry6eRBk=; b=EzExWx1ppaavZe2V0AVYElhRhHPjECjGFqMacbdY9oVFcwKfFY3iXyzpPC8InGlDKb K8sF7EDNr/63N89gjx9kj35JO//uf0zITsg1nqUQTcieUniAAO2GOjyO4xqPGV597l+b nEUvin6z33jCBkN7cTI5eD98gYIQ3WSKX0/T+CsbZ7tpMDm52+tG0w5V2Ojq7y3NM20M hgjZjZPWyqc/GCRxPKMBLXwrUUMgm7DX80G+d2Zplq9m90Fa0FMI7SIE/qd6fgyhzbno /m9VBzAn1KSDO+uCdXimPcn5Rt04A4bjGWY5TTIDASmQFiB7xMChXpGs/mYglqenghOn dmNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g/AAViExgXMyWs6/ceN9gG5UrTsjbe7+CkfZry6eRBk=; b=bcjsrmuoJ6FK1DZxLVeTTkzBJMWqIkIF+srE0KqZVom1I9x0i3y3xPqS7xIeq1euhs i3bPiYlBFc3zBKJS1cySKsofS+eFUfH8D5uA/v3VSs3d5JrLEoav72aDb2xnd3QOFIWt q/dXvPNSST4VKlIxPfc2vrVpeNgOWlXf+YeqJJPLNvtyxW9hgNrpDBndUjSdI+b5aWD8 fGqjPs/KjEuFOZY3rv4HoAhTvgr2QkLIbeTv79kAKRVjqKOTpWVhKsC+a8UQtjr/yocV m2B2t6WBlfTB/gIYItcXFAt1TKfq6lfD2Yf+ZrIgAsrrnR4TcYAadbeG8VRLxpcffh4W Tv0A== X-Gm-Message-State: ALQs6tDo3+3MjLii/ghIqwEFzuOO7OWqQ9ytZQlLUJ8p07vuR5zzRcYS pWsYgWVTjUaOv/djM0mYZpilNS8Q X-Google-Smtp-Source: AIpwx49OXxzYyHsh9ITcx8teNoXsMMdrI6czG/B2P6C9HRx1xKVezQGqntj+AxP9ifkcg+D2dEwkAw== X-Received: by 10.28.229.212 with SMTP id c203mr1023227wmh.2.1524039141533; Wed, 18 Apr 2018 01:12:21 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u37-v6sm1168597wrb.53.2018.04.18.01.12.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Apr 2018 01:12:20 -0700 (PDT) Date: Wed, 18 Apr 2018 10:12:07 +0200 From: Adrien Mazarguil To: Thomas Monjalon Cc: Xueming Li , dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Nelio Laranjeiro , Shahaf Shuler , Olivier Matz Message-ID: <20180418081207.GL4957@6wind.com> References: <20180417150404.160990-1-xuemingl@mellanox.com> <20180417150404.160990-3-xuemingl@mellanox.com> <1541697.oJ8yBXImSN@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1541697.oJ8yBXImSN@xps> Subject: Re: [dpdk-dev] [PATCH v5 2/4] ethdev: introduce new tunnel VXLAN-GPE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 08:12:21 -0000 On Tue, Apr 17, 2018 at 10:56:52PM +0200, Thomas Monjalon wrote: > 17/04/2018 17:04, Xueming Li: > > +struct rte_flow_item_vxlan_gpe { > > + uint8_t flags; /**< Normally 0x0c (I and P flags). */ > > + uint8_t rsvd0[2]; /**< Reserved, normally 0x0000. */ > > + uint8_t protocol; /**< Protocol type. */ > > + uint8_t vni[3]; /**< VXLAN identifier. */ > > + uint8_t rsvd1; /**< Reserved, normally 0x00. */ > > +}; > > These comments are not aligned. Regarding this part: it's OK for rte_flow.h since it's the style used in that file. Besides I favor it as it circumvents the entire alignemnt issue altogether for subsequent contributions. > > +struct vxlan_gpe_hdr { > > + uint8_t vx_flags; /**< flag (8). */ > > + uint8_t reserved[2]; /**< Reserved (16). */ > > + uint8_t proto; /**< next-protocol (8). */ > > + uint32_t vx_vni; /**< VNI (24) + Reserved (8). */ > > +} __attribute__((__packed__)); > > Alignment must be done with spaces. > > -- Adrien Mazarguil 6WIND