From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 8BF857CB9 for ; Wed, 18 Apr 2018 10:41:47 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id u11-v6so2446175wri.12 for ; Wed, 18 Apr 2018 01:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DWLIkYj7uHK8v1DXcHq71qqNjr4jCQ3kh0Q4hScAWq4=; b=oqsjClFOsWei3nz+HegmD1DiSY/8/Afrxz+ORWJWjDuUQnwsoIMpYrnDuwbBxckCB1 QdOC0fPE4JI0tFkIvPO+WPBnmESsP2mEPxU8hHZG+vU30NR675x50ObJLc8/vm7JKVmM hSisffglu1zZKLkLO/idVLbLaH+59IMnH7WcKVcZm+hJgrlXTMDkKiAkthZRZ4BeF0oD gH99JTemZJW+jsVPR/koMgYXRO9g1Tpekx/VNPgahvkJBq/YBfkqRxkIDSmajhDeYvno K8PlCzM3XbZUsKCe+D7jHccO9144SeRu6u1UW0RSRyL+GjMM2tSasW5rPy7OUdy6Tnfa +5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DWLIkYj7uHK8v1DXcHq71qqNjr4jCQ3kh0Q4hScAWq4=; b=MnT/54a8Qls3yj6dRDxK3DZOB85Ee1pB+63OXjMfyPlfUp3FHoobwfHYH5aoyomlBY GslPfLVTUJWvUkXYSoKS3buR7NnLH+okFWpJS4sAJkQHJsQvW24RsItTWhzh2nAEWkIw 7zvkyaWsCrKD6Jx8EdbuSwDRT8+SFy/eCwnSjcZh3SmZEMc6zTEPhYWMvaxX4Gg+9fsV l4D/t4QB2XHcf9zz1gcNFxM7IMoqGNpgw02qc6cbtlunFNViMm1xZ/K4YOCLvuhEphCP a52YgGoq4UAg99PGNh8Pf2tY0OC8jhHjhOXqmG6wEU45XAhVenvuYmj7tlus+aXm8eVK Hibg== X-Gm-Message-State: ALQs6tDEnBfrDkbrKfr/Qt4IVLjrOSWPxZzf7NdUEFS3zrTZFvf52kEg 0dXTVlfO7MF6uhrd8jIPT1eRpCgg X-Google-Smtp-Source: AIpwx48+vyNHrNoFLLnOcmOxpZtN2gou5GaRauDdY+lEMDgsYCZ1purfUSyFRB1jcc7WGj6ktYawJA== X-Received: by 2002:adf:c104:: with SMTP id r4-v6mr955225wre.84.1524040907292; Wed, 18 Apr 2018 01:41:47 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v6-v6sm621146wrd.54.2018.04.18.01.41.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Apr 2018 01:41:45 -0700 (PDT) Date: Wed, 18 Apr 2018 10:41:31 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20180418084131.GM4957@6wind.com> References: <20180410162022.9101-1-adrien.mazarguil@6wind.com> <20180416150525.2817-1-adrien.mazarguil@6wind.com> <20180416150525.2817-2-adrien.mazarguil@6wind.com> <0d8bec2d-b1fc-a772-83de-9b0d641ec535@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d8bec2d-b1fc-a772-83de-9b0d641ec535@intel.com> Subject: Re: [dpdk-dev] [PATCH v4 01/16] ethdev: add error types to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 08:41:47 -0000 On Tue, Apr 17, 2018 at 08:37:31PM +0100, Ferruh Yigit wrote: > On 4/16/2018 5:22 PM, Adrien Mazarguil wrote: > > These enable more precise reporting of objects responsible for errors. > > > > This breaks ABI compatibility for the following public functions: > > > > - rte_flow_create() > > - rte_flow_destroy() > > - rte_flow_error_set() > > - rte_flow_flush() > > - rte_flow_isolate() > > - rte_flow_query() > > - rte_flow_validate() > > Is there a deprecation notice for this API break? A notice covering the main changes in this series (most patches have an ABI impact) was sent but not included [1]. This particular patch rides on the announced ABI breakage in order to add a relatively minor feature while there. This ABI change was implicitly needed by upcoming work for 18.05 (Xueming's RSS stuff [2][3], Declan's TEP [4], the rest is summarized by a RFC [5]) due to the necessary changes of behavior in flow rules. Note that Xueming's deprecation notice [3] alone would have triggered such an ABI change because struct rte_flow_action_rss wouldn't have been binary compatible if struct rte_eth_rss_conf was updated. This change would have propagated back to rte_flow functions manipulating them. [1] "doc: announce API changes for flow rules" http://dpdk.org/ml/archives/dev/2018-February/090988.html [2] "MLX5 tunnel Rx offloading" http://dpdk.org/ml/archives/dev/2018-February/091461.html [3] "doc: annouce ABI change for RSS configuraiton structure" http://dpdk.org/ml/archives/dev/2018-February/090127.html [4] "tunnel endpoint hw acceleration enablement" http://dpdk.org/ml/archives/dev/2017-December/084676.html [5] "Switch device offload with DPDK" http://dpdk.org/ml/archives/dev/2018-March/092513.html > > Signed-off-by: Adrien Mazarguil > > Acked-by: Andrew Rybchenko > > <...> > -- Adrien Mazarguil 6WIND