From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id B984E5F25 for ; Wed, 18 Apr 2018 18:02:03 +0200 (CEST) Received: by mail-pg0-f66.google.com with SMTP id z21so1067239pgv.12 for ; Wed, 18 Apr 2018 09:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jWjViwuM2nWIjbXwfcse+ahNsqUpmeMLYbyiV5arsLM=; b=EUTqSYlHnEJcGmef4vZQZKZS9HcJdLKbirlfCKD1Mki7GgrXjDaaZYZLr9llFhQsjI nDZCo5kBk0YOCPQRTZQX/yHagz7k1w60BXZ/AYhtlbsQfWUEB1FD0zpUlqctvmH8GNIy eGAUypYH+dzACDiqHidrR0gyui8ZKm2eLHPuVTleX9p2W3S45lLMoaXMifuKz9NcY2eM b25Yk5++oL8tgUer872wdL454sasop7VaftLCwD+job8gDQQ4Edz1nLrZSJ2J+wgEFZX U8VRo1kpjTrB+ajnJjQB6yLzMVcHQdtr9WT+nVmWUyacBHkq2jrIGpNS6k604mKV9koY e/mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jWjViwuM2nWIjbXwfcse+ahNsqUpmeMLYbyiV5arsLM=; b=naU3c3zzfqFxAKpPzySoN6DGbYpwyXvF/bIJ5H28ld4OvY3SaVDSN1kRM8q9EgpfRF vsy7Msj4GguQM9x0YsmwDE1WVbRDzptwuucQTM0AhVVBlQNT5ScXK8eKKaI+v/oX6Pv6 vxyDM2x/7fCmTGMyr21hvfQbs8QWtg5mvEB1isYdvLfZDkgCuI1qpB58O6/ikAT7cT3/ jKpr1L7aIfaLqKxI9KRgnfA9sEBLE/fZvsjXKTHHJRoJ+W6D3qhL3fBOvXVf+UzCf4m4 BBgRILGUuauGat1ks6h1eVX6K9lAHo8V4H6RO7YRDc2dqUG7Sll/uzF6Rsy8Kj2586pZ PCow== X-Gm-Message-State: ALQs6tAJFFqB2zwYa8AsLwGydrLsKgOl07he6ZXSPDTFv5DTFO4EUFSA 3HoU/q4tTfpZu+LiQ9F3WzZVpA== X-Google-Smtp-Source: AIpwx48HGXY81qSxY5buhAATOZchk30yGdUpWWj0nvyM5ZQMdIRZJiFhjCke3Lo5EVcBVA37Rogiug== X-Received: by 10.101.77.67 with SMTP id j3mr2225625pgt.210.1524067321687; Wed, 18 Apr 2018 09:02:01 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id e73sm5451882pfj.186.2018.04.18.09.02.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Apr 2018 09:02:01 -0700 (PDT) Date: Wed, 18 Apr 2018 09:01:59 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20180418090159.1969f5b3@xeon-e3> In-Reply-To: References: <20180417215324.8576-1-sthemmin@microsoft.com> <20180417215324.8576-2-sthemmin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/4] bus/vmbus: add hyper-v virtual bus support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 16:02:04 -0000 On Wed, 18 Apr 2018 14:16:56 +0100 Ferruh Yigit wrote: > On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > > From: Stephen Hemminger > > > > This patch adds support for an additional bus type Virtual Machine BUS > > (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 > > and Azure. Most of this code was extracted from FreeBSD and some of > > this is from earlier code donated by Brocade. > > > > Only Linux is supported at present, but the code is split > > to allow future FreeBSD and Windows support. > > > > The bus support relies on the uio_hv_generic driver from Linux > > kernel 4.16. Multiple queue support requires additional sysfs > > interfaces which is in kernel 5.0 (a.k.a 4.17). > > > > Signed-off-by: Stephen Hemminger > > --- > > MAINTAINERS | 3 + > > config/common_base | 5 + > > config/common_linuxapp | 4 + > > drivers/bus/Makefile | 1 + > > drivers/bus/vmbus/Makefile | 36 ++ > > drivers/bus/vmbus/linux/Makefile | 3 + > > drivers/bus/vmbus/linux/vmbus_bus.c | 355 +++++++++++++++++ > > drivers/bus/vmbus/linux/vmbus_uio.c | 381 ++++++++++++++++++ > > drivers/bus/vmbus/private.h | 132 +++++++ > > drivers/bus/vmbus/rte_bus_vmbus.h | 400 +++++++++++++++++++ > > drivers/bus/vmbus/rte_bus_vmbus_version.map | 28 ++ > > drivers/bus/vmbus/rte_vmbus_reg.h | 344 +++++++++++++++++ > > drivers/bus/vmbus/vmbus_bufring.c | 241 ++++++++++++ > > drivers/bus/vmbus/vmbus_channel.c | 405 ++++++++++++++++++++ > > drivers/bus/vmbus/vmbus_common.c | 286 ++++++++++++++ > > drivers/bus/vmbus/vmbus_common_uio.c | 232 +++++++++++ > > mk/rte.app.mk | 1 + > > <...> > > > @@ -381,6 +381,9 @@ VDEV bus driver > > M: Jianfeng Tan > > F: drivers/bus/vdev/ > > > > +VMBUS bus driver > > +M: Stephen Hemminger > > +F: drivers/bus/vmbus/ > > We have methods to mark APIs as experimental but not for drivers, we have put "- > EXPERIMENTAL" suffix in MAINTAINER file before, same thing can be done here. Ok, will add this to v4 > > > @@ -37,3 +37,7 @@ CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y > > CONFIG_RTE_LIBRTE_DPAA2_PMD=y > > CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y > > CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y > > + > > +# Hyper-V Virtual Machine bus and drivers > > +CONFIG_RTE_LIBRTE_VMBUS=y > > We tend to disable the component that has external dependency, because of uuid > library dependency I believe vmbus should be disabled by default. Ok. But libuuid is really trivial. > > +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > > +LDLIBS += -lrte_ethdev -lrte_vmbus -luuid > > -lrte_vmbus is causing build error for shared build, there is no library like > that, looks like can be dropped. Will check, haven't modified that in a while. > > @@ -0,0 +1,28 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause */ > > +EXPERIMENTAL { > > + global: > > + > > + rte_vmbus_chan_close; > > + rte_vmbus_chan_open; > > + rte_vmbus_chan_recv; > > + rte_vmbus_chan_recv_raw; > > + rte_vmbus_chan_rx_empty; > > + rte_vmbus_chan_send; > > + rte_vmbus_chan_send_sglist; > > + rte_vmbus_chan_signal_tx; > > + rte_vmbus_irq_mask; > > + rte_vmbus_irq_read; > > + rte_vmbus_irq_unmask; > > + rte_vmbus_map_device; > > + rte_vmbus_max_channels; > > + rte_vmbus_probe; > > + rte_vmbus_probe_one; > > + rte_vmbus_register; > > + rte_vmbus_scan; > > + rte_vmbus_sub_channel_index; > > + rte_vmbus_subchan_open; > > + rte_vmbus_unmap_device; > > + rte_vmbus_unregister; > > + > > + local: *; > > +}; > > Just to confirm, these APIs are for bus drivers, not for applications, right? If > so we already don't guarantee comptiblity in this level, perhaps adding > __experimental flag to these APIs is overkill but no harm. Yes, these are internal bus api's. I will take off experimental from the bus part. It makes life simpler to have it gone.