From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 742845F4F
 for <dev@dpdk.org>; Wed, 18 Apr 2018 18:04:23 +0200 (CEST)
Received: by mail-pf0-f171.google.com with SMTP id y69so1132593pfb.5
 for <dev@dpdk.org>; Wed, 18 Apr 2018 09:04:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=L2rhHy0tkB8ltxwPorJTGfIGAfH+3Vu7zm+D6LimsrI=;
 b=RrDOIRJFUmRrJ1TgDkJ9mgih0BpwD5hjozpEUc5fmnEBN/GfX8sQO33dU0wZHcLcyC
 TgzdPOLMZ8+wLH1LBjJXkubTSwpey+Y3k1+c3IASghOU8h2aTDr2LGk5eLnviRGKr0kU
 +j396NN0rL7rY4ZBQRV1NrrJZdAl3QGSv1EJoAxETAjkwre8hVt23SezW5ejh2LzwSb5
 O9Pz8+TdmVNMLIoIFVmezqc46gycMZOUNBjCit1MQpmOKzHya8jycGIfYNpyZvhCWTbD
 gjF2UBrVGpF5e+aMdNut5kCUKh/3bYdm7FPM6JrFMuQ5BZYnWaa5YOZWfDH7Y+x9XiN3
 nvRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=L2rhHy0tkB8ltxwPorJTGfIGAfH+3Vu7zm+D6LimsrI=;
 b=LffjV3r8cn2iJ+OwycrASi6p6O4V9DuFyH1L81UJpXhQTVRAy+UflpXHnO4GFcw2yH
 lvCMdaKdy1IUH6Upxf/zV5T/7+pPHwgFrckLNWQ+04J4OgkC2/P81oOCGhQfXNo0KrYm
 dxQ31f4bEA/df3HAZECShH2MQGh5yiRzUMLk9bzEguDzMJLzHljCYEDZyQydq+9k2fDJ
 sbeU901+vTEUsfIgfXjLtH9aIeOOpFo01DGsBUGIkji4RTw+w2ammbCCsCbY+PJ94hm5
 uSiA8IauXXF6d25+DjG5/dsQPaepNEEWmmvWTwIJ4BaKjf9z02On6xn68KTTp2XNZrQc
 Leuw==
X-Gm-Message-State: ALQs6tAc2CpZdWNJsQEyl6UJ4K1kHclGeaRUQnIn+p7xJHbDvM/FYlct
 1or3fcRHzGSkfIq3MHprxBRhTw==
X-Google-Smtp-Source: AIpwx4/sfglPS8pypRiopv+eSCwKs5VcVrnVw7RCvkoWZhIVHLNAEMXyFqBpQl8m6KNoPDe73vORng==
X-Received: by 10.167.128.81 with SMTP id y17mr2460463pfm.194.1524067462574;
 Wed, 18 Apr 2018 09:04:22 -0700 (PDT)
Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95])
 by smtp.gmail.com with ESMTPSA id f19sm4493012pfd.19.2018.04.18.09.04.22
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 18 Apr 2018 09:04:22 -0700 (PDT)
Date: Wed, 18 Apr 2018 09:04:20 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Message-ID: <20180418090420.225b6651@xeon-e3>
In-Reply-To: <438086f5-76f4-3c72-5c2f-b54577d12af2@intel.com>
References: <20180417215324.8576-1-sthemmin@microsoft.com>
 <20180417215324.8576-3-sthemmin@microsoft.com>
 <438086f5-76f4-3c72-5c2f-b54577d12af2@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc
 network device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Apr 2018 16:04:23 -0000

 
> > +/* XXX Why is this not generic in RTE? */
> > +static int
> > +hn_dev_atomic_write_link_status(struct rte_eth_dev *dev,
> > +		struct rte_eth_link *link)
> > +{  
> 
> It is indeed generic now thanks to you :)
> Can you switch to your generic functions?

Will change in v4. This driver has been developed on older
source predating this.