* [dpdk-dev] [PATCH] net/i40e:fix checking offloading fail for Tx
@ 2018-04-19 6:39 Yanglong Wu
2018-04-27 1:41 ` [dpdk-dev] [PATCH v2] net/i40e: fix " Yanglong Wu
2018-04-27 8:14 ` Yanglong Wu
0 siblings, 2 replies; 4+ messages in thread
From: Yanglong Wu @ 2018-04-19 6:39 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, wei.dai, Yanglong Wu
Missing "return -ENOTSUP" will alays leads to
illegal offload passing through offload checking.
Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index bc660596b..2ce930827 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
" or supported offloads 0x%" PRIx64,
(void *)dev, tx_conf->offloads,
dev->data->dev_conf.txmode.offloads,
- dev_info.tx_offload_capa); }
+ dev_info.tx_offload_capa);
+ return -ENOTSUP;
+ }
if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx
2018-04-19 6:39 [dpdk-dev] [PATCH] net/i40e:fix checking offloading fail for Tx Yanglong Wu
@ 2018-04-27 1:41 ` Yanglong Wu
2018-04-27 8:14 ` Yanglong Wu
1 sibling, 0 replies; 4+ messages in thread
From: Yanglong Wu @ 2018-04-27 1:41 UTC (permalink / raw)
To: dev; +Cc: helin.zhang, qi.z.zhang, wei.dai, Yanglong Wu
Missing "return -ENOTSUP" will alays leads to
illegal offload passing through offload checking.
Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
rework fix line
---
drivers/net/i40e/i40e_rxtx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index bc660596b..2ce930827 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
" or supported offloads 0x%" PRIx64,
(void *)dev, tx_conf->offloads,
dev->data->dev_conf.txmode.offloads,
- dev_info.tx_offload_capa); }
+ dev_info.tx_offload_capa);
+ return -ENOTSUP;
+ }
if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx
2018-04-19 6:39 [dpdk-dev] [PATCH] net/i40e:fix checking offloading fail for Tx Yanglong Wu
2018-04-27 1:41 ` [dpdk-dev] [PATCH v2] net/i40e: fix " Yanglong Wu
@ 2018-04-27 8:14 ` Yanglong Wu
2018-04-27 8:40 ` Zhang, Helin
1 sibling, 1 reply; 4+ messages in thread
From: Yanglong Wu @ 2018-04-27 8:14 UTC (permalink / raw)
To: dev; +Cc: helin.zhang, qi.z.zhang, wei.dai, Yanglong Wu
Missing "return -ENOTSUP" will alays leads to
illegal offload passing through offload checking.
Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
rework fix line
---
drivers/net/i40e/i40e_rxtx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index bc660596b..2ce930827 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
" or supported offloads 0x%" PRIx64,
(void *)dev, tx_conf->offloads,
dev->data->dev_conf.txmode.offloads,
- dev_info.tx_offload_capa); }
+ dev_info.tx_offload_capa);
+ return -ENOTSUP;
+ }
if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/i40e: fix checking offloading fail for Tx
2018-04-27 8:14 ` Yanglong Wu
@ 2018-04-27 8:40 ` Zhang, Helin
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Helin @ 2018-04-27 8:40 UTC (permalink / raw)
To: Wu, Yanglong, dev; +Cc: Zhang, Qi Z, Dai, Wei
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Friday, April 27, 2018 4:14 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Zhang, Qi Z; Dai, Wei; Wu, Yanglong
> Subject: [PATCH v2] net/i40e: fix checking offloading fail for Tx
>
> Missing "return -ENOTSUP" will alays leads to illegal offload passing through
> offload checking.
>
> Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-27 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 6:39 [dpdk-dev] [PATCH] net/i40e:fix checking offloading fail for Tx Yanglong Wu
2018-04-27 1:41 ` [dpdk-dev] [PATCH v2] net/i40e: fix " Yanglong Wu
2018-04-27 8:14 ` Yanglong Wu
2018-04-27 8:40 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).