From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id BBB027F70 for ; Thu, 19 Apr 2018 10:55:35 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id q5-v6so6628023lff.12 for ; Thu, 19 Apr 2018 01:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=G6mffUezYHF0CdJ+x9m2yavvWbCNr45W07Jhy7kW01o=; b=wVoA3SJO13FWEerIFHfppokPKaRD5xJfrUfhn0kQOmo5mDpSq59qc8EmEp0II2YcFw Liipr9Fp/tbNpG3D2tNI5+ZqDdKaFXYsmlFh5iu161yQeNLpK7C2S1uDPOfL6AGXakwG 9DwivWRztqkPsdAGUiZCMosZIX/7mf3cKfFyy9UVcpFj0Afj03aEGVKT9/G8p5E8HRS+ tbP6UIjLyNnGj42o1ItVkB9dfJjeGD1jNQcUR2703ipsS9ZGb+Q7Ku1yyZ8o6jSMQ5TA nrVJiUEZODSzAuIPStoiS6wFzmMiAYukTUTcjdTyKhcpPr/CAL7AXldtfESjRAO9k66e Cfkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=G6mffUezYHF0CdJ+x9m2yavvWbCNr45W07Jhy7kW01o=; b=MWTqHjpth49jUToLRI9sZs3934VJuyr0R7OOCutPMXmAwFxcgedSL5OhsOByoEYd+1 CVj9Mvxd7fpokto/m09B9Qxq6KGEbrHbh9A8fbB9TpMsVZTEWNlRfkdKIlYfTFhIxzlu qy3JpZK5CHMKI5poAR+JYM6TuMgVygZZmeNdtbul74D5BTlZKkh55nv+xaoioHlSauQO rdxqpZIZMvyltq/TqGjt9oRO3wxg6dij5agq9TiG67bAm44Vb3Y+ddN7rL4hvuhdyyrW b3S9mWlZWzhQdS40KkkGnGXCWZjnhW2cY7/max4K9BTZytt7972OgrM1pMJ3YTtfyBwB fk8w== X-Gm-Message-State: ALQs6tDD1lOiBjC/0lFMeSiMUYXeH8OMkD68A92Q54ahhjO6dO83Ep33 cVSwwrIUtB87vWXJj8yUnignSA== X-Google-Smtp-Source: AIpwx4/YFKVBKAlfPqA7MjxAwm4ml1nuRYm3FYEtDy5A083dUToc73A34FVdmBJ5lMCfi5vPbdsSow== X-Received: by 10.46.154.71 with SMTP id k7mr3545350ljj.42.1524128135331; Thu, 19 Apr 2018 01:55:35 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id 22sm506891ljv.45.2018.04.19.01.55.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 01:55:34 -0700 (PDT) Date: Thu, 19 Apr 2018 10:55:33 +0200 From: Tomasz Duszynski To: Bruce Richardson Cc: Tomasz Duszynski , dev@dpdk.org, jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com, jianbo.liu@arm.com, pablo.de.lara.guarch@intel.com Message-ID: <20180419085533.GA8060@sh> References: <1523447107-13324-1-git-send-email-tdu@semihalf.com> <20180413161219.GB37024@bricha3-MOBL.ger.corp.intel.com> <20180418150229.GA127664@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20180418150229.GA127664@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 0/2] add MRVL MVPP2 PMD to meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 08:55:35 -0000 On Wed, Apr 18, 2018 at 04:02:30PM +0100, Bruce Richardson wrote: > On Fri, Apr 13, 2018 at 05:12:19PM +0100, Bruce Richardson wrote: > > On Wed, Apr 11, 2018 at 01:45:05PM +0200, Tomasz Duszynski wrote: > > > This patchseries adds MRVL MVPP2 PMD to meson build system. > > > > > > Tomasz Duszynski (2): > > > net/mvpp2: rename the version file to standard > > > net/mvpp2: add meson build file > > > > > > > The patches look ok to me as far as the meson code is concerned, but I = have > > no way to test compilation etc. It doesn't cause issues with other x86 = or > > arm builds though, so: > > > > Series Acked-by: Bruce Richardson > > +Pablo, who is looking at the crypto driver which is similar. > > I've just realised at this stage - while looking at something similar with > the turbo_sw baseband driver - that the use of environmental variables is > probably going to cause us problems down the line here. In the case of > cross-compilation, the meson build is going to pull the environment > variable of the host, and use that, even in cases where there is no > cross-compile library available. > > I think that for cases like this, using a build option is a better > solution. It explicitly can be set for each independent build, avoiding t= he > cross-build issues I refer to, and also prevents us having issues with > changing the path in the environment and meson not recognising the change > (environment variables are not tracked for reconfigure, unlike options). > > So, would you be ok with changing this to take the MUSDK path from a meson > option rather than the environment? > > /Bruce I am okay with the proposed change. As for crypto patch I'll prepare v2. -- - Tomasz Duszy=C5=84ski