From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7C7DECFA8 for ; Thu, 19 Apr 2018 14:05:17 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 05:05:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,469,1517904000"; d="scan'208";a="221675764" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga005.fm.intel.com with SMTP; 19 Apr 2018 05:05:13 -0700 Received: by (sSMTP sendmail emulation); Thu, 19 Apr 2018 13:05:12 +0100 Date: Thu, 19 Apr 2018 13:05:11 +0100 From: Bruce Richardson To: Tomasz Duszynski Cc: dev@dpdk.org, dima@marvell.com, nsamsono@marvell.com Message-ID: <20180419120511.GA11352@bricha3-MOBL.ger.corp.intel.com> References: <1524131138-3204-1-git-send-email-tdu@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1524131138-3204-1-git-send-email-tdu@semihalf.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/mvpp2: get MUSDK library path from a meson option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 12:05:17 -0000 On Thu, Apr 19, 2018 at 11:45:38AM +0200, Tomasz Duszynski wrote: > Since not cluttering environment and keeping all relevant > settings local to the cross build is reasonable get > MUSDK library installation path from a meson option. > > Signed-off-by: Tomasz Duszynski > --- > drivers/net/mvpp2/meson.build | 2 +- > meson_options.txt | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mvpp2/meson.build b/drivers/net/mvpp2/meson.build > index 6ea13ee..e139889 100644 > --- a/drivers/net/mvpp2/meson.build > +++ b/drivers/net/mvpp2/meson.build > @@ -3,7 +3,7 @@ > # Copyright(c) 2018 Semihalf. > # All rights reserved. > > -path = run_command('printenv', 'LIBMUSDK_PATH').stdout().strip() > +path = get_option('lib_musdk_dir') > lib_dir = path + '/lib' > inc_dir = path + '/include' > > diff --git a/meson_options.txt b/meson_options.txt > index 1a674aa..c843278 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -8,6 +8,8 @@ option('include_subdir_arch', type: 'string', value: '', > description: 'subdirectory where to install arch-dependent headers') > option('kernel_dir', type: 'string', value: '', > description: 'path to the kernel for building kernel modules') > +option('lib_musdk_dir', type: 'string', value: '', > + description: 'path to the MUSDK library installation directory') > option('machine', type: 'string', value: 'native', > description: 'set the target machine type') > option('max_lcores', type: 'string', value: '128', > -- > 2.7.4 Looks good. Are you ok with me just squashing this into the original commit? /Bruce Acked-by: Bruce Richardson