From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id D3609CFA8 for ; Thu, 19 Apr 2018 14:06:13 +0200 (CEST) Received: by mail-lf0-f66.google.com with SMTP id r125-v6so456789lfe.2 for ; Thu, 19 Apr 2018 05:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=1+ZoN8KtRK5WeaRFdWHDec8nDp4P5sNhZqE8CXunJjc=; b=cIAHrr2Yqjv3nMBUG47+wgTXhe7ixM9BFCDI51anqj1tbANO20utqaEU78WGEqUBsB atreZbuVju4M3DSbHmCl0GU4qWcjytNXL6TjrByEnLiboB8h77TOTwRDdQSWA3AcVleu OU7nOW0tMLmPIPwP0cWbhlMnIKz1hseni2ePHHdj8api2pHz/3GiyHeVMeckCBkajlWw 2tNcJg7c9hD2+kaYzD5FExp5lzMpicbnv6baMZI/+4hdLco2xYiPmPpYvCXGLeG8uvUT 0fqRURBx6nJuGvxZKADcDYvOEI8b0WyrD53MChKv3G+lDzfIOIBV8Kf5JQz2Rnp1auym a06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1+ZoN8KtRK5WeaRFdWHDec8nDp4P5sNhZqE8CXunJjc=; b=HIGFBGk7uSKp+tnwpTI0HGETffWzyyH7PgfiCvxTZIRhPOZBCH+XXBLlRihjmwThyN 414PBfi6KnM8CBR55ymb2XNslc7WmScckZFI8rHydvyHPwBWKBIeVNOw36Q0QL1yqh4x e3MDJGaN2j2XbcscAZc1xSAlW41ZmbtF8vqm/YyzHC2teYaPszv/LF4Tnny2BjsKUDQ7 UukQQ2GIXmsw0Ikym3sC+zPx2oX3Bt1uNXFqFOlW9Bg1FmCWs03Kc4kp3i9slVF35C97 eMgM+zagFAdyzwEh5T63Ft7RsRBhWr+Bwe5LOMAn1GBbt8Vawj/e9tELUDFYuwZUNO6P y0zA== X-Gm-Message-State: ALQs6tAp5GB4L5fiV3s8fS+SuzJM0M0vExNi3xU71ADCWZdJkw8fHvFR VnqZxVDFdv4QasB7OXcvA+0uwg== X-Google-Smtp-Source: AIpwx49daVwpfowmbcI8k/Z8RWXMt3UvgB2T9FZgHdwgaa9KxfQkfqfWmCBUO1VZtI8zyyKZ8kTGBQ== X-Received: by 10.46.49.10 with SMTP id x10mr3960502ljx.132.1524139573454; Thu, 19 Apr 2018 05:06:13 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id h23sm559971ljc.96.2018.04.19.05.06.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 05:06:12 -0700 (PDT) Date: Thu, 19 Apr 2018 14:06:12 +0200 From: Tomasz Duszynski To: Bruce Richardson Cc: Tomasz Duszynski , dev@dpdk.org, dima@marvell.com, nsamsono@marvell.com Message-ID: <20180419120612.GA14506@sh> References: <1524131138-3204-1-git-send-email-tdu@semihalf.com> <20180419120511.GA11352@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20180419120511.GA11352@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/mvpp2: get MUSDK library path from a meson option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 12:06:14 -0000 On Thu, Apr 19, 2018 at 01:05:11PM +0100, Bruce Richardson wrote: > On Thu, Apr 19, 2018 at 11:45:38AM +0200, Tomasz Duszynski wrote: > > Since not cluttering environment and keeping all relevant > > settings local to the cross build is reasonable get > > MUSDK library installation path from a meson option. > > > > Signed-off-by: Tomasz Duszynski > > --- > > drivers/net/mvpp2/meson.build | 2 +- > > meson_options.txt | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/mvpp2/meson.build b/drivers/net/mvpp2/meson.bu= ild > > index 6ea13ee..e139889 100644 > > --- a/drivers/net/mvpp2/meson.build > > +++ b/drivers/net/mvpp2/meson.build > > @@ -3,7 +3,7 @@ > > # Copyright(c) 2018 Semihalf. > > # All rights reserved. > > > > -path =3D run_command('printenv', 'LIBMUSDK_PATH').stdout().strip() > > +path =3D get_option('lib_musdk_dir') > > lib_dir =3D path + '/lib' > > inc_dir =3D path + '/include' > > > > diff --git a/meson_options.txt b/meson_options.txt > > index 1a674aa..c843278 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -8,6 +8,8 @@ option('include_subdir_arch', type: 'string', value: '', > > description: 'subdirectory where to install arch-dependent headers') > > option('kernel_dir', type: 'string', value: '', > > description: 'path to the kernel for building kernel modules') > > +option('lib_musdk_dir', type: 'string', value: '', > > + description: 'path to the MUSDK library installation directory') > > option('machine', type: 'string', value: 'native', > > description: 'set the target machine type') > > option('max_lcores', type: 'string', value: '128', > > -- > > 2.7.4 > > Looks good. Are you ok with me just squashing this into the original comm= it? > > /Bruce > > Acked-by: Bruce Richardson Sure, thanks. -- - Tomasz Duszy=C5=84ski