From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f45.google.com (mail-pl0-f45.google.com [209.85.160.45]) by dpdk.org (Postfix) with ESMTP id 46255CF66 for ; Fri, 20 Apr 2018 17:14:35 +0200 (CEST) Received: by mail-pl0-f45.google.com with SMTP id e7-v6so5439425plt.6 for ; Fri, 20 Apr 2018 08:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AipmpDMiWT6p0eyW38vVFpThCaa4AE7qnqENHSdO+IQ=; b=zsovujI+Un/V6ViGyocqXQhITTVBGyiWLOPnmIRVHHeN5EXsSTan3n5zfUCLJVTswR l/xCygKjtl9RL5Dh8xKNWlJtylnCqjWRmEdcJfVGbBfMod/BrjIvBwDe3E3s/0Cm/6w0 qvlofgrs1EfBuRzjqjsjz6i7KBecWgbDx46wqmJMFuODAMtEKgBROVvnxFn8ZdGAr93q L6IEQJ5O+NF/gfxMg19I4tGqig0V/FLhMeI5egzQ5mi0fHa1cTkx1STg4nepbA4R9tfY YItPQsz/xqrebCnTMNkOYcQNkTR9CDfPYSg5YMlXP1EbwX/gRFsF+04hHmaNV7uQ6Txg 70Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AipmpDMiWT6p0eyW38vVFpThCaa4AE7qnqENHSdO+IQ=; b=NEQersY9WPi+birPNDf21JCSpMvXzYknJQdzAqg9mjcq/2+tox515gzL01L2ahO1Vn JYZHI7r9JsFeTW8/7FrK4SqBevq3adVcg3obK1ZyGfcnfTfsDZjg0s0Rq/5FgWfz6BL8 CbNFEo+TSXdskDJ4VhqMPn+mVP9dQ9/S+DB+na5P7MzL6WpZB23IAusz2kgnWWbkO0sH bi4D/bnJFSwodgkKm5GbcPvPnHy27isGHV8YU2/MWPQ/od7u03I+zRViXNuGFDpp+6pB Ajn0J05Jw+XKOcXLzryKceWNphQtBBF5c73na1wGZQVriU2EjxMEuRrjcI8arkbamw1F /dxA== X-Gm-Message-State: ALQs6tCUW+HggJWhEJAQTQmjbRunK2xMJu6MLKp+iDBIXfS9hTdBxcBq xnP1wHyNJciPzonL7jBp5Ea05g== X-Google-Smtp-Source: AIpwx4+Z2LCXrP92ow5TI6N6Tix4q2c6UUUlTHWAwXv6hU2wAl8w6kEKldG63mA8gQF5QVUggvPgXg== X-Received: by 2002:a17:902:d24:: with SMTP id 33-v6mr10460203plu.22.1524237274402; Fri, 20 Apr 2018 08:14:34 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id d8sm11960955pfh.177.2018.04.20.08.14.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 08:14:34 -0700 (PDT) Date: Fri, 20 Apr 2018 08:14:31 -0700 From: Stephen Hemminger To: Anoob Joseph Cc: Thomas Monjalon , Akhil Goyal , Declan Doherty , Jingjing Wu , Radu Nicolau , Wenzhuo Lu , Jerin Jacob , Narayana Prasad , Nelio Laranjeiro , dev@dpdk.org Message-ID: <20180420081431.49c1907d@xeon-e3> In-Reply-To: <74e5016e-78ab-2515-0a50-b6f0520c6998@caviumnetworks.com> References: <1521630685-5179-1-git-send-email-anoob.joseph@caviumnetworks.com> <1523428846-9774-1-git-send-email-anoob.joseph@caviumnetworks.com> <1523428846-9774-2-git-send-email-anoob.joseph@caviumnetworks.com> <74e5016e-78ab-2515-0a50-b6f0520c6998@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/5] lib/ethdev: support for inline IPsec events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 15:14:35 -0000 On Thu, 19 Apr 2018 14:45:01 +0530 Anoob Joseph wrote: > > +/** > > * The eth device event type for interrupt, and maybe others in the future. > > */ > > enum rte_eth_event_type { > > @@ -2446,6 +2486,7 @@ enum rte_eth_event_type { > > RTE_ETH_EVENT_INTR_RESET, > > /**< reset interrupt event, sent to VF on PF reset */ > > RTE_ETH_EVENT_VF_MBOX, /**< message from the VF received by PF */ > > + RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */ > > RTE_ETH_EVENT_MACSEC, /**< MACsec offload related event */ > > RTE_ETH_EVENT_INTR_RMV, /**< device removal event */ > > RTE_ETH_EVENT_NEW, /**< port is probed */ Putting new value in middle of enum risks breaking ABI compatiablity