From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com
[209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 2381A7ECB
for <dev@dpdk.org>; Fri, 20 Apr 2018 17:20:49 +0200 (CEST)
Received: by mail-pf0-f174.google.com with SMTP id h69so4437114pfe.13
for <dev@dpdk.org>; Fri, 20 Apr 2018 08:20:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=jWkuhTJD1HwLZ/yc+97PDod3EP/Fm7FaBsVFzzF9SD8=;
b=jFMMLl/sva2rSIaKyFTo9ivmhsf8yEJZ+DMmatcuid5QzakL5e/S2e2dmKLD0ginHD
oY6kESg+PyCr4aZaxkYZmc+MwAvHgqHIlH+yBEZCImyyyUcpyjJX2jrGn8tasB+BEpJH
7tJ6WGgSO74eZHNCnHzkhpQpf5K7geXLKUiBGsoa9XkYQaxGTEdAoxpA79WvXF3i4CWd
4mBiaWA96PLGXcXkxuJ79m0QhjptNMu7d4mZe9ZxuBWvFiwVQ2FRq4rvgyP+4L5tbpPn
7JRznGJCnT236e4/uUp/++Y89HPlY3cbzPWpXnpw55jZBdx3GDXbatjpj0PtinVXz1wo
J8jA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=jWkuhTJD1HwLZ/yc+97PDod3EP/Fm7FaBsVFzzF9SD8=;
b=YvZvrV/oTQ554gAzSRdbnh+qt8j+Us5VD4eQIH7l2+4dNgjJiVNMS9Av1L8atiEgOK
xNyjbh+tIy/9hCQpPuMwleS0URIFStsIL/Plc+Pd85O4eUfR2kZvtFk0JJLC3MDKMixo
iui+AOSzG05Za8HC+WAamurGw2OCdRSJWyPX2eaEDuAOlEqSngEfT3ZAkBpfIqQq/XZS
bkxsLUwtIT59WrnU2Om1R7744y3Ez5e5nIDfGv92yMUbB6amkOT3MYR2jUoCnQoVtMH0
d5i6Ij0Aj696Qw6mIdxmYIOHwL+ubNc0qpZpN2lZ5GbenV3h9ZbJP88vbrz8d/2B3NWG
/Q7g==
X-Gm-Message-State: ALQs6tDm+VvdNfd15HPc5o05x7o0bCEPjHna5JwnC1BpeddVjUr/sZiz
hMZYjy+uVMTyLHH8om5dH2MoAA==
X-Google-Smtp-Source: AIpwx48cGDgxvYmlern+An5r710PMoLdOC0zpf7kyCw3YUOAYM+Skcx5tXJjuD+oloLRz0SuNgiAyg==
X-Received: by 10.99.158.2 with SMTP id s2mr9086840pgd.48.1524237648338;
Fri, 20 Apr 2018 08:20:48 -0700 (PDT)
Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95])
by smtp.gmail.com with ESMTPSA id f8sm10221649pgs.84.2018.04.20.08.20.48
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Fri, 20 Apr 2018 08:20:48 -0700 (PDT)
Date: Fri, 20 Apr 2018 08:20:45 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Sunil Kumar Kori <sunil.kori@nxp.com>
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>, <shreyansh.jain@nxp.com>
Message-ID: <20180420082045.065283f1@xeon-e3>
In-Reply-To: <20180420104541.21987-2-sunil.kori@nxp.com>
References: <20180420104541.21987-1-sunil.kori@nxp.com>
<20180420104541.21987-2-sunil.kori@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] net/dpaa: non supported offloads are
ignored with warning
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 15:20:49 -0000
On Fri, 20 Apr 2018 16:15:40 +0530
Sunil Kumar Kori <sunil.kori@nxp.com> wrote:
> dpaa_eth_dev_info(dev, &dev_info);
> if (((~(dev_info.rx_offload_capa) & rx_offloads) != 0)) {
> - DPAA_PMD_ERR("Some Rx offloads are not supported "
> + DPAA_PMD_WARN("Some Rx offloads are not supported "
> "requested 0x%" PRIx64 " supported 0x%" PRIx64,
The if statement has more parens than necessary.
Please don't break error messages across lines, it is better to have a long source
line since it allows users to use tools like grep to search for error messages.