From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id CD4D51DB9 for ; Mon, 23 Apr 2018 09:40:02 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id u18-v6so11047874wrg.3 for ; Mon, 23 Apr 2018 00:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=mUGzvnDalz6NHJrKEOA/9YCEw4d7NH4FTzLuiC6ET3c=; b=hSwLajXg8jI5cNvwEyWq4NgHidlGssQ/P7RmZLwqLrlsbfH13vZBWhrVZL9qhvTCy3 tR0fG5DHJjL/FCjTQiP9XaqMnL9qxEgjGRLcb+pVprYWQScEOIuSPxHhXaJ/bcSamVAI KFY9/tKv40a0qh9JGF/WbUhrSJ2nShuh6PBQzbnZu3bN8aRXljMt7XrjJDzPjfZ9RKrL VRoFi8/wSyvEfe8ppcET32ZR3SaiQqgmG6N+WfYu6fbKdaBZnt6feKFLK6rJkPWrlRjx wb10zhazJSIi6xbuOsbP4/LFU/rYTtvlWlQJ5AlZEuC1bPJ8WWM906o+G+3jOVUUFhgi ctHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mUGzvnDalz6NHJrKEOA/9YCEw4d7NH4FTzLuiC6ET3c=; b=oqjeRvUfAQKnpAdDZ3m8r4pJsvC3/QONftJ6BF9H+jad13OYcopbxsOlSThnOLx3er wpLkJPAyh6O9bRQr8KhAApQ2gZdx5kdW7RRx0sLkl3wnR55PR/Sp7DTJJAlQjPY4KfPL FMu8rB7yCjgZaLslxMChgDqVmv8Z9WUoD4aN2601JcAHGJJxyF2x4Cq8aRlZPNoWTUtN j6rqYPXZx4ZEkHF3ufOEEotMPD/+9EEAqU/qO+L+9a4e0/jZ8NINEVBITtIXW0lpHXGU 82CAsu6kqENFw++Va7bD9QQaD55RZae9xvP46yojcrFl0vd47k0OCn1ktr1Xkr8ZxeHo 1gFg== X-Gm-Message-State: ALQs6tDe/s+A+YC3FdFrwGe5GB1BtoqCPZIIfX10hI+Ju8pZkJTJ2S/8 QsKUhWqqXIAAVRSnlRyxk9EP X-Google-Smtp-Source: AIpwx49DoL0QQIdTaTLRg6c6lQ+D/2jf0kgBrjAh/GBOyiudOYM4WDJL08a1JpEzfOkx7NL0S/fiNg== X-Received: by 10.28.29.1 with SMTP id d1mr8386568wmd.18.1524469201890; Mon, 23 Apr 2018 00:40:01 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l2sm9715658wmi.16.2018.04.23.00.40.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 00:40:01 -0700 (PDT) Date: Mon, 23 Apr 2018 09:40:46 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Xueming Li Cc: Iremonger Bernard , Shahaf Shuler , dev@dpdk.org Message-ID: <20180423074046.fdrsrog4aom6pzv3@laranjeiro-vm.dev.6wind.com> References: <20180417151436.161374-1-xuemingl@mellanox.com> <20180420122340.113348-5-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180420122340.113348-5-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v5 04/11] net/mlx5: support Rx tunnel type identification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 07:40:03 -0000 On Fri, Apr 20, 2018 at 08:23:33PM +0800, Xueming Li wrote: > This patch introduced tunnel type identification based on flow rules. > If flows of multiple tunnel types built on same queue, > RTE_PTYPE_TUNNEL_MASK will be returned, user application could use bits > in flow mark as tunnel type identifier. >[...] There is still the issue about returning this wrong bits in the mbuf. Bit in the mbuf ptypes must only reflect what is present in the mbuf, using RTE_PTYPE_TUNNEL_MASK means all tunnels are present in the packet which is absolutely wrong. This behavior was not announce and breaks API/ABI. It cannot be accepted yet. I'll suggest to add a new RTE_PTYPE_TUNNEL_UNKNOWN which does not break the ABI or don't add such bits in the mbuf. Regards, -- Nélio Laranjeiro 6WIND