From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 39B492C54
 for <dev@dpdk.org>; Mon, 23 Apr 2018 10:15:11 +0200 (CEST)
Received: from alille-654-1-134-221.w90-34.abo.wanadoo.fr ([90.34.61.221]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1fAWd1-0002bZ-Fs; Mon, 23 Apr 2018 10:15:16 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Mon, 23 Apr 2018 10:15:08 +0200
Date: Mon, 23 Apr 2018 10:15:08 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Message-ID: <20180423081508.b4o7nefb6kmmklf2@platinum>
References: <20180223205648.18690-1-stephen@networkplumber.org>
 <20180223211752.28651-1-stephen@networkplumber.org>
 <13489506.7h5fhggtRA@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13489506.7h5fhggtRA@xps>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v2 0/3] logging enhancements
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2018 08:15:11 -0000

On Wed, Apr 04, 2018 at 01:37:37PM +0200, Thomas Monjalon wrote:
> 23/02/2018 22:17, Stephen Hemminger:
> > The current dynamic logging has some awkward user interface choices.
> > It uses integers for log levels which requires user to know the
> > mapping between numeric and symbolic values.
> > 
> > A bigger problem was the choice of regular expressions and option
> > format for dynamic logging. Dynamic log names are seperated with
> > a period and the wildcard character for regular expressions is
> > a period. It is just a happy accident the expressions like:
> >         "pmd.net.virtio.*"
> > work as expected. This patch set adds a more usable solution
> > with filename style matching.
> > 
> > Also, the choice of comma as seperator for log-level option was
> > not consistent with other options. For other options, comma is
> > used to seperate list of equal values as in:
> >         -l 1,2,3
> > Since new match required a backwards compatiable option the
> > colon is now used to seperate name and value.
> > 
> > So:
> >         --log-level='pmd.net.virtio.*,7'
> > still works as expected. But the prefered syntax is:
> >         --log-level='pmd.net.virtio.*:info'
> 
> +1
> This syntax looks better.

Agree, this is easier to use and understand.